All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Johan Hovold <johan@kernel.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/14] arm64: dts: qcom: sc7280: drop PCIe PHY clock index
Date: Tue, 5 Jul 2022 15:57:45 +0300	[thread overview]
Message-ID: <CAA8EJppskvGeccyxAE7U3O+e_g4r-UhzwK=x1TSF-fZF-Yn67A@mail.gmail.com> (raw)
In-Reply-To: <YsQztl9KHS5csu4A@hovoldconsulting.com>

On Tue, 5 Jul 2022 at 15:51, Johan Hovold <johan@kernel.org> wrote:
>
> On Tue, Jul 05, 2022 at 03:42:08PM +0300, Dmitry Baryshkov wrote:
> > On 05/07/2022 14:40, Johan Hovold wrote:
> > > The QMP PCIe PHY provides a single clock so drop the redundant clock
> > > index.
> > >
> > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> >
> > Hmm. After checking the source code, the clocks entry of the phy@1c0e000
> > node also needs to be fixed.
>
> I assume you meant pci@1c08000 here? Thanks for catching that!
>
> > And also maybe:
> >
> > Fixes: bd7d507935ca ("arm64: dts: qcom: sc7280: Add pcie clock support")
> > Fixes: 92e0ee9f83b3 ("arm64: dts: qcom: sc7280: Add PCIe and PHY related
> > nodes")
>
> Maybe, I'm a bit reluctant to add a Fixes tags for these even if they do
> violate the binding. But sure, why not.

Yep, I'm also in doubt here. In this case this is more logical. I'd
allow you to decide then.

>
> > > ---
> > >   arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++--
> > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > index e66fc67de206..b0ae2dbba50f 100644
> > > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > @@ -818,7 +818,7 @@ gcc: clock-controller@100000 {
> > >                     reg = <0 0x00100000 0 0x1f0000>;
> > >                     clocks = <&rpmhcc RPMH_CXO_CLK>,
> > >                              <&rpmhcc RPMH_CXO_CLK_A>, <&sleep_clk>,
> > > -                            <0>, <&pcie1_lane 0>,
> > > +                            <0>, <&pcie1_lane>,
> > >                              <0>, <0>, <0>, <0>;
> > >                     clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk",
> > >                                   "pcie_0_pipe_clk", "pcie_1_pipe_clk",
> > > @@ -2110,7 +2110,7 @@ pcie1_lane: phy@1c0e200 {
> > >                             clock-names = "pipe0";
> > >
> > >                             #phy-cells = <0>;
> > > -                           #clock-cells = <1>;
> > > +                           #clock-cells = <0>;
> > >                             clock-output-names = "pcie_1_pipe_clk";
> > >                     };
> > >             };
>
> Johan



-- 
With best wishes
Dmitry

  reply	other threads:[~2022-07-05 13:36 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05 11:40 [PATCH 00/14] arm64: dts: qcom: QMP PHY fixes Johan Hovold
2022-07-05 11:40 ` [PATCH 01/14] arm64: dts: qcom: sc7280: drop PCIe PHY clock index Johan Hovold
2022-07-05 11:57   ` Dmitry Baryshkov
2022-07-05 12:42   ` Dmitry Baryshkov
2022-07-05 12:51     ` Johan Hovold
2022-07-05 12:57       ` Dmitry Baryshkov [this message]
2022-07-05 11:40 ` [PATCH 02/14] arm64: dts: qcom: sm8250: add missing PCIe PHY clock-cells Johan Hovold
2022-07-05 11:58   ` Dmitry Baryshkov
2022-07-05 12:42   ` Dmitry Baryshkov
2022-07-05 11:40 ` [PATCH 03/14] arm64: dts: qcom: ipq6018: drop USB PHY clock index Johan Hovold
2022-07-05 11:58   ` Dmitry Baryshkov
2022-07-05 11:40 ` [PATCH 04/14] arm64: dts: qcom: ipq8074: " Johan Hovold
2022-07-05 11:58   ` Dmitry Baryshkov
2022-07-05 11:40 ` [PATCH 05/14] arm64: dts: qcom: msm8996: " Johan Hovold
2022-07-05 11:40 ` [PATCH 06/14] arm64: dts: qcom: msm8998: " Johan Hovold
2022-07-05 13:03   ` Dmitry Baryshkov
2022-07-05 13:09   ` Dmitry Baryshkov
2022-07-07  6:46     ` Johan Hovold
2022-07-05 11:40 ` [PATCH 07/14] arm64: dts: qcom: sm8350: " Johan Hovold
2022-07-05 13:04   ` Dmitry Baryshkov
2022-07-05 11:40 ` [PATCH 08/14] arm64: dts: qcom: sm8450: " Johan Hovold
2022-07-05 11:40 ` [PATCH 09/14] arm64: dts: qcom: sc8280xp: drop UFS PHY clock-cells Johan Hovold
2022-07-05 13:06   ` Dmitry Baryshkov
2022-07-05 11:40 ` [PATCH 10/14] arm64: dts: qcom: sm8250: " Johan Hovold
2022-07-05 11:40 ` [PATCH 11/14] arm64: dts: qcom: sm8450: " Johan Hovold
2022-07-05 11:40 ` [PATCH 12/14] arm64: dts: qcom: msm8996: add missing PCIe " Johan Hovold
2022-07-05 11:40 ` [PATCH 13/14] arm64: dts: qcom: msm8996: use non-empty ranges for PCIe PHYs Johan Hovold
2022-07-05 13:07   ` Dmitry Baryshkov
2022-07-05 11:40 ` [PATCH 14/14] arm64: dts: qcom: msm8996: clean up PCIe PHY node Johan Hovold
2022-07-07  2:46 ` [PATCH 00/14] arm64: dts: qcom: QMP PHY fixes Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA8EJppskvGeccyxAE7U3O+e_g4r-UhzwK=x1TSF-fZF-Yn67A@mail.gmail.com' \
    --to=dmitry.baryshkov@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan+linaro@kernel.org \
    --cc=johan@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.