From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FC20C433EF for ; Fri, 22 Apr 2022 10:42:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1446785AbiDVKpD (ORCPT ); Fri, 22 Apr 2022 06:45:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1446674AbiDVKpC (ORCPT ); Fri, 22 Apr 2022 06:45:02 -0400 Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C49AE30 for ; Fri, 22 Apr 2022 03:42:08 -0700 (PDT) Received: by mail-yb1-xb31.google.com with SMTP id x9so6635013ybe.11 for ; Fri, 22 Apr 2022 03:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sRlCrOg5yqyYWcX3Vmg+YXtz00jXFt02K1SvmfVHuEo=; b=YZKNNVCdCW1H9YpHWN2WwcXTeHpzenuCACQWt1cFsofkPWDjj+CZhGo5qBz34bXMrL a8sGChDb4rj11K4jsnxJQrpcCmi/sg7315+vVhjz+9kcNVq0RLVpAunksA3AeNO7kccO QnNI74QbFKhy8/7Hn2169LoSjveGvAA/Z6ar8aCW0HQP89inqH/9L9x7cFs3j0YJMi24 Vjl4hdYaqEQWvZhlLqiDMVG79bCKBj8oRlloEsu3mrlqK7q7t842V9yGwDbx4guv3qh6 zSgBtiXdqIR3W3Eg+4JrHKGcvBwnvXDx2oadjegPOLpPoCnkhqXvmyP5PynUzjZz/MkE hD9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sRlCrOg5yqyYWcX3Vmg+YXtz00jXFt02K1SvmfVHuEo=; b=UAwm993RVhUqqCLzSANI3xdQHnrPpKYblBKFT2r/lRiMAaZ6LwWKy9xFyLSMWzy3jG IcaKr4iZc3/xKbmE/5fa41gNbpS6JoAFNM0y++TcMMmuji67n3ALoCmnnUw8B93eoLuA OqS8paL2td868Ie+F3gROKLbmprl54NSCw4kdLivn9w1GFpnu9tGrvvR1Yu5t78snt5x SJlrzBVfwAslMkEbSXaN7iPl9kGV7wl4lTw9DnBKbXqdGmr8MuqdL45+C2pF/q3Fr4ML Qmkw6lsP+aEKrKHsviGhEAmmvUo2JYLMr/PObFYmh949BS2t33DdZseEi51NEtVQgIsH cW8A== X-Gm-Message-State: AOAM533/FFE6xmn/y2OpqWdhOJjeyRh8Wufd4bDiR/7QQGsdriw1Gcpl cMyGMNrcnuwDPSSDcvUWBP0glixOyJZimIQlh0zYX0sCnm+4MQ== X-Google-Smtp-Source: ABdhPJy+O9d88W+UfOJ7vyvqvuTfKHdZH3HhJTpSFNYmS29n1nw7GUb9A4Lca7pUm7kxAmK0DqCAl/r83g43Qgqyask= X-Received: by 2002:a25:d507:0:b0:63d:a541:1a8c with SMTP id r7-20020a25d507000000b0063da5411a8cmr3865477ybe.92.1650624127547; Fri, 22 Apr 2022 03:42:07 -0700 (PDT) MIME-Version: 1.0 References: <20220422084951.2776123-1-lv.ruyi@zte.com.cn> In-Reply-To: <20220422084951.2776123-1-lv.ruyi@zte.com.cn> From: Dmitry Baryshkov Date: Fri, 22 Apr 2022 13:41:56 +0300 Message-ID: Subject: Re: [PATCH] drm/msm/dp: fix error check return value of irq_of_parse_and_map() To: cgel.zte@gmail.com Cc: robdclark@gmail.com, sean@poorly.run, quic_abhinavk@quicinc.com, airlied@linux.ie, daniel@ffwll.ch, swboyd@chromium.org, quic_khsieh@quicinc.com, bjorn.andersson@linaro.org, linux@roeck-us.net, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Lv Ruyi , Zeal Robot Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, 22 Apr 2022 at 11:50, wrote: > > From: Lv Ruyi > > The irq_of_parse_and_map() function returns 0 on failure, and does not > return an negative value. > > Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") > Reported-by: Zeal Robot > Signed-off-by: Lv Ruyi Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dp/dp_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index a42732b67349..3926d2ac107d 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1239,7 +1239,7 @@ int dp_display_request_irq(struct msm_dp *dp_display) > dp = container_of(dp_display, struct dp_display_private, dp_display); > > dp->irq = irq_of_parse_and_map(dp->pdev->dev.of_node, 0); > - if (dp->irq < 0) { > + if (!dp->irq) { > rc = dp->irq; > DRM_ERROR("failed to get irq: %d\n", rc); > return rc; > -- > 2.25.1 > -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7132C433F5 for ; Fri, 22 Apr 2022 10:42:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3927E10E029; Fri, 22 Apr 2022 10:42:10 +0000 (UTC) Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8847E10E046 for ; Fri, 22 Apr 2022 10:42:08 +0000 (UTC) Received: by mail-yb1-xb34.google.com with SMTP id b95so13760197ybi.1 for ; Fri, 22 Apr 2022 03:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sRlCrOg5yqyYWcX3Vmg+YXtz00jXFt02K1SvmfVHuEo=; b=YZKNNVCdCW1H9YpHWN2WwcXTeHpzenuCACQWt1cFsofkPWDjj+CZhGo5qBz34bXMrL a8sGChDb4rj11K4jsnxJQrpcCmi/sg7315+vVhjz+9kcNVq0RLVpAunksA3AeNO7kccO QnNI74QbFKhy8/7Hn2169LoSjveGvAA/Z6ar8aCW0HQP89inqH/9L9x7cFs3j0YJMi24 Vjl4hdYaqEQWvZhlLqiDMVG79bCKBj8oRlloEsu3mrlqK7q7t842V9yGwDbx4guv3qh6 zSgBtiXdqIR3W3Eg+4JrHKGcvBwnvXDx2oadjegPOLpPoCnkhqXvmyP5PynUzjZz/MkE hD9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sRlCrOg5yqyYWcX3Vmg+YXtz00jXFt02K1SvmfVHuEo=; b=jqeIwYaEFaCEaDO5wqVMkUiOTEPhofFl4V8uxb3CIV/pvIKzLYQQ6domMp9IhL0Yxk sBUJgq015Bdmlhz0dwOe37yEMHB481Se8VyOE2Nj41rEtTZoQzDIvcxZS38CtzY40iEo tYDk9EfBkAc3XimGBJRR0NCG/4eLi9mkwbSMVPqyCrOemBnV5j2yhvV50rqrwHNHDEWU hVTjPhLw3QpUTDVc5SaJQOHFQciOiM6LIW5fbuEDLGKgdTEpbp2gOyH4FQRDA3plldfw o91BcsQKwvEHf5WmQdBLme5xC8Ilg2/WcqIzyorOrdXC5ZQC/+FB22B8ip1PcK46XYtu rjmQ== X-Gm-Message-State: AOAM530+mlWvVe2ziWnMCwBxNl1LJ7qXUb9zajqArVoHw4YR2jvsBIqa rTizCZffgKipR7OjGs0bCpfZFv01AdHDn9kCjjx2vw== X-Google-Smtp-Source: ABdhPJy+O9d88W+UfOJ7vyvqvuTfKHdZH3HhJTpSFNYmS29n1nw7GUb9A4Lca7pUm7kxAmK0DqCAl/r83g43Qgqyask= X-Received: by 2002:a25:d507:0:b0:63d:a541:1a8c with SMTP id r7-20020a25d507000000b0063da5411a8cmr3865477ybe.92.1650624127547; Fri, 22 Apr 2022 03:42:07 -0700 (PDT) MIME-Version: 1.0 References: <20220422084951.2776123-1-lv.ruyi@zte.com.cn> In-Reply-To: <20220422084951.2776123-1-lv.ruyi@zte.com.cn> From: Dmitry Baryshkov Date: Fri, 22 Apr 2022 13:41:56 +0300 Message-ID: Subject: Re: [PATCH] drm/msm/dp: fix error check return value of irq_of_parse_and_map() To: cgel.zte@gmail.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, airlied@linux.ie, linux-arm-msm@vger.kernel.org, Lv Ruyi , quic_abhinavk@quicinc.com, dri-devel@lists.freedesktop.org, swboyd@chromium.org, bjorn.andersson@linaro.org, quic_khsieh@quicinc.com, sean@poorly.run, Zeal Robot , linux@roeck-us.net Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 22 Apr 2022 at 11:50, wrote: > > From: Lv Ruyi > > The irq_of_parse_and_map() function returns 0 on failure, and does not > return an negative value. > > Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") > Reported-by: Zeal Robot > Signed-off-by: Lv Ruyi Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dp/dp_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index a42732b67349..3926d2ac107d 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1239,7 +1239,7 @@ int dp_display_request_irq(struct msm_dp *dp_display) > dp = container_of(dp_display, struct dp_display_private, dp_display); > > dp->irq = irq_of_parse_and_map(dp->pdev->dev.of_node, 0); > - if (dp->irq < 0) { > + if (!dp->irq) { > rc = dp->irq; > DRM_ERROR("failed to get irq: %d\n", rc); > return rc; > -- > 2.25.1 > -- With best wishes Dmitry