From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69C0CC433EF for ; Tue, 28 Dec 2021 18:24:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237019AbhL1SYr (ORCPT ); Tue, 28 Dec 2021 13:24:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231811AbhL1SYr (ORCPT ); Tue, 28 Dec 2021 13:24:47 -0500 Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8C6BC06173E for ; Tue, 28 Dec 2021 10:24:46 -0800 (PST) Received: by mail-qt1-x834.google.com with SMTP id v22so16876245qtx.8 for ; Tue, 28 Dec 2021 10:24:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N2IL2B0lVlzDDKflM5/dU7wtOruTd4vhkwBkmfQOkqs=; b=uwz15lVlduYINnzR3VpaUPNFKIW6cXsPcXeSstjGPZYSzC1etybiaIXmCbL0y1UOek IoSdyG04WAnCN4KGBp+LqN8hjFJsp8TTW9k1xDhX6gv6MD+8fb6G0PbpXO4TDFESKVuQ iBJcoLwcsgNstrnyf9/FRq9AxNo/8V2uHa+sMwCE/ejPD6jMn6a008/wxy9f+tXE3XLN Y8eMCsDLC+fjA6vkjIhS99c4+4fBIjj+Y5G2KL5PGi8JOTK+pBjm1qzMoPuEOCgmlDiQ Wq660xmsF+wt8qdRC3NQbx9i20K6sCg6jbwqNJ0MfKYdwM//2/to9RuVpesTUX4RDIxX BvvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N2IL2B0lVlzDDKflM5/dU7wtOruTd4vhkwBkmfQOkqs=; b=HG0iYiQpzj8pF+Is4eTl3cFPb3HscTJ/2r79ZBW9oIsWhkHN/7afdKbRhTNmIFjtKX ndW/E+XwkX7nKerPXAY7anFbOjMltotsp0YU0vGr4aM/D9/v7b1hR9evQ6GiNYICKPmi BntPRWs7MeVh8Jc2Mmuqe7OzNdy9/Nk184RW1LCfx+V9RZWqzu0WiOUcafJBCu1lCxdE mErymm4ZgAjQ4O45a0vE9MVZwlQZCI5QQiO8z9EHmSVG5fNVWyee8TNxkGQQoUEoa0eM SJs+bLvM5M669LJ3f7Ow5kDjPHml5UNNPSe8TIWVqy/PNr/xdvOurDFiQQ/jH69odKQx U/tA== X-Gm-Message-State: AOAM53196gwktuNmF+U9poQd4K6qbstl82bBQi0rAE1Xrownt2K3/9nT RuGnHAhB0NzL/gE/0yCH6MPVvxQ2kozdgYL++5v/ig== X-Google-Smtp-Source: ABdhPJyM34OihwzGbuEqYf59SHZSNrRkti5xiawGB0dXZ1399Edl8FEcyIQAtfMGg6IU9j6BAcWfwP/Xe8IsRVNP9O4= X-Received: by 2002:a05:622a:411:: with SMTP id n17mr19589076qtx.439.1640715885970; Tue, 28 Dec 2021 10:24:45 -0800 (PST) MIME-Version: 1.0 References: <20211228052116.1748443-1-bjorn.andersson@linaro.org> <20211228052116.1748443-4-bjorn.andersson@linaro.org> <78491489-6b31-c741-8c69-8d52fb614a6c@linaro.org> In-Reply-To: From: Dmitry Baryshkov Date: Tue, 28 Dec 2021 21:24:34 +0300 Message-ID: Subject: Re: [PATCH 3/8] device property: Helper to match multiple connections To: Bjorn Andersson Cc: Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Greg Kroah-Hartman , Heikki Krogerus , Hans de Goede , "Rafael J. Wysocki" , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, 28 Dec 2021 at 20:03, Bjorn Andersson wrote: > > On Tue 28 Dec 05:09 PST 2021, Dmitry Baryshkov wrote: > > > On 28/12/2021 08:21, Bjorn Andersson wrote: > > > In some cases multiple connections with the same connection id > > > needs to be resolved from a fwnode graph. > > > > > > One such example is when separate hardware is used for performing muxing and/or > > > orientation switching of the SuperSpeed and SBU lines in a USB-C > > > connector. In this case the connector needs to belong to a graph with > > > multiple matching remote endpoints, and the TypeC controller needs to be > > > able to resolve them both. > > > > > > Add a new API that allows this kind of lookup. > > > > > > Signed-off-by: Bjorn Andersson > > > --- > > > drivers/base/property.c | 94 ++++++++++++++++++++++++++++++++++++++++ > > > include/linux/property.h | 5 +++ > > > 2 files changed, 99 insertions(+) > > > > > > diff --git a/drivers/base/property.c b/drivers/base/property.c > > > index cbe4fa298413..0aa0296fd991 100644 > > > --- a/drivers/base/property.c > > > +++ b/drivers/base/property.c > > > @@ -1180,6 +1180,36 @@ fwnode_graph_devcon_match(struct fwnode_handle *fwnode, const char *con_id, > > > return NULL; > > > } > > > +static unsigned int fwnode_graph_devcon_matches(struct fwnode_handle *fwnode, > > > + const char *con_id, void *data, > > > + devcon_match_fn_t match, > > > + void **matches, > > > + unsigned int matches_len) > > > +{ > > > + struct fwnode_handle *node; > > > + struct fwnode_handle *ep; > > > + unsigned int count = 0; > > > + void *ret; > > > + > > > + fwnode_graph_for_each_endpoint(fwnode, ep) { > > > + if (count >= matches_len) { > > > + fwnode_handle_put(ep); > > > + return count; > > > + } > > > + > > > + node = fwnode_graph_get_remote_port_parent(ep); > > > + if (!fwnode_device_is_available(node)) > > > + continue; > > > + > > > + ret = match(node, con_id, data); > > > + fwnode_handle_put(node); > > > + > > > + if (ret) > > > + matches[count++] = ret; > > > + } > > > + return count; > > > +} > > > > This API doesn't let it's user know if there are more matches found in the > > device tree or not. I'd suggest to add 'count' mode that would return the > > amount of found matches if (matches == NULL) && (matches_len == 0). > > > > Unfortunately in this code path we don't know how to "free" the objects > returned by match(), e.g. see how typec_switch_match() returns wrapper > of a refcounted device. > > So we must return all the match results to the caller to it can free > things up based on its knowledge of what matches[] actually contains.. Ugh. Then we should probably return -E2BIG, -ENOSPC or any other such error. Another option might be to split match into match & map functions, first one returning bool and second one returning actual corresponding object.. > > Regards, > Bjorn > > > > + > > > static void * > > > fwnode_devcon_match(struct fwnode_handle *fwnode, const char *con_id, > > > void *data, devcon_match_fn_t match) > > > @@ -1202,6 +1232,35 @@ fwnode_devcon_match(struct fwnode_handle *fwnode, const char *con_id, > > > return NULL; > > > } > > > +static unsigned int fwnode_devcon_matches(struct fwnode_handle *fwnode, > > > + const char *con_id, void *data, > > > + devcon_match_fn_t match, > > > + void **matches, > > > + unsigned int matches_len) > > > +{ > > > + struct fwnode_handle *node; > > > + unsigned int count = 0; > > > + void *ret; > > > + int i; > > > + > > > + for (i = 0; ; i++) { > > > + if (count >= matches_len) > > > + return count; > > > + > > > + node = fwnode_find_reference(fwnode, con_id, i); > > > + if (IS_ERR(node)) > > > + break; > > > + > > > + ret = match(node, NULL, data); > > > + fwnode_handle_put(node); > > > + > > > + if (ret) > > > + matches[count++] = ret; > > > + } > > > + > > > + return count; > > > +} > > > + > > > > Same comment applies. > > > > > /** > > > * fwnode_connection_find_match - Find connection from a device node > > > * @fwnode: Device node with the connection > > > @@ -1229,3 +1288,38 @@ void *fwnode_connection_find_match(struct fwnode_handle *fwnode, > > > return fwnode_devcon_match(fwnode, con_id, data, match); > > > } > > > EXPORT_SYMBOL_GPL(fwnode_connection_find_match); > > > + > > > +/** > > > + * fwnode_connection_find_matches - Find connections from a device node > > > + * @fwnode: Device node with the connection > > > + * @con_id: Identifier for the connection > > > + * @data: Data for the match function > > > + * @match: Function to check and convert the connection description > > > + * @matches: Array of pointers to fill with matches > > > + * @matches_len: Length of @matches > > > + * > > > + * Find up to @matches_len connections with unique identifier @con_id between > > > + * @fwnode and other device nodes. @match will be used to convert the > > > + * connection description to data the caller is expecting to be returned > > > + * through the @matches array. > > > + * > > > + * Return: Number of matches resolved, of negative errno. > > > + */ > > > +int fwnode_connection_find_matches(struct fwnode_handle *fwnode, > > > + const char *con_id, void *data, > > > + devcon_match_fn_t match, > > > + void **matches, unsigned int matches_len) > > > +{ > > > + unsigned int count; > > > + > > > + if (!fwnode || !match || !matches) > > > + return -EINVAL; > > > + > > > + count = fwnode_graph_devcon_matches(fwnode, con_id, data, match, > > > + matches, matches_len); > > > + > > > + return count + fwnode_devcon_matches(fwnode, con_id, data, match, > > > + matches + count, > > > + matches_len - count); > > > +} > > > +EXPORT_SYMBOL_GPL(fwnode_connection_find_matches); > > > diff --git a/include/linux/property.h b/include/linux/property.h > > > index 16f736c698a2..59484ccb260e 100644 > > > --- a/include/linux/property.h > > > +++ b/include/linux/property.h > > > @@ -444,6 +444,11 @@ static inline void *device_connection_find_match(struct device *dev, > > > return fwnode_connection_find_match(dev_fwnode(dev), con_id, data, match); > > > } > > > +int fwnode_connection_find_matches(struct fwnode_handle *fwnode, > > > + const char *con_id, void *data, > > > + devcon_match_fn_t match, > > > + void **matches, unsigned int matches_len); > > > + > > > /* -------------------------------------------------------------------------- */ > > > /* Software fwnode support - when HW description is incomplete or missing */ > > > > > > -- > > With best wishes > > Dmitry -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2310BC433FE for ; Tue, 28 Dec 2021 18:24:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0IWR/6fABSovtvNR0ZH+M/jpKitLlT03nC+hgmHa++w=; b=Jenu2wMCk1N7n1 KY+4YNSy6vdP+k9lpoBayE8E5gKnyQQhYLqxMXFE9Ks2p2tclETBFYJs7gNJbbK0ZibGXkgvF//Cw dNWAux5jhnF6KDLoTcMM7zemU5/XjROpCFpPlhu9alxKujb98avSVdJ6yMXsw2Rgo6nDDvMzjmfNV jlyZNua39CSFTAmlhjSMTv3XaC17lrDGkW+39Abmt3IR552p7UacHeODOVLYqTZGZJY2weLbvRzME gslEH9fx0aiNRwOCqm5JRCgq2TAJucwJhA8njq0Eic7bJKJ4NXd1ya0ROr/QMnVJDuvbgaNHiYOcy 3C9HgRCXzDI15auguMpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2H9W-001j0q-Fz; Tue, 28 Dec 2021 18:24:50 +0000 Received: from mail-qt1-x836.google.com ([2607:f8b0:4864:20::836]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2H9T-001izt-B6 for linux-phy@lists.infradead.org; Tue, 28 Dec 2021 18:24:49 +0000 Received: by mail-qt1-x836.google.com with SMTP id o17so16920425qtk.1 for ; Tue, 28 Dec 2021 10:24:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N2IL2B0lVlzDDKflM5/dU7wtOruTd4vhkwBkmfQOkqs=; b=uwz15lVlduYINnzR3VpaUPNFKIW6cXsPcXeSstjGPZYSzC1etybiaIXmCbL0y1UOek IoSdyG04WAnCN4KGBp+LqN8hjFJsp8TTW9k1xDhX6gv6MD+8fb6G0PbpXO4TDFESKVuQ iBJcoLwcsgNstrnyf9/FRq9AxNo/8V2uHa+sMwCE/ejPD6jMn6a008/wxy9f+tXE3XLN Y8eMCsDLC+fjA6vkjIhS99c4+4fBIjj+Y5G2KL5PGi8JOTK+pBjm1qzMoPuEOCgmlDiQ Wq660xmsF+wt8qdRC3NQbx9i20K6sCg6jbwqNJ0MfKYdwM//2/to9RuVpesTUX4RDIxX BvvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N2IL2B0lVlzDDKflM5/dU7wtOruTd4vhkwBkmfQOkqs=; b=zKoQSGuej3+xJP8VCaD8UA7j0FhRVBqkEja+emQwVLmEYnYHfHtFblXH7/VeLXbID3 tJGmIZGt+U6vXYkC/n7m0y3/i3zTFxQweBMEh0v4t28+xn7sTXBEQlCpYLO67yWazbs0 6Ia+xmGcppPM5bnywIkA/QTcpQIjGI4geFPc+wbaq+8dydWi7BULL9VHSic+Z/Y5cyLL D4UYRShjRx4fr37dOft0ANPP550ylisdoTfK/JoIqsopfdq7vZRl84ViYoDD0cQkqm/w 5VszkVgkWDp1B7H6wc7MkF/UGyrcX9hnHs6ddoM8+KFHvDEH2UV6w+kvmA7thR4I3IKZ hbJQ== X-Gm-Message-State: AOAM530kL+AeicOIK6p41Gb9aveoIQ8uhGtJ4VeuO1VJPTjn76cM+nbG s0RtPa58nvFiAeIwlkwDBTElO2zzJTWsjXbGZv4mWA== X-Google-Smtp-Source: ABdhPJyM34OihwzGbuEqYf59SHZSNrRkti5xiawGB0dXZ1399Edl8FEcyIQAtfMGg6IU9j6BAcWfwP/Xe8IsRVNP9O4= X-Received: by 2002:a05:622a:411:: with SMTP id n17mr19589076qtx.439.1640715885970; Tue, 28 Dec 2021 10:24:45 -0800 (PST) MIME-Version: 1.0 References: <20211228052116.1748443-1-bjorn.andersson@linaro.org> <20211228052116.1748443-4-bjorn.andersson@linaro.org> <78491489-6b31-c741-8c69-8d52fb614a6c@linaro.org> In-Reply-To: From: Dmitry Baryshkov Date: Tue, 28 Dec 2021 21:24:34 +0300 Message-ID: Subject: Re: [PATCH 3/8] device property: Helper to match multiple connections To: Bjorn Andersson Cc: Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Greg Kroah-Hartman , Heikki Krogerus , Hans de Goede , "Rafael J. Wysocki" , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211228_102447_417604_2B01AA17 X-CRM114-Status: GOOD ( 36.32 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Tue, 28 Dec 2021 at 20:03, Bjorn Andersson wrote: > > On Tue 28 Dec 05:09 PST 2021, Dmitry Baryshkov wrote: > > > On 28/12/2021 08:21, Bjorn Andersson wrote: > > > In some cases multiple connections with the same connection id > > > needs to be resolved from a fwnode graph. > > > > > > One such example is when separate hardware is used for performing muxing and/or > > > orientation switching of the SuperSpeed and SBU lines in a USB-C > > > connector. In this case the connector needs to belong to a graph with > > > multiple matching remote endpoints, and the TypeC controller needs to be > > > able to resolve them both. > > > > > > Add a new API that allows this kind of lookup. > > > > > > Signed-off-by: Bjorn Andersson > > > --- > > > drivers/base/property.c | 94 ++++++++++++++++++++++++++++++++++++++++ > > > include/linux/property.h | 5 +++ > > > 2 files changed, 99 insertions(+) > > > > > > diff --git a/drivers/base/property.c b/drivers/base/property.c > > > index cbe4fa298413..0aa0296fd991 100644 > > > --- a/drivers/base/property.c > > > +++ b/drivers/base/property.c > > > @@ -1180,6 +1180,36 @@ fwnode_graph_devcon_match(struct fwnode_handle *fwnode, const char *con_id, > > > return NULL; > > > } > > > +static unsigned int fwnode_graph_devcon_matches(struct fwnode_handle *fwnode, > > > + const char *con_id, void *data, > > > + devcon_match_fn_t match, > > > + void **matches, > > > + unsigned int matches_len) > > > +{ > > > + struct fwnode_handle *node; > > > + struct fwnode_handle *ep; > > > + unsigned int count = 0; > > > + void *ret; > > > + > > > + fwnode_graph_for_each_endpoint(fwnode, ep) { > > > + if (count >= matches_len) { > > > + fwnode_handle_put(ep); > > > + return count; > > > + } > > > + > > > + node = fwnode_graph_get_remote_port_parent(ep); > > > + if (!fwnode_device_is_available(node)) > > > + continue; > > > + > > > + ret = match(node, con_id, data); > > > + fwnode_handle_put(node); > > > + > > > + if (ret) > > > + matches[count++] = ret; > > > + } > > > + return count; > > > +} > > > > This API doesn't let it's user know if there are more matches found in the > > device tree or not. I'd suggest to add 'count' mode that would return the > > amount of found matches if (matches == NULL) && (matches_len == 0). > > > > Unfortunately in this code path we don't know how to "free" the objects > returned by match(), e.g. see how typec_switch_match() returns wrapper > of a refcounted device. > > So we must return all the match results to the caller to it can free > things up based on its knowledge of what matches[] actually contains.. Ugh. Then we should probably return -E2BIG, -ENOSPC or any other such error. Another option might be to split match into match & map functions, first one returning bool and second one returning actual corresponding object.. > > Regards, > Bjorn > > > > + > > > static void * > > > fwnode_devcon_match(struct fwnode_handle *fwnode, const char *con_id, > > > void *data, devcon_match_fn_t match) > > > @@ -1202,6 +1232,35 @@ fwnode_devcon_match(struct fwnode_handle *fwnode, const char *con_id, > > > return NULL; > > > } > > > +static unsigned int fwnode_devcon_matches(struct fwnode_handle *fwnode, > > > + const char *con_id, void *data, > > > + devcon_match_fn_t match, > > > + void **matches, > > > + unsigned int matches_len) > > > +{ > > > + struct fwnode_handle *node; > > > + unsigned int count = 0; > > > + void *ret; > > > + int i; > > > + > > > + for (i = 0; ; i++) { > > > + if (count >= matches_len) > > > + return count; > > > + > > > + node = fwnode_find_reference(fwnode, con_id, i); > > > + if (IS_ERR(node)) > > > + break; > > > + > > > + ret = match(node, NULL, data); > > > + fwnode_handle_put(node); > > > + > > > + if (ret) > > > + matches[count++] = ret; > > > + } > > > + > > > + return count; > > > +} > > > + > > > > Same comment applies. > > > > > /** > > > * fwnode_connection_find_match - Find connection from a device node > > > * @fwnode: Device node with the connection > > > @@ -1229,3 +1288,38 @@ void *fwnode_connection_find_match(struct fwnode_handle *fwnode, > > > return fwnode_devcon_match(fwnode, con_id, data, match); > > > } > > > EXPORT_SYMBOL_GPL(fwnode_connection_find_match); > > > + > > > +/** > > > + * fwnode_connection_find_matches - Find connections from a device node > > > + * @fwnode: Device node with the connection > > > + * @con_id: Identifier for the connection > > > + * @data: Data for the match function > > > + * @match: Function to check and convert the connection description > > > + * @matches: Array of pointers to fill with matches > > > + * @matches_len: Length of @matches > > > + * > > > + * Find up to @matches_len connections with unique identifier @con_id between > > > + * @fwnode and other device nodes. @match will be used to convert the > > > + * connection description to data the caller is expecting to be returned > > > + * through the @matches array. > > > + * > > > + * Return: Number of matches resolved, of negative errno. > > > + */ > > > +int fwnode_connection_find_matches(struct fwnode_handle *fwnode, > > > + const char *con_id, void *data, > > > + devcon_match_fn_t match, > > > + void **matches, unsigned int matches_len) > > > +{ > > > + unsigned int count; > > > + > > > + if (!fwnode || !match || !matches) > > > + return -EINVAL; > > > + > > > + count = fwnode_graph_devcon_matches(fwnode, con_id, data, match, > > > + matches, matches_len); > > > + > > > + return count + fwnode_devcon_matches(fwnode, con_id, data, match, > > > + matches + count, > > > + matches_len - count); > > > +} > > > +EXPORT_SYMBOL_GPL(fwnode_connection_find_matches); > > > diff --git a/include/linux/property.h b/include/linux/property.h > > > index 16f736c698a2..59484ccb260e 100644 > > > --- a/include/linux/property.h > > > +++ b/include/linux/property.h > > > @@ -444,6 +444,11 @@ static inline void *device_connection_find_match(struct device *dev, > > > return fwnode_connection_find_match(dev_fwnode(dev), con_id, data, match); > > > } > > > +int fwnode_connection_find_matches(struct fwnode_handle *fwnode, > > > + const char *con_id, void *data, > > > + devcon_match_fn_t match, > > > + void **matches, unsigned int matches_len); > > > + > > > /* -------------------------------------------------------------------------- */ > > > /* Software fwnode support - when HW description is incomplete or missing */ > > > > > > -- > > With best wishes > > Dmitry -- With best wishes Dmitry -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy