From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C38D7C43334 for ; Fri, 24 Jun 2022 23:45:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231859AbiFXXpt (ORCPT ); Fri, 24 Jun 2022 19:45:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231459AbiFXXpr (ORCPT ); Fri, 24 Jun 2022 19:45:47 -0400 Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2812E8AC19 for ; Fri, 24 Jun 2022 16:45:46 -0700 (PDT) Received: by mail-qk1-x729.google.com with SMTP id b125so2956034qkg.11 for ; Fri, 24 Jun 2022 16:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z3MRZDPjbjqka5SFCsRF0GaePuedl2AIb6glbaDxLPo=; b=T1jZ/wuAXd4vkBbmbjvR4zc2gMr+VrXytSGHLBHq2r677FwX7N3/8VRvVeku7U9PL4 z5UOWQn1DzpuX52KtITNRF3Ywiklcq2o9+xtPOrMchkBSRMQBAh9u2490x1FYlA83+Fw 3q7/7YYig0nseD0c+Z92CqG7EJ7irgF7zexvcR/iaNm9ym7oke5sLufp9rSdU2HBRYgn lFpWRdhpyb2VnBVu1ENsguh/VNuNa9AdK2OKDjFndacjelg0wh+eEtq2hlJ801HyxLXn OQxYh3jQLwSrcxj2ROwUU9NLUWQl/Z1tLvlA65PmyaHELR6gJsMf2lJpP1DYZsm88RIG kRmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z3MRZDPjbjqka5SFCsRF0GaePuedl2AIb6glbaDxLPo=; b=d3ysvcEodu7L+fWMdfO2YL8HlR2CYe1+Vw/Urquy0LYcJLskYW/SY9ByXojqLrxP/T DTH5Yl4XSyioWYCnkmey0iFyX+MjukSgYBAl0s8v9HTfeymS2nzrpHZh5+p3tAfZAk6l jrCMqBA1JyB0ndsHq+CYATmRGjUvki4WJOYSEZIJTOTzJzgNDrk9B9pLe02xzZorksC0 QYu/OloYfFtKSwUtFYBoTVo0Od1G0mRfLwnGdJLVQpfa5eZTHPF5ft4HX2D/N8EsSAEQ eMpr8F5+9UTamy9R6rEWejdsLqWtlZf60EZW4xF4ACWA0py/HWxPe/otV/nk/UkBnu7V ZGjQ== X-Gm-Message-State: AJIora8PCQcBEtQ9Wx9ig7U7YcrJCIZQ1LGdBmyYlvaf69S2VYBfzW0E U61b2uFozHqK9WmE7mO2DnKbRlQ3lz0fGOYxkLZqLA== X-Google-Smtp-Source: AGRyM1v/i8BJMvLqu4IlBuePJHdL20SOPQr3QObkB7VQeNVKxSUFFYLdnJmiIKpbsI6PhCqNqVQetH1um/ElYuHDTPU= X-Received: by 2002:a05:620a:31a0:b0:6a7:549f:a788 with SMTP id bi32-20020a05620a31a000b006a7549fa788mr1331198qkb.203.1656114345250; Fri, 24 Jun 2022 16:45:45 -0700 (PDT) MIME-Version: 1.0 References: <1656090912-18074-1-git-send-email-quic_khsieh@quicinc.com> <1656090912-18074-2-git-send-email-quic_khsieh@quicinc.com> <0632e72a-3bd2-6320-4a00-6d3cf7d40513@quicinc.com> In-Reply-To: <0632e72a-3bd2-6320-4a00-6d3cf7d40513@quicinc.com> From: Dmitry Baryshkov Date: Sat, 25 Jun 2022 02:45:33 +0300 Message-ID: Subject: Re: [PATCH v1 1/3] drm/msm/dp: move struc of msm_display_info to msm_drv.h To: Kuogee Hsieh Cc: Doug Anderson , dri-devel , Rob Clark , Sean Paul , Stephen Boyd , Vinod Koul , Daniel Vetter , David Airlie , Andy Gross , Bjorn Andersson , "Abhinav Kumar (QUIC)" , "Aravind Venkateswaran (QUIC)" , Sankeerth Billakanti , freedreno , linux-arm-msm , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sat, 25 Jun 2022 at 00:51, Kuogee Hsieh wrote: > On 6/24/2022 2:40 PM, Doug Anderson wrote: > > On Fri, Jun 24, 2022 at 10:15 AM Kuogee Hsieh wrote: > >> +struct msm_display_info { > >> + int intf_type; > >> + uint32_t capabilities; > >> + uint32_t num_of_h_tiles; > >> + uint32_t h_tile_instance[MAX_H_TILES_PER_DISPLAY]; > >> + bool is_te_using_watchdog_timer; > > ...but then when you "move" the structure to its new location, which > > should be a noop, then the "dsc" variable vanishes (along with > > the kernel doc description of it before the structure). > > Sorry, i did not resolve the conflicts correctly when i cherry-pick > them to msm-next tree. > > Will fix them. I would strongly suggest doing development on top of msm/next or linux-next. Using any other tree results in lots of problems starting from the lame Fixes tags that we have been constantly seeing for the last few months, conflicts when the patch is being rebased or cherry-picked and ending up with the patches not being tested with the tree that they are being applied to. -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F8FCC43334 for ; Fri, 24 Jun 2022 23:45:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9C51910EBF9; Fri, 24 Jun 2022 23:45:47 +0000 (UTC) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 32E6410F04A for ; Fri, 24 Jun 2022 23:45:46 +0000 (UTC) Received: by mail-qk1-x72d.google.com with SMTP id r138so2936306qke.13 for ; Fri, 24 Jun 2022 16:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z3MRZDPjbjqka5SFCsRF0GaePuedl2AIb6glbaDxLPo=; b=T1jZ/wuAXd4vkBbmbjvR4zc2gMr+VrXytSGHLBHq2r677FwX7N3/8VRvVeku7U9PL4 z5UOWQn1DzpuX52KtITNRF3Ywiklcq2o9+xtPOrMchkBSRMQBAh9u2490x1FYlA83+Fw 3q7/7YYig0nseD0c+Z92CqG7EJ7irgF7zexvcR/iaNm9ym7oke5sLufp9rSdU2HBRYgn lFpWRdhpyb2VnBVu1ENsguh/VNuNa9AdK2OKDjFndacjelg0wh+eEtq2hlJ801HyxLXn OQxYh3jQLwSrcxj2ROwUU9NLUWQl/Z1tLvlA65PmyaHELR6gJsMf2lJpP1DYZsm88RIG kRmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z3MRZDPjbjqka5SFCsRF0GaePuedl2AIb6glbaDxLPo=; b=B9skvelTfhhuBPJKap6RlhqWkExL39RtXgfw2UxfBFvtRr+I6wlj+Kam3FZVvpx3TH WEfnR5RkSYAWzm05jU/A47mPR0Hc+DTE0D7cslKfjB1xHgJjA67ZA4epDVVcN1cqZsCc BNDq7YZEIC6jxG7P0c1BtDFEYdG/FpExOr0BplIBEzwE2qddlPeCThuzzebaOr85ve3F JkizvYUufeOPKTTKpbw6oAfCb7s/aH7Zr5eiY7TFAoGZlFlFlM4phouOvz8NkFbLd+/I ctsH4LiycnAke6bHcIUAX0FhVPG/IVPFOROKeoxE9fI6nNP+tnQud9NjGnV0G5Fy0akq AAUg== X-Gm-Message-State: AJIora/sFiInGwOlfI704I8UzInN5lB8IgequrkodWPj2Ou/8KEA1HMe u2LmnhxFzKzy4XiciBWJFNcB/fgidOZhBIPQhS0XJw== X-Google-Smtp-Source: AGRyM1v/i8BJMvLqu4IlBuePJHdL20SOPQr3QObkB7VQeNVKxSUFFYLdnJmiIKpbsI6PhCqNqVQetH1um/ElYuHDTPU= X-Received: by 2002:a05:620a:31a0:b0:6a7:549f:a788 with SMTP id bi32-20020a05620a31a000b006a7549fa788mr1331198qkb.203.1656114345250; Fri, 24 Jun 2022 16:45:45 -0700 (PDT) MIME-Version: 1.0 References: <1656090912-18074-1-git-send-email-quic_khsieh@quicinc.com> <1656090912-18074-2-git-send-email-quic_khsieh@quicinc.com> <0632e72a-3bd2-6320-4a00-6d3cf7d40513@quicinc.com> In-Reply-To: <0632e72a-3bd2-6320-4a00-6d3cf7d40513@quicinc.com> From: Dmitry Baryshkov Date: Sat, 25 Jun 2022 02:45:33 +0300 Message-ID: Subject: Re: [PATCH v1 1/3] drm/msm/dp: move struc of msm_display_info to msm_drv.h To: Kuogee Hsieh Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sankeerth Billakanti , "Abhinav Kumar \(QUIC\)" , David Airlie , freedreno , dri-devel , Doug Anderson , Vinod Koul , Andy Gross , Bjorn Andersson , linux-arm-msm , "Aravind Venkateswaran \(QUIC\)" , Stephen Boyd , Sean Paul , LKML Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, 25 Jun 2022 at 00:51, Kuogee Hsieh wrote: > On 6/24/2022 2:40 PM, Doug Anderson wrote: > > On Fri, Jun 24, 2022 at 10:15 AM Kuogee Hsieh wrote: > >> +struct msm_display_info { > >> + int intf_type; > >> + uint32_t capabilities; > >> + uint32_t num_of_h_tiles; > >> + uint32_t h_tile_instance[MAX_H_TILES_PER_DISPLAY]; > >> + bool is_te_using_watchdog_timer; > > ...but then when you "move" the structure to its new location, which > > should be a noop, then the "dsc" variable vanishes (along with > > the kernel doc description of it before the structure). > > Sorry, i did not resolve the conflicts correctly when i cherry-pick > them to msm-next tree. > > Will fix them. I would strongly suggest doing development on top of msm/next or linux-next. Using any other tree results in lots of problems starting from the lame Fixes tags that we have been constantly seeing for the last few months, conflicts when the patch is being rebased or cherry-picked and ending up with the patches not being tested with the tree that they are being applied to. -- With best wishes Dmitry