From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0D3FC433EF for ; Mon, 14 Mar 2022 19:25:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244021AbiCNT1G (ORCPT ); Mon, 14 Mar 2022 15:27:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236868AbiCNT1G (ORCPT ); Mon, 14 Mar 2022 15:27:06 -0400 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1184A3B3DB for ; Mon, 14 Mar 2022 12:25:56 -0700 (PDT) Received: by mail-qk1-x735.google.com with SMTP id c7so13671250qka.7 for ; Mon, 14 Mar 2022 12:25:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ghXEBznY5vyHF7+fdWoY5v3OsItcalBlY/KG9K7yOhU=; b=e2Ud08S0Q7pZF215eRKz7vixHUKMgQNfUK9aOMWNfqStkSdZvWC5Mszd1gEoj/cIZz IrZAiRKPJytuFVu+isbnZ5e2rAWsyFV79zcMh9/gmlkX6+VS8y5uGJTay/iSQjW/XKar ayFug9ECos7jYnvjtc0aR6Qmtns5qgU5i4/dof+t3R4fwNzT32kHj5wHd1lmFVGOpo3c VzjLN9YEOS+PZOQ5vDnQHZ+wSvqk5QfEgoYhbfvKDBo0BAVVKdSnMYOyilpqGop0zHsL 5HjdxNO1dsVE598rdiHBPM9joHRTxK2XG7aFr29FLlMOR3LRz/PPhkSKnpJmFSQHlnr4 N8sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ghXEBznY5vyHF7+fdWoY5v3OsItcalBlY/KG9K7yOhU=; b=VA20Vb71DHg47QWuaQXlCpcyyABpGv6/P59/tyo1L8hJh4Og1d0+GB2mN3LQFJ0kK3 4y+V3CvKsWSlRxTxKmWN5Oj/LOG9rRv0IM6HsFHgYY05Algo64WWHZPXjPkayrve0wHi FwCLTVmgpDW4mC2NUHmEYU5WOrntececg9RF4v0Ab9LSDWehmbUQRtWU/iXghZdri8eQ nrnse0wECJJXolGmjxZR69lDkLWeyZg24qcGg0wW8SwBFV7bUmz8wtCuObVVL0yLFOIo Mnx8H8n+4052RXkl94fcGfeupRC7tyBzkI7NGb1VrpOVE/RQz7ub+xesS01AkWuaRUSU 5N7w== X-Gm-Message-State: AOAM533Vx3LuHWEfDUE66/HtINgTQC7h240Jhu17QR2kKLEAzIYYFGxV ic+c10+PLZW86wPIUyPAex7tVj5/qT6LurJbajm7Yg== X-Google-Smtp-Source: ABdhPJyQEYq/aa0gjJEO9Tga4REDnt5I6yrfTmBRW4eRCznjlBUHHMh0lYM73RO7oxgtpMzyqDMXDoNaOp6yMHVijEk= X-Received: by 2002:a05:620a:170a:b0:67d:be5c:204a with SMTP id az10-20020a05620a170a00b0067dbe5c204amr5211992qkb.593.1647285955193; Mon, 14 Mar 2022 12:25:55 -0700 (PDT) MIME-Version: 1.0 References: <1647269217-14064-1-git-send-email-quic_vpolimer@quicinc.com> <1647269217-14064-2-git-send-email-quic_vpolimer@quicinc.com> In-Reply-To: <1647269217-14064-2-git-send-email-quic_vpolimer@quicinc.com> From: Dmitry Baryshkov Date: Mon, 14 Mar 2022 22:25:44 +0300 Message-ID: Subject: Re: [PATCH v6 1/5] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table during probe To: Vinod Polimera Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robdclark@gmail.com, dianders@chromium.org, quic_kalyant@quicinc.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, 14 Mar 2022 at 17:47, Vinod Polimera wrote: > > use max clock during probe/bind sequence from the opp table. > The clock will be scaled down when framework sends an update. > > Fixes: 25fdd5933("drm/msm: Add SDM845 DPU support") > Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index e29796c..9c346ce 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -1202,7 +1202,9 @@ static int dpu_bind(struct device *dev, struct device *master, void *data) > struct platform_device *pdev = to_platform_device(dev); > struct drm_device *ddev = priv->dev; > struct dpu_kms *dpu_kms; > + struct dev_pm_opp *opp; > int ret = 0; > + unsigned long max_freq = ULONG_MAX; > > dpu_kms = devm_kzalloc(&pdev->dev, sizeof(*dpu_kms), GFP_KERNEL); > if (!dpu_kms) > @@ -1225,6 +1227,12 @@ static int dpu_bind(struct device *dev, struct device *master, void *data) > } > dpu_kms->num_clocks = ret; > > + opp = dev_pm_opp_find_freq_floor(dev, &max_freq); > + if (!IS_ERR(opp)) > + dev_pm_opp_put(opp); > + > + dev_pm_opp_set_rate(dev, max_freq); > + > platform_set_drvdata(pdev, dpu_kms); > > ret = msm_kms_init(&dpu_kms->base, &kms_funcs); > -- > 2.7.4 > -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 305DCC433F5 for ; Mon, 14 Mar 2022 19:25:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4658610E2A3; Mon, 14 Mar 2022 19:25:57 +0000 (UTC) Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C09B10E1FB for ; Mon, 14 Mar 2022 19:25:56 +0000 (UTC) Received: by mail-qk1-x72f.google.com with SMTP id b67so13686341qkc.6 for ; Mon, 14 Mar 2022 12:25:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ghXEBznY5vyHF7+fdWoY5v3OsItcalBlY/KG9K7yOhU=; b=e2Ud08S0Q7pZF215eRKz7vixHUKMgQNfUK9aOMWNfqStkSdZvWC5Mszd1gEoj/cIZz IrZAiRKPJytuFVu+isbnZ5e2rAWsyFV79zcMh9/gmlkX6+VS8y5uGJTay/iSQjW/XKar ayFug9ECos7jYnvjtc0aR6Qmtns5qgU5i4/dof+t3R4fwNzT32kHj5wHd1lmFVGOpo3c VzjLN9YEOS+PZOQ5vDnQHZ+wSvqk5QfEgoYhbfvKDBo0BAVVKdSnMYOyilpqGop0zHsL 5HjdxNO1dsVE598rdiHBPM9joHRTxK2XG7aFr29FLlMOR3LRz/PPhkSKnpJmFSQHlnr4 N8sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ghXEBznY5vyHF7+fdWoY5v3OsItcalBlY/KG9K7yOhU=; b=cDnPlhyc5TKtNeFT9KEpDP/I104WNNpHz6pFVotuwXVpf5j06fQJxsb8FFENZ40RZ2 YA4GKlVPZjWbzbHPqNsp5FV1/I2Pkmy4hmvJKZyFj2OfAJl49JikgMy3M0uspEcp+ZFP MqPjn7b2FaS2aFM4ifPOOCQ2el4Wxx/BXiHAXH2lxmbze2ugaI2/uUdi10ZLYcP3dqyO JSY8VQpSXVmRilHjlXnv7Fs6dAjI8jCWK2HQ7DSP/DOpZVTl7uk3XCzYFKS1NCnj4gjt 0IAOlikitsH0tPbnrtLkUiS16nIvRUx/uV7pbMJwLuVgY3U7khNgBIVTBkfkQ83tsk2E oUoQ== X-Gm-Message-State: AOAM533D8dEfZHJFFYC/QT6UV0joOd2AZOP7MG0Q/US+B7aMeEraf455 cubWDako4nPpZtZyk3x0ZlxLn88F/qj2myGFe3c9BYZjW1bAPQ== X-Google-Smtp-Source: ABdhPJyQEYq/aa0gjJEO9Tga4REDnt5I6yrfTmBRW4eRCznjlBUHHMh0lYM73RO7oxgtpMzyqDMXDoNaOp6yMHVijEk= X-Received: by 2002:a05:620a:170a:b0:67d:be5c:204a with SMTP id az10-20020a05620a170a00b0067dbe5c204amr5211992qkb.593.1647285955193; Mon, 14 Mar 2022 12:25:55 -0700 (PDT) MIME-Version: 1.0 References: <1647269217-14064-1-git-send-email-quic_vpolimer@quicinc.com> <1647269217-14064-2-git-send-email-quic_vpolimer@quicinc.com> In-Reply-To: <1647269217-14064-2-git-send-email-quic_vpolimer@quicinc.com> From: Dmitry Baryshkov Date: Mon, 14 Mar 2022 22:25:44 +0300 Message-ID: Subject: Re: [PATCH v6 1/5] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table during probe To: Vinod Polimera Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quic_kalyant@quicinc.com, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 14 Mar 2022 at 17:47, Vinod Polimera wrote: > > use max clock during probe/bind sequence from the opp table. > The clock will be scaled down when framework sends an update. > > Fixes: 25fdd5933("drm/msm: Add SDM845 DPU support") > Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index e29796c..9c346ce 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -1202,7 +1202,9 @@ static int dpu_bind(struct device *dev, struct device *master, void *data) > struct platform_device *pdev = to_platform_device(dev); > struct drm_device *ddev = priv->dev; > struct dpu_kms *dpu_kms; > + struct dev_pm_opp *opp; > int ret = 0; > + unsigned long max_freq = ULONG_MAX; > > dpu_kms = devm_kzalloc(&pdev->dev, sizeof(*dpu_kms), GFP_KERNEL); > if (!dpu_kms) > @@ -1225,6 +1227,12 @@ static int dpu_bind(struct device *dev, struct device *master, void *data) > } > dpu_kms->num_clocks = ret; > > + opp = dev_pm_opp_find_freq_floor(dev, &max_freq); > + if (!IS_ERR(opp)) > + dev_pm_opp_put(opp); > + > + dev_pm_opp_set_rate(dev, max_freq); > + > platform_set_drvdata(pdev, dpu_kms); > > ret = msm_kms_init(&dpu_kms->base, &kms_funcs); > -- > 2.7.4 > -- With best wishes Dmitry