From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE7EC6FD1F for ; Tue, 14 Mar 2023 17:24:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229525AbjCNRYC (ORCPT ); Tue, 14 Mar 2023 13:24:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbjCNRYB (ORCPT ); Tue, 14 Mar 2023 13:24:01 -0400 Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 183885F50C for ; Tue, 14 Mar 2023 10:23:59 -0700 (PDT) Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-540cb2fb5b9so213634227b3.3 for ; Tue, 14 Mar 2023 10:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678814638; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lt10PpjJqJ0ufR48VoDC3ODoiczICej7BJnkuMGHSgc=; b=ryQ7QPJ+wJlpme5yL66l69YKETUMSLRgwglWdhdg/VBuOpRMhjftw/GlzFm1o56Mdk p0CyUkiO0LVWTWgC41tyDENP1SZ9a5DQg7872SBj/PLwGOyO2K+G0QNZqCw7s9JLikrn Ol84oIBl9ODaE3vOWGOikJiCXTaJsecvSh7TkuCc6yF9VDR3LF7PyTMhAJQJ7GSM6r+U zfRxPqz21rdn6ev+qv2SA5DEPKNyjKkQfSOkhKytaK03ANfll5oigoa69gwGOuJb37xJ a85B4oe0rBAQCShTZLUqHmugZqMbD0TBwBIDKNEvOmaxauTCg8UKlUpr1yw79O28qjZ2 DG0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678814638; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lt10PpjJqJ0ufR48VoDC3ODoiczICej7BJnkuMGHSgc=; b=J+AgXk9Salh7xHjUiM1eXZA0Xt3Y/+f42Eya0X+MGwH0VtdMKqR8C+K/ahR8w4cZlu yRSbARgVDrZZnr+ZxQvjhAJ0dhJEKPYiolbx6UYE3R5A67R/QCmBwvuUCiw+3KAIH7yE ieDGXKE+DD44U/IdJ3p12siN+7+T79nPB1ZjGURmhLLE4R0fYFiQK9hobVIaFLN8RtIP 62ukJJIIfX6aHY885R9QmsoWzrUxcZzv09M263A5XTGCIKd3rzhtnVHUKphEwDWp0wV4 MBthR1jPTsd9zoHRvodNMWAl6erIjwjM4U54ZBhrLuApo01kQax4cfHxrgYudN0YyGKx vJCQ== X-Gm-Message-State: AO0yUKVcjtramgt2dXREbCe0IX6RULnwbnZFTJRII4M3L3fqUscmIXSQ 3/0ZgpZOHeQGCKfkhcNDAgr63wrwO+z7dIfHvHdRSA== X-Google-Smtp-Source: AK7set/IVbS0h4lS3Qc/jrY6f7sA+AXwbSCVnwoBSQHoGQhRyWFxQHBZiyuSn6NtRJnVPnSx62nNhixXCyy5Pr5fluo= X-Received: by 2002:a81:ae5d:0:b0:541:85d2:af21 with SMTP id g29-20020a81ae5d000000b0054185d2af21mr7173793ywk.5.1678814638243; Tue, 14 Mar 2023 10:23:58 -0700 (PDT) MIME-Version: 1.0 References: <20230310005704.1332368-1-dmitry.baryshkov@linaro.org> <20230310005704.1332368-30-dmitry.baryshkov@linaro.org> <6a570e7d-f67e-a95d-4e15-db78a8b4a29d@quicinc.com> <7e2cfd1b-d1a1-acd1-91fd-1abbd1a86a1b@linaro.org> <840a4f3f-09df-f0a1-6ee6-488775739a74@quicinc.com> In-Reply-To: <840a4f3f-09df-f0a1-6ee6-488775739a74@quicinc.com> From: Dmitry Baryshkov Date: Tue, 14 Mar 2023 19:23:47 +0200 Message-ID: Subject: Re: [PATCH v5 29/32] drm/msm/dpu: enable SmartDMA for the rest of the platforms To: Abhinav Kumar Cc: Rob Clark , Sean Paul , Stephen Boyd , David Airlie , Daniel Vetter , Bjorn Andersson , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, 14 Mar 2023 at 18:48, Abhinav Kumar wrote: > > > > On 3/14/2023 9:43 AM, Dmitry Baryshkov wrote: > > On 14/03/2023 18:35, Abhinav Kumar wrote: > >> > >> > >> On 3/14/2023 3:58 AM, Dmitry Baryshkov wrote: > >>> On 14/03/2023 07:08, Abhinav Kumar wrote: > >>>> > >>>> > >>>> On 3/9/2023 4:57 PM, Dmitry Baryshkov wrote: > >>>>> Enable SmartDMA features for the rest of the platforms where it is > >>>>> supposed to work. > >>>>> > >>>>> Signed-off-by: Dmitry Baryshkov > >>>> > >>>> I am so glad we split this. Without visual validation check we > >>>> wouldnt have caught the issues and would have ended up with a blank > >>>> half screen on our sc7280 CBs on DP. > >>> > >>> yes, the r_pipe was indeed mea culpa, when I didn't fully validate > >>> the results of a rebase. However this doesn't seem to be an > >>> sc7280-specific question. Are there any platform-specific issues with > >>> SmartDMA/multirect/planes revealed during testing? In other words, > >>> were there any issues which warrant this split? > >>> > > Missed this question. > > Well the sc7280 issue was itself coming from a platform specific > maxlinewidth. So like I wrote there, my monitor supported 2560x1600 and > the maxlinewidth for sc7280 is 2400. Thats why I could catch this. > > With RB5 or other platforms in the previous patch, this would not have > been caught without forcing some conditions. > > >>>> > >>>> For sc7280, I validated the foll cases: > >>> > >>> Thanks a lot! > >>> > >>>> > >>>> 1) Basic Chrome UI comes up > >>>> 2) Validated some browser use-cases and played some youtube videos > >>>> 3) Validated multiple plug-in/plug-out cases with DP connected > >>>> 4) IGT test cases with DP connected: > >>>> - kms_atomic > >>>> - kms_atomic_transition > >>>> - kms_pipe_basic_crc > >>>> > >>>> Some notes: > >>>> > >>>> 1) I wanted to test 4k with this too but my monitor only supports > >>>> 4k@60 which is not possible with 24bpp with 2 lanes and due to the > >>>> HBR3 black screen issue I could not test that so far. But since I > >>>> have that issue even with 1080P and without these changes, it should > >>>> have no effect due to this series. > >>>> > >>>> 2) I wanted to test some YUV overlay cases but I still cannot find > >>>> one on chrome. Its always using RGB. Will check with others. > >>> > >>> Testing YUV would definitely be a must, especially for the SSPP > >>> allocation. Can you possibly check whether contemporaty Xv > >>> implementation employs YUV planes? You can try that using `mpv -xo > >>> xv` or `mplayer -vo xv` > >>> > >> > >> Let me get some feedback from CrOS folks here instead of just trial > >> and error to find out. > >> > >>>> > >>>> With these two noted, this change and this series has my > >>>> > >>>> Tested-by: Abhinav Kumar > >>>> > >> > >> There is no guarantee we will end up finding the YUV case, you could > >> have retained the Tested-by for the efforts which were already put in > >> instead of just blatantly removing it. > > > > I can add it back for v6 (or move sc7280 to the previous patch if you'd > > prefer that). Also I think the Tested-by should have included the > > #sc7280 comment. If you don't mind I'll add it. > > > > My tag had all the comments of what I tested and what I didnt. Not inline. Thus once patchwork picked your tag, all context (testing on sc7280) was lost. > >>>> Only for sc7280 device. > >>>> > >>>> I still cannot give my R-b on this change till others validate > >>>> visually and ensure things arent broken for them. > >>>> > >>>> If we don't get enough validation and if only sc7280 remains in this > >>>> change, please re-post it with only that and I will give my R-b too. > >>> > > -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D0FFC05027 for ; Tue, 14 Mar 2023 17:24:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E6C9510E1A8; Tue, 14 Mar 2023 17:24:01 +0000 (UTC) Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by gabe.freedesktop.org (Postfix) with ESMTPS id 36E7410E1A7 for ; Tue, 14 Mar 2023 17:23:59 +0000 (UTC) Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-5416949b35aso192394907b3.13 for ; Tue, 14 Mar 2023 10:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678814638; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lt10PpjJqJ0ufR48VoDC3ODoiczICej7BJnkuMGHSgc=; b=ryQ7QPJ+wJlpme5yL66l69YKETUMSLRgwglWdhdg/VBuOpRMhjftw/GlzFm1o56Mdk p0CyUkiO0LVWTWgC41tyDENP1SZ9a5DQg7872SBj/PLwGOyO2K+G0QNZqCw7s9JLikrn Ol84oIBl9ODaE3vOWGOikJiCXTaJsecvSh7TkuCc6yF9VDR3LF7PyTMhAJQJ7GSM6r+U zfRxPqz21rdn6ev+qv2SA5DEPKNyjKkQfSOkhKytaK03ANfll5oigoa69gwGOuJb37xJ a85B4oe0rBAQCShTZLUqHmugZqMbD0TBwBIDKNEvOmaxauTCg8UKlUpr1yw79O28qjZ2 DG0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678814638; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lt10PpjJqJ0ufR48VoDC3ODoiczICej7BJnkuMGHSgc=; b=w8x45lDNPbkV5PlVTQmlEqIBmShddsT0VS1yiU+U4G7i8MqX2Hhl33a5k+FRmHQyZB 1eRxCIdkdolaO+yLbEARQZ3A68qXNcwbarCx8EXxOHUCrWbGk0UR8KTXFbZF3mNr2nyy 0qOuR9bIrT8NYy1VavP8H4Q9tS7jeGmsW22RV5bhNKZpgRH49YLZmDLElO4CVuwvVgl6 l6uEELsaxHbWfVZxgSBq9mgLP/8t2nRD2voASykZY0lZe7eVLUg8Qsdib46D2hBNSQ80 0B1VOf4jK61RQ+X7sVbvqiYnsJ9tPw853PtzHhaNn0wZoJjL70nLX8MqgB7INtOwY8BB 5BGw== X-Gm-Message-State: AO0yUKUcE1eXd/8+lQKYoChjLjBNof7H0WruxomifFiYIK/5bDHxm61C 1pKnlZtbAff0YM98Vhyjt/lAeb1qc5Yy8d11IkSw5svEm5L8uE+n X-Google-Smtp-Source: AK7set/IVbS0h4lS3Qc/jrY6f7sA+AXwbSCVnwoBSQHoGQhRyWFxQHBZiyuSn6NtRJnVPnSx62nNhixXCyy5Pr5fluo= X-Received: by 2002:a81:ae5d:0:b0:541:85d2:af21 with SMTP id g29-20020a81ae5d000000b0054185d2af21mr7173793ywk.5.1678814638243; Tue, 14 Mar 2023 10:23:58 -0700 (PDT) MIME-Version: 1.0 References: <20230310005704.1332368-1-dmitry.baryshkov@linaro.org> <20230310005704.1332368-30-dmitry.baryshkov@linaro.org> <6a570e7d-f67e-a95d-4e15-db78a8b4a29d@quicinc.com> <7e2cfd1b-d1a1-acd1-91fd-1abbd1a86a1b@linaro.org> <840a4f3f-09df-f0a1-6ee6-488775739a74@quicinc.com> In-Reply-To: <840a4f3f-09df-f0a1-6ee6-488775739a74@quicinc.com> From: Dmitry Baryshkov Date: Tue, 14 Mar 2023 19:23:47 +0200 Message-ID: Subject: Re: [PATCH v5 29/32] drm/msm/dpu: enable SmartDMA for the rest of the platforms To: Abhinav Kumar Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Sean Paul , Bjorn Andersson , dri-devel@lists.freedesktop.org, Stephen Boyd , linux-arm-msm@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 14 Mar 2023 at 18:48, Abhinav Kumar wrote: > > > > On 3/14/2023 9:43 AM, Dmitry Baryshkov wrote: > > On 14/03/2023 18:35, Abhinav Kumar wrote: > >> > >> > >> On 3/14/2023 3:58 AM, Dmitry Baryshkov wrote: > >>> On 14/03/2023 07:08, Abhinav Kumar wrote: > >>>> > >>>> > >>>> On 3/9/2023 4:57 PM, Dmitry Baryshkov wrote: > >>>>> Enable SmartDMA features for the rest of the platforms where it is > >>>>> supposed to work. > >>>>> > >>>>> Signed-off-by: Dmitry Baryshkov > >>>> > >>>> I am so glad we split this. Without visual validation check we > >>>> wouldnt have caught the issues and would have ended up with a blank > >>>> half screen on our sc7280 CBs on DP. > >>> > >>> yes, the r_pipe was indeed mea culpa, when I didn't fully validate > >>> the results of a rebase. However this doesn't seem to be an > >>> sc7280-specific question. Are there any platform-specific issues with > >>> SmartDMA/multirect/planes revealed during testing? In other words, > >>> were there any issues which warrant this split? > >>> > > Missed this question. > > Well the sc7280 issue was itself coming from a platform specific > maxlinewidth. So like I wrote there, my monitor supported 2560x1600 and > the maxlinewidth for sc7280 is 2400. Thats why I could catch this. > > With RB5 or other platforms in the previous patch, this would not have > been caught without forcing some conditions. > > >>>> > >>>> For sc7280, I validated the foll cases: > >>> > >>> Thanks a lot! > >>> > >>>> > >>>> 1) Basic Chrome UI comes up > >>>> 2) Validated some browser use-cases and played some youtube videos > >>>> 3) Validated multiple plug-in/plug-out cases with DP connected > >>>> 4) IGT test cases with DP connected: > >>>> - kms_atomic > >>>> - kms_atomic_transition > >>>> - kms_pipe_basic_crc > >>>> > >>>> Some notes: > >>>> > >>>> 1) I wanted to test 4k with this too but my monitor only supports > >>>> 4k@60 which is not possible with 24bpp with 2 lanes and due to the > >>>> HBR3 black screen issue I could not test that so far. But since I > >>>> have that issue even with 1080P and without these changes, it should > >>>> have no effect due to this series. > >>>> > >>>> 2) I wanted to test some YUV overlay cases but I still cannot find > >>>> one on chrome. Its always using RGB. Will check with others. > >>> > >>> Testing YUV would definitely be a must, especially for the SSPP > >>> allocation. Can you possibly check whether contemporaty Xv > >>> implementation employs YUV planes? You can try that using `mpv -xo > >>> xv` or `mplayer -vo xv` > >>> > >> > >> Let me get some feedback from CrOS folks here instead of just trial > >> and error to find out. > >> > >>>> > >>>> With these two noted, this change and this series has my > >>>> > >>>> Tested-by: Abhinav Kumar > >>>> > >> > >> There is no guarantee we will end up finding the YUV case, you could > >> have retained the Tested-by for the efforts which were already put in > >> instead of just blatantly removing it. > > > > I can add it back for v6 (or move sc7280 to the previous patch if you'd > > prefer that). Also I think the Tested-by should have included the > > #sc7280 comment. If you don't mind I'll add it. > > > > My tag had all the comments of what I tested and what I didnt. Not inline. Thus once patchwork picked your tag, all context (testing on sc7280) was lost. > >>>> Only for sc7280 device. > >>>> > >>>> I still cannot give my R-b on this change till others validate > >>>> visually and ensure things arent broken for them. > >>>> > >>>> If we don't get enough validation and if only sc7280 remains in this > >>>> change, please re-post it with only that and I will give my R-b too. > >>> > > -- With best wishes Dmitry