From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CC5BC433F5 for ; Mon, 28 Mar 2022 16:44:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D775110E736; Mon, 28 Mar 2022 16:44:08 +0000 (UTC) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B3E010E736 for ; Mon, 28 Mar 2022 16:44:07 +0000 (UTC) Received: by mail-qv1-xf2c.google.com with SMTP id gh15so12264386qvb.8 for ; Mon, 28 Mar 2022 09:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZFIdehZrTxdj/RvUPXGwNiJz0CBRPSutTAor/H+cLso=; b=HY7BqZqay1vHlPzQoQMjzcnyQyiXyRjGp+TAREShAf3pydiqV7DKYRaYQoqT77XomN 95E7RQUXQwKi69JGzrCjskWWNF3VvTACp2QapXR/gcLtFij4dmvrqC42wjHDRht+Dxwb qrIJkT4BC1sa/5QqCEZkCH+19SGG/vuhKj0p/2nrtMZgOoINM+J0EN7chOuZyCcc4kGp BLWLjETKDhQZZGTerzv3Gytz8FVyy1LGew3BsoJfUBA122woOjL/N4+SDb/dJnBMc26y 6gtJ4loim8gQik4TgrcYztnMPkWzZvgrTAlLASvqNfzpk87vgb//cv2hRAzehoBw8tDz 8ISA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZFIdehZrTxdj/RvUPXGwNiJz0CBRPSutTAor/H+cLso=; b=NA2AsufMc20mEBVHxD2CFAJUQLrgme4shMsM7IcGLoXS2ixphu5IytWYKqj3t5sc3U WJBpLvek+e64YSiCULrvdM4+uV56t50P08nQAiNM3bcOzFTem+AO9/2RacquU9dxsl6c 18FJ43CjSwyabNHWQPPn7b+8G+YCoGJ6E6E1mTOrdyw0mSLuwSN5ozL20qSragKoBP9Z F0sNigAq6KVotOrhxct9EEbK9ZLQlEEXrB4RDpzYb1ZIqLKdbisfYeVIPospfHjQqDWA 3UAh2VxCtFxXjLrW2PTsmCFP24cqvpnLSpS1nlfJiPSe117zths0fBqwk7s+DIDvKXOc eHKA== X-Gm-Message-State: AOAM531BJEINWeVJWhl/WuiA3deEL4nz3GENHSw6gvx2zfjlwxmDZXjc nriWN+vW6Dd58opyEqcegLJnc17O3m1JyOd8gg8pVg== X-Google-Smtp-Source: ABdhPJzliM5etgMj0wPTZaXVmyqbng42nS8uHRrcWTfKZ4sLgNctWWdu5gzWqP4wan4eEECcgE1dx/vzA6PVuddrJ4s= X-Received: by 2002:a0c:b2cb:0:b0:435:cb61:322e with SMTP id d11-20020a0cb2cb000000b00435cb61322emr21682847qvf.122.1648485844212; Mon, 28 Mar 2022 09:44:04 -0700 (PDT) MIME-Version: 1.0 References: <20220328152923.90623-1-krzysztof.kozlowski@linaro.org> In-Reply-To: <20220328152923.90623-1-krzysztof.kozlowski@linaro.org> From: Dmitry Baryshkov Date: Mon, 28 Mar 2022 19:43:53 +0300 Message-ID: Subject: Re: [PATCH] dt-bindings: display: msm: dsi: remove address/size cells To: Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krishna Manikandan , devicetree@vger.kernel.org, David Airlie , linux-arm-msm@vger.kernel.org, Abhinav Kumar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Herring , Vinod Koul , Krzysztof Kozlowski , freedreno@lists.freedesktop.org, Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 28 Mar 2022 at 18:30, Krzysztof Kozlowski wrote: > > The DSI node is not a bus and the children do not have unit addresses. > > Reported-by: Vinod Koul > Signed-off-by: Krzysztof Kozlowski NAK. DSI panels are children of the DSI device tree node with the reg = <0>; address. This is the convention used by other platforms too (see e.g. arch/arm64/boot/dts/freescale/imx8mq-evk.dts). With the DSI split link it is possible to attach two panels to a single DSI host, so addresses are necessary. > --- > .../bindings/display/msm/dsi-controller-main.yaml | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > index 7095ec3c890d..57f238f72326 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > @@ -51,10 +51,6 @@ properties: > phy-names: > const: dsi > > - "#address-cells": true > - > - "#size-cells": true > - > syscon-sfpb: > description: A phandle to mmss_sfpb syscon node (only for DSIv2). > $ref: "/schemas/types.yaml#/definitions/phandle" > @@ -154,9 +150,6 @@ examples: > reg = <0x0ae94000 0x400>; > reg-names = "dsi_ctrl"; > > - #address-cells = <1>; > - #size-cells = <0>; > - > interrupt-parent = <&mdss>; > interrupts = <4>; > > -- > 2.32.0 > -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C046FC433EF for ; Mon, 28 Mar 2022 16:44:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242149AbiC1Qpr (ORCPT ); Mon, 28 Mar 2022 12:45:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237488AbiC1Qpr (ORCPT ); Mon, 28 Mar 2022 12:45:47 -0400 Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 198EF205CB for ; Mon, 28 Mar 2022 09:44:05 -0700 (PDT) Received: by mail-qv1-xf2c.google.com with SMTP id kd21so9361577qvb.6 for ; Mon, 28 Mar 2022 09:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZFIdehZrTxdj/RvUPXGwNiJz0CBRPSutTAor/H+cLso=; b=HY7BqZqay1vHlPzQoQMjzcnyQyiXyRjGp+TAREShAf3pydiqV7DKYRaYQoqT77XomN 95E7RQUXQwKi69JGzrCjskWWNF3VvTACp2QapXR/gcLtFij4dmvrqC42wjHDRht+Dxwb qrIJkT4BC1sa/5QqCEZkCH+19SGG/vuhKj0p/2nrtMZgOoINM+J0EN7chOuZyCcc4kGp BLWLjETKDhQZZGTerzv3Gytz8FVyy1LGew3BsoJfUBA122woOjL/N4+SDb/dJnBMc26y 6gtJ4loim8gQik4TgrcYztnMPkWzZvgrTAlLASvqNfzpk87vgb//cv2hRAzehoBw8tDz 8ISA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZFIdehZrTxdj/RvUPXGwNiJz0CBRPSutTAor/H+cLso=; b=WnoReoln4ObGzdPNr/sqFcEjqrsZdq6kkc0hPlSwStXCtftJpVrOA7eSkJ8E5FcOUR tX0sKrMG399kJ7YlzmJ3vJi4hoszi5QZhzusam/ThX6A9/XkAhYpkI/3TK7bDeeSPao5 CDxBbTYiLBzLUo2ka9SL0LGjxYLt2Q9ZvGd/jZ4ITm95LCp0hPMgC3xtF5qlMhYriKC8 SoE0toMMyNCQRZ+tZdfWm5jrZr0nji6tC8Wpyjr7846prjyLc0Y/RboMKtJNC46ETDZ0 kxldzTgY0tAfWtowt3UxQaTRDHSaipjn8ZjXIFfGzAZikjdLPiaFiNkH/TtDJqrXcbuy NTXA== X-Gm-Message-State: AOAM532mBJB0/8HhifzElIn8FYA9cMt+e+dj8jgzMvm8Hc+O1t5crSjz O6TVMBwRV6erq15JKnWs83UfkV8S6JSjb9j0fyqe7Q== X-Google-Smtp-Source: ABdhPJzliM5etgMj0wPTZaXVmyqbng42nS8uHRrcWTfKZ4sLgNctWWdu5gzWqP4wan4eEECcgE1dx/vzA6PVuddrJ4s= X-Received: by 2002:a0c:b2cb:0:b0:435:cb61:322e with SMTP id d11-20020a0cb2cb000000b00435cb61322emr21682847qvf.122.1648485844212; Mon, 28 Mar 2022 09:44:04 -0700 (PDT) MIME-Version: 1.0 References: <20220328152923.90623-1-krzysztof.kozlowski@linaro.org> In-Reply-To: <20220328152923.90623-1-krzysztof.kozlowski@linaro.org> From: Dmitry Baryshkov Date: Mon, 28 Mar 2022 19:43:53 +0300 Message-ID: Subject: Re: [PATCH] dt-bindings: display: msm: dsi: remove address/size cells To: Krzysztof Kozlowski Cc: Rob Clark , Sean Paul , Abhinav Kumar , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Krishna Manikandan , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vinod Koul Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, 28 Mar 2022 at 18:30, Krzysztof Kozlowski wrote: > > The DSI node is not a bus and the children do not have unit addresses. > > Reported-by: Vinod Koul > Signed-off-by: Krzysztof Kozlowski NAK. DSI panels are children of the DSI device tree node with the reg = <0>; address. This is the convention used by other platforms too (see e.g. arch/arm64/boot/dts/freescale/imx8mq-evk.dts). With the DSI split link it is possible to attach two panels to a single DSI host, so addresses are necessary. > --- > .../bindings/display/msm/dsi-controller-main.yaml | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > index 7095ec3c890d..57f238f72326 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > @@ -51,10 +51,6 @@ properties: > phy-names: > const: dsi > > - "#address-cells": true > - > - "#size-cells": true > - > syscon-sfpb: > description: A phandle to mmss_sfpb syscon node (only for DSIv2). > $ref: "/schemas/types.yaml#/definitions/phandle" > @@ -154,9 +150,6 @@ examples: > reg = <0x0ae94000 0x400>; > reg-names = "dsi_ctrl"; > > - #address-cells = <1>; > - #size-cells = <0>; > - > interrupt-parent = <&mdss>; > interrupts = <4>; > > -- > 2.32.0 > -- With best wishes Dmitry