From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27A31C433EF for ; Wed, 6 Jul 2022 08:29:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232427AbiGFI3A (ORCPT ); Wed, 6 Jul 2022 04:29:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232400AbiGFI2p (ORCPT ); Wed, 6 Jul 2022 04:28:45 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88BE124964 for ; Wed, 6 Jul 2022 01:27:46 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id c137so10527218qkg.5 for ; Wed, 06 Jul 2022 01:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ga7nDnbfUpJ9V6ACUSstOgYZyMVy4dse7zJQzHBX+go=; b=XfFD9/MZI+n41MLBK0E9mJU/XfUSFToIxhHGHSeXX5RSI/HMC32byDNxQ3J8hIknCZ H1YnXYCpyIF3P6+gRcN12sqyL3OrrdgJnHfVFxdBh9A+Fzqh5DsB+jTuO0Kw6oA0fE5k axQXuBptSouPb/ZM8WNzbbnwqwyMb/eHYjuzTCgwAfiAYRez+zIcV41H36FtK0q57/Hb fc7EpvpnjHDme0fS5lPpxHSOFzwBYfK2Y5WX+t1XRpgrRfhw+jx8ZonW5P4JfHQ4TdXh V2lTIgPSLo52tfTCeUtldlg3qV1M4q/4jBkuN275HUv7/2cJ9TA/4BzJ3azwDDq6fmMy vRLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ga7nDnbfUpJ9V6ACUSstOgYZyMVy4dse7zJQzHBX+go=; b=O8pYAF2oMappKBfaZMXfwtPbd60U/TbizQ/NQMCR58Oap1TzZ5Z1Gq5C7P1KEXXfaP y/msD8DAfiQ7XeIN3Q9CwbmNQMh+8CXrxGCOqLfu5Mc7LNhkq1XecsWhxFHnYB5DVAPq hl+c7/1n/RYJ5AXaQc1Nc3ClAE+4JvhGkJqJCpwy6KlIlfV+AemnjVjT45Z3ahiul7AL D9ZOAcdb0GA26GBYGygcCqFL9L+usNx8UHt6oouYUucu9THEMtsLwmJ6hlSYBbxnf3bn LMEf6h1ogliftlveUvit7mWaQp+9LPk8qxxG8YsxdjzmiV7USbtJ7ZkuPOhKTL4czkIp EmfQ== X-Gm-Message-State: AJIora/kje+PHqsNQ6SBqWUC6+j+ulBkIi00hMKVdfg9g3JREAf1A80Q ElLBSRk0tloa3U4x/rEuxQtgJejkp8LOGyFC3WAvqg== X-Google-Smtp-Source: AGRyM1s0dNFUwGjzYQrSacrH+zKZnt3/yN8zb4JMapiqP581z2KtzHaeLpWvpk2in8PzwyIpExyFMQFqXwJMGqb8DEQ= X-Received: by 2002:a05:620a:2409:b0:6b1:4464:e401 with SMTP id d9-20020a05620a240900b006b14464e401mr26122750qkn.30.1657096065684; Wed, 06 Jul 2022 01:27:45 -0700 (PDT) MIME-Version: 1.0 References: <20220705202837.667-1-ansuelsmth@gmail.com> <20220705202837.667-4-ansuelsmth@gmail.com> In-Reply-To: <20220705202837.667-4-ansuelsmth@gmail.com> From: Dmitry Baryshkov Date: Wed, 6 Jul 2022 11:27:34 +0300 Message-ID: Subject: Re: [PATCH 3/5] clk: qcom: clk-rpm: convert to parent_data API To: Christian Marangi Cc: Bjorn Andersson , Andy Gross , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, 5 Jul 2022 at 23:56, Christian Marangi wrote: > > Convert clk-rpm driver to parent_data API and change parent names to cxo > and pxo instead of the board variant as pxo_board is an ancient name and > pxo should be used instead. > > Signed-off-by: Christian Marangi > --- > drivers/clk/qcom/clk-rpm.c | 24 ++++++++++++++++-------- > 1 file changed, 16 insertions(+), 8 deletions(-) > > diff --git a/drivers/clk/qcom/clk-rpm.c b/drivers/clk/qcom/clk-rpm.c > index a18811c38018..d45a8b0fc97c 100644 > --- a/drivers/clk/qcom/clk-rpm.c > +++ b/drivers/clk/qcom/clk-rpm.c > @@ -23,6 +23,14 @@ > #define QCOM_RPM_SCALING_ENABLE_ID 0x2 > #define QCOM_RPM_XO_MODE_ON 0x2 > > +static const struct clk_parent_data gcc_pxo[] = { > + { .fw_name = "pxo", .name = "pxo" }, This means that the core clock would look for the DT clock named 'pxo' with the fallback to the global clock named 'pxo'. Fallback is required to keep compatibility with older DT files, not having the clocks/clock-names properties. For all other platforms we were using as a fallback the 'pxo_board' clock (defined in the DT) rather than the 'pxo' (hackily injected by the gcc driver). I'd suggest following this pattern and using .fw_name = "pxo', .name = "pxo_board". Same applies to the CXO clock. > +}; > + -- With best wishes Dmitry