From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932759AbbLBPz4 (ORCPT ); Wed, 2 Dec 2015 10:55:56 -0500 Received: from mail-io0-f170.google.com ([209.85.223.170]:35828 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753300AbbLBPzy (ORCPT ); Wed, 2 Dec 2015 10:55:54 -0500 MIME-Version: 1.0 In-Reply-To: <20151202154514.GA31371@kroah.com> References: <1446812190-8833-1-git-send-email-saurabh.truth@gmail.com> <20151201223506.GA27400@kroah.com> <20151202154514.GA31371@kroah.com> Date: Wed, 2 Dec 2015 21:25:53 +0530 Message-ID: Subject: Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap From: Saurabh Sengar To: Greg KH Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, I am little unclear. Now, shall I resend my patch on top of usb.git tree or linux.git tree. Regards, Saurabh On 2 December 2015 at 21:15, Greg KH wrote: > On Wed, Dec 02, 2015 at 09:08:06AM +0530, Saurabh Sengar wrote: >> On 2 December 2015 at 04:05, Greg KH wrote: >> > On Fri, Nov 06, 2015 at 05:46:30PM +0530, Saurabh Sengar wrote: >> >> added iounmap inorder to free memory mapped to base before returning >> >> >> >> Signed-off-by: Saurabh Sengar >> >> --- >> >> drivers/usb/host/pci-quirks.c | 4 ++-- >> >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> >> >> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c >> >> index f940056..332f687 100644 >> >> --- a/drivers/usb/host/pci-quirks.c >> >> +++ b/drivers/usb/host/pci-quirks.c >> >> @@ -990,7 +990,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev) >> >> /* We're reading garbage from the controller */ >> >> dev_warn(&pdev->dev, >> >> "xHCI controller failing to respond"); >> >> - return; >> >> + goto iounmap; >> >> } >> >> >> >> if (!ext_cap_offset) >> >> @@ -1061,7 +1061,7 @@ hc_init: >> >> "xHCI HW did not halt within %d usec status = 0x%x\n", >> >> XHCI_MAX_HALT_USEC, val); >> >> } >> >> - >> >> +iounmap: >> >> iounmap(base); >> >> } >> >> >> > >> > Does not apply to the tree :( >> >> >> This patch applies fine on top of >> "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git". >> Just now only I have re-verified. >> Am I expected to send this patch on top of some other git tree/branch ? > > It will end up going in the usb.git tree, on the usb-next branch, and it > conflicts with other xhci patches that just landed there ahead of yours. > So it's not your fault, you did the right thing, just others also did > work here so you need to redo yours as well, a normal thing in kernel > development :) > > hope this helps explain things. > > thanks, > > greg k-h