From: Saurabh Sengar <saurabh.truth@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap
Date: Wed, 2 Dec 2015 09:08:06 +0530 [thread overview]
Message-ID: <CAA8avJ8Cs6sz_BS+crsZKi9w4xkE6Ns4Aq8HUOU9mbw=GXZjvw@mail.gmail.com> (raw)
In-Reply-To: <20151201223506.GA27400@kroah.com>
On 2 December 2015 at 04:05, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Nov 06, 2015 at 05:46:30PM +0530, Saurabh Sengar wrote:
>> added iounmap inorder to free memory mapped to base before returning
>>
>> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
>> ---
>> drivers/usb/host/pci-quirks.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
>> index f940056..332f687 100644
>> --- a/drivers/usb/host/pci-quirks.c
>> +++ b/drivers/usb/host/pci-quirks.c
>> @@ -990,7 +990,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
>> /* We're reading garbage from the controller */
>> dev_warn(&pdev->dev,
>> "xHCI controller failing to respond");
>> - return;
>> + goto iounmap;
>> }
>>
>> if (!ext_cap_offset)
>> @@ -1061,7 +1061,7 @@ hc_init:
>> "xHCI HW did not halt within %d usec status = 0x%x\n",
>> XHCI_MAX_HALT_USEC, val);
>> }
>> -
>> +iounmap:
>> iounmap(base);
>> }
>>
>
> Does not apply to the tree :(
This patch applies fine on top of
"git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git".
Just now only I have re-verified.
Am I expected to send this patch on top of some other git tree/branch ?
next prev parent reply other threads:[~2015-12-02 3:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 12:16 [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap Saurabh Sengar
2015-11-30 6:28 ` Saurabh Sengar
2015-11-30 9:05 ` Mathias Nyman
2015-12-01 22:35 ` Greg KH
2015-12-02 3:38 ` Saurabh Sengar [this message]
2015-12-02 15:45 ` Greg KH
2015-12-02 15:55 ` Saurabh Sengar
2015-12-02 16:29 ` Greg KH
2015-12-02 17:21 ` [PATCH v2] " Saurabh Sengar
2015-12-04 16:23 ` Greg KH
2015-12-04 16:31 ` Saurabh Sengar
2015-12-04 16:39 ` [PATCH v3] " Saurabh Sengar
2016-02-11 9:42 [PATCH] " Saurabh Sengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA8avJ8Cs6sz_BS+crsZKi9w4xkE6Ns4Aq8HUOU9mbw=GXZjvw@mail.gmail.com' \
--to=saurabh.truth@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.