From: Andrei Borzenkov <arvidjaar@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH 3/3] ieee1275: ofdisk - don't continue to query block-size after we have it
Date: Tue, 10 Nov 2015 11:01:12 +0300 [thread overview]
Message-ID: <CAA91j0UdUgM+hZuKqu_4s7tGTrVx5cLwVqq7gVcNgzP8+efezg@mail.gmail.com> (raw)
In-Reply-To: <562EA2D8.90401@gmail.com>
On Tue, Oct 27, 2015 at 1:02 AM, Vladimir 'φ-coder/phcoder' Serbinenko
<phcoder@gmail.com> wrote:
> On 26.10.2015 22:43, Eric Snowberg wrote:
>> Within commit: 87ec3b7fa9061f470616ed927fc140e995831c00 - "Don't continue
>> to query block-size if disk doesn't have it.” Disks that returned 0 to the
>> block-size query, still get queried every time.
>>
>> Fix logic in grub_ofdisk_get_block_size so the block size is not requested
>> upon each open since it will not change.
>>
> Is it true for removable disks as well? What about someone unplugging
> USB stick and plugging-in 4K USB HDD?
Does OBP alone have hotplug support until OS is running?
next prev parent reply other threads:[~2015-11-10 8:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 21:43 [PATCH 1/3] ieee1275: ofdisk dangling pointer Eric Snowberg
2015-10-26 21:43 ` [PATCH 2/3] ieee1275: ofdisk memory leak Eric Snowberg
2015-10-26 22:03 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-10-26 21:43 ` [PATCH 3/3] ieee1275: ofdisk - don't continue to query block-size after we have it Eric Snowberg
2015-10-26 22:02 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-11-10 8:01 ` Andrei Borzenkov [this message]
2015-11-10 17:45 ` Eric Snowberg
2015-10-26 22:03 ` [PATCH 1/3] ieee1275: ofdisk dangling pointer Vladimir 'φ-coder/phcoder' Serbinenko
2015-10-29 14:48 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA91j0UdUgM+hZuKqu_4s7tGTrVx5cLwVqq7gVcNgzP8+efezg@mail.gmail.com \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.