From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1a471q-0003a0-SN
	for mharc-grub-devel@gnu.org; Wed, 02 Dec 2015 08:01:02 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57008)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arvidjaar@gmail.com>) id 1a471n-0003YM-V7
	for grub-devel@gnu.org; Wed, 02 Dec 2015 08:01:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arvidjaar@gmail.com>) id 1a471n-00053O-2P
	for grub-devel@gnu.org; Wed, 02 Dec 2015 08:00:59 -0500
Received: from mail-oi0-x230.google.com ([2607:f8b0:4003:c06::230]:36176)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arvidjaar@gmail.com>) id 1a471m-00053A-Sm
	for grub-devel@gnu.org; Wed, 02 Dec 2015 08:00:58 -0500
Received: by oiww189 with SMTP id w189so23836868oiw.3
	for <grub-devel@gnu.org>; Wed, 02 Dec 2015 05:00:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:content-type; bh=pCrZcEEhWXBtW+QQxNxsf/3xNOZxWDvfha+NVCvr2R4=;
	b=sbih5bPxXRrVv7RKCdoTXd2xeM9OLgtWWQaqNDRND3ZNUK0YrldXrMtgX0QWRx4KM2
	5VUTqMsjLmMUbWa9iJVOjbM4kt7sEmAXr0fkY0/DV4EJSkBV/t/ikn6r+R88Vi+ac2S1
	chg7B1h9AtVyitI4NrkDitF72DWNRwwb6OcLUpFQUHAtG0ISlDN6HQb2LpQMEon8er5M
	mULSh4IwVC245JML4ljFxizyZYlrEMtcIlNJeKL6q0gM5Elj1FnM6sG472GBYdJMvvS6
	1WQbP4tEnb3X1FSkIm2hxB8ZScQtwP+AXGIpTCiV2NlZH570ojfGWmHMjCy4wbobLNLt
	dbtw==
MIME-Version: 1.0
X-Received: by 10.202.192.87 with SMTP id q84mr2355863oif.59.1449061258079;
	Wed, 02 Dec 2015 05:00:58 -0800 (PST)
Received: by 10.202.102.151 with HTTP; Wed, 2 Dec 2015 05:00:57 -0800 (PST)
In-Reply-To: <CALrw=nFBWQvSUmKXSLV5HSqtu1xQmbxsZgBk+mYXTgzVQk4aMA@mail.gmail.com>
References: <CAA0a8nXjwS-uRZnTsVL4_-k_N=_USkJ+_19SJrv8Wic6HdmWvg@mail.gmail.com>
	<CAKCeAn8DGnLv41=06=mQ7kA0wp=E7_nRWKq9TK7Hf16PB4M_iA@mail.gmail.com>
	<CAA0a8nUtS1TQBPpY2qaRfz3KmrwSFWZJDCWBCu9rAXn424E4oQ@mail.gmail.com>
	<563999B9.7020108@gmail.com>
	<CAKCeAn-6deosYohUDGnwR6JimC7YWhOzFJi=ovyJ=14GJn2QeA@mail.gmail.com>
	<CALrw=nFgzf9Ymbrm2S7LHy2R_2h+xP2X8pibc9CjGZ=VSnd+fw@mail.gmail.com>
	<5643845E.9060204@gmail.com>
	<CALrw=nHa3ZHLeeNd0FzYRAqFDLgD8_R0GQsspTnB-CFHjdDNMQ@mail.gmail.com>
	<CALrw=nE39PP7D1N-E=FceMdKy7K7Z=kfgG2Trcfjg-CQw6DP5A@mail.gmail.com>
	<5646B275.5040707@gmail.com> <56586384.1030504@gmail.com>
	<CALrw=nF5-e62xHQq7NByUUNsPi7iv4EqYc=qUF4VCf=4NJd8nw@mail.gmail.com>
	<565ABE97.5060109@gmail.com>
	<CALrw=nFBWQvSUmKXSLV5HSqtu1xQmbxsZgBk+mYXTgzVQk4aMA@mail.gmail.com>
Date: Wed, 2 Dec 2015 16:00:57 +0300
Message-ID: <CAA91j0X8f5pcMwha3OmW4ca9gMY53PcuT7szHr088Jt2QKW_0A@mail.gmail.com>
Subject: Re: Grub get and set efi variables
From: Andrei Borzenkov <arvidjaar@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Content-Type: text/plain; charset=UTF-8
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2607:f8b0:4003:c06::230
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Dec 2015 13:01:00 -0000

On Wed, Dec 2, 2015 at 3:53 PM, Ignat Korchagin <ignat@cloudflare.com> wrote:
> Let's add utf16 later then (if needed). I also noticed a typo in one
> error string in my above patch (it was checking that command receives
> one argument, but prints that two arguments expected), so here is the
> updated one.
>

It is much more difficult to remove anything than to add it later.
Unless we have use case right now, I'd skip it.

> So, finally, should I remove the "raw" parser (as per Vladimir's
> request). Personally, I would keep it. It might be useful to modify
> the hexdump command, that it can dump the contents of a variable. Then
> those pieces will fit together: storing raw value in the variable and
> examining it with hexdump cmd.
>

hexdump does not support showing variable if that is what you mean. By
the same logic, unless we have current use case we probably should not
add it initially.