From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932121AbbKMJBa (ORCPT ); Fri, 13 Nov 2015 04:01:30 -0500 Received: from mail-qk0-f195.google.com ([209.85.220.195]:34794 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753676AbbKMJB3 (ORCPT ); Fri, 13 Nov 2015 04:01:29 -0500 MIME-Version: 1.0 In-Reply-To: References: <1447111090-8526-1-git-send-email-kirill.shutemov@linux.intel.com> <20151110123429.GE19187@pd.tnic> <20151110135303.GA11246@node.shutemov.name> <20151110144648.GG19187@pd.tnic> <20151110150713.GA11956@node.shutemov.name> <20151110170447.GH19187@pd.tnic> <20151111095101.GA22512@pd.tnic> <20151112074854.GA5376@gmail.com> <20151112075758.GA20702@node.shutemov.name> <20151112080059.GA6835@gmail.com> Date: Fri, 13 Nov 2015 01:01:28 -0800 Message-ID: Subject: Re: [PATCH] x86/mm: fix regression with huge pages on PAE From: Dan Williams To: Linus Torvalds Cc: Ingo Molnar , "Kirill A. Shutemov" , Borislav Petkov , "Kirill A. Shutemov" , Peter Anvin , Thomas Gleixner , Ingo Molnar , Andrew Morton , linux-mm , Linux Kernel Mailing List , "the arch/x86 maintainers" , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Konrad Rzeszutek Wilk , elliott@hpe.com, Boris Ostrovsky , Toshi Kani Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2015 at 11:29 AM, Linus Torvalds wrote: > On Thu, Nov 12, 2015 at 12:00 AM, Ingo Molnar wrote: [..] > I have this dim memory of us playing around with just making PAGE_SIZE > (and thus PAGE_MASK) always be signed, but that it caused other > problems. Signed types have downsides too. FWIW, I ran into this recently with the pfn_t patch. mips and powerpc have PAGE_MASK as a signed int. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f176.google.com (mail-qk0-f176.google.com [209.85.220.176]) by kanga.kvack.org (Postfix) with ESMTP id 013186B0038 for ; Fri, 13 Nov 2015 04:01:30 -0500 (EST) Received: by qkfo3 with SMTP id o3so40809335qkf.1 for ; Fri, 13 Nov 2015 01:01:29 -0800 (PST) Received: from mail-qk0-x242.google.com (mail-qk0-x242.google.com. [2607:f8b0:400d:c09::242]) by mx.google.com with ESMTPS id 92si15091368qks.80.2015.11.13.01.01.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Nov 2015 01:01:29 -0800 (PST) Received: by qkas77 with SMTP id s77so4755977qka.2 for ; Fri, 13 Nov 2015 01:01:29 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1447111090-8526-1-git-send-email-kirill.shutemov@linux.intel.com> <20151110123429.GE19187@pd.tnic> <20151110135303.GA11246@node.shutemov.name> <20151110144648.GG19187@pd.tnic> <20151110150713.GA11956@node.shutemov.name> <20151110170447.GH19187@pd.tnic> <20151111095101.GA22512@pd.tnic> <20151112074854.GA5376@gmail.com> <20151112075758.GA20702@node.shutemov.name> <20151112080059.GA6835@gmail.com> Date: Fri, 13 Nov 2015 01:01:28 -0800 Message-ID: Subject: Re: [PATCH] x86/mm: fix regression with huge pages on PAE From: Dan Williams Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds Cc: Ingo Molnar , "Kirill A. Shutemov" , Borislav Petkov , "Kirill A. Shutemov" , Peter Anvin , Thomas Gleixner , Ingo Molnar , Andrew Morton , linux-mm , Linux Kernel Mailing List , the arch/x86 maintainers , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Konrad Rzeszutek Wilk , elliott@hpe.com, Boris Ostrovsky , Toshi Kani On Thu, Nov 12, 2015 at 11:29 AM, Linus Torvalds wrote: > On Thu, Nov 12, 2015 at 12:00 AM, Ingo Molnar wrote: [..] > I have this dim memory of us playing around with just making PAGE_SIZE > (and thus PAGE_MASK) always be signed, but that it caused other > problems. Signed types have downsides too. FWIW, I ran into this recently with the pfn_t patch. mips and powerpc have PAGE_MASK as a signed int. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org