From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECA6917F for ; Tue, 10 Aug 2021 22:24:40 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id nt11so315899pjb.2 for ; Tue, 10 Aug 2021 15:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QrhRnlztM32IaZrIGZ9Mi5bnSi+S4AFi7dtGVRZ3+oE=; b=lxGFxypI3awP4jFNDHn9zjYNhCggd/GIfQmD8Hl1CdGYU4MNCyFNk9r05maXP8F22G HdaczcdSjxSQu4pazGCUjomJ0bST5B9nWtVdqw1Bl4Qx5VxRvquT2As9HgOJsjD626xE R1L882FgllHUtXsys4b+sA0gL6I4YGZilh1cXW14V8QPLS0H+JG8J2nF/GTeE0cl0Ht9 oVad7U14wENl9sBb8SKKAes/kZKHoTxke6i3L+ornLWZ6wmD8NgUq5KrbDG68+aeyPhS 9+zwpkTfhK6stWLcqmKMdxCIMkHjsvYygE36Bds305cuWqccbqdYlBs7ExOVXEuh9WSK wzkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QrhRnlztM32IaZrIGZ9Mi5bnSi+S4AFi7dtGVRZ3+oE=; b=olVAWCfaDWR4PMgzK9KOWdDo1Q4WnenwdexKXjl+ZXni3djVk9yFvfDM0sb5MVnFlh lXeJXqDycUow3wJHY2PQ2C6+DPqPSmF/t75/8ZKCzWqOiKAsj/YYIj+t0emGXC2EjwLK /7NiU4ZkFK+Ow9VKLdDlaGrkTxC8LpxkgnEshVsDvD6jyZtupEuOdarc3+ytjrEw19p5 YpC6tBlIIvCbAWrEpxeH9+r/H50pScZjh59Abl+LSW5eggXk47tawtEcHFRZlG1TzWg+ 5w3wsM9BygqCmqFJ7r4Pf+pWI5VwSB0hwi6eaFlYs/D243SmyDo8yLzuViohfiGkfZeW 2I/A== X-Gm-Message-State: AOAM532EX34hx7mRiaO/+MinOWemHcc7sA61cm4ShH5jHc8wjgs9cQ6L 57N7bWAOV56nVNJDXz7T4RFfsHbw97HtC+x9N0v560K6nonJZAf/G8Q= X-Google-Smtp-Source: ABdhPJxYEaa4G0PKpfOtWkOuWJlc/+m01d8/a9mzzT44r+II16GS1SFt58hWCXe5dgu781qx1ubqndrSao0dUKuOrsw= X-Received: by 2002:a65:6a0a:: with SMTP id m10mr368854pgu.82.1628634280452; Tue, 10 Aug 2021 15:24:40 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210810074504.957-1-phil@philpotter.co.uk> In-Reply-To: From: Phillip Potter Date: Tue, 10 Aug 2021 23:24:29 +0100 Message-ID: Subject: Re: [PATCH] staging: r8188eu: remove rtw_ioctl function To: gregkh Cc: Arnd Bergmann , Larry Finger , linux-staging@lists.linux.dev, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" On Tue, 10 Aug 2021 at 11:23, gregkh wrote: > > On Tue, Aug 10, 2021 at 10:08:31AM +0200, Arnd Bergmann wrote: > > On Tue, Aug 10, 2021 at 9:45 AM Phillip Potter wrote: > > > -int rtw_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) > > > -{ > > > - struct iwreq *wrq = (struct iwreq *)rq; > > > - int ret = 0; > > > - > > > - switch (cmd) { > > > - case RTL_IOCTL_WPA_SUPPLICANT: > > > - ret = wpa_supplicant_ioctl(dev, &wrq->u.data); > > > - break; > > > -#ifdef CONFIG_88EU_AP_MODE > > > - case RTL_IOCTL_HOSTAPD: > > > - ret = rtw_hostapd_ioctl(dev, &wrq->u.data); > > > - break; > > > -#endif /* CONFIG_88EU_AP_MODE */ > > > - case SIOCDEVPRIVATE: > > > - ret = rtw_ioctl_wext_private(dev, &wrq->u); > > > - break; > > > > > > I think these functions are all defined 'static' in the same file, so > > removing the > > caller will cause a warning about an unused function. Better remove the > > called functions along with the caller. > > I get no build warnings/errors with this patch applied, which is odd. > > So I'll take this for now, but a follow-on patch to remove these unused > functions would be great to have. > > thanks, > > greg k-h Dear Greg, Many thanks, and of course, I shall prepare one now. Regards, Phil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01FBAC4338F for ; Tue, 10 Aug 2021 22:24:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4E9560EC0 for ; Tue, 10 Aug 2021 22:24:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234951AbhHJWZE (ORCPT ); Tue, 10 Aug 2021 18:25:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234444AbhHJWZD (ORCPT ); Tue, 10 Aug 2021 18:25:03 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D90BAC061765 for ; Tue, 10 Aug 2021 15:24:40 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id j3so23314733plx.4 for ; Tue, 10 Aug 2021 15:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QrhRnlztM32IaZrIGZ9Mi5bnSi+S4AFi7dtGVRZ3+oE=; b=lxGFxypI3awP4jFNDHn9zjYNhCggd/GIfQmD8Hl1CdGYU4MNCyFNk9r05maXP8F22G HdaczcdSjxSQu4pazGCUjomJ0bST5B9nWtVdqw1Bl4Qx5VxRvquT2As9HgOJsjD626xE R1L882FgllHUtXsys4b+sA0gL6I4YGZilh1cXW14V8QPLS0H+JG8J2nF/GTeE0cl0Ht9 oVad7U14wENl9sBb8SKKAes/kZKHoTxke6i3L+ornLWZ6wmD8NgUq5KrbDG68+aeyPhS 9+zwpkTfhK6stWLcqmKMdxCIMkHjsvYygE36Bds305cuWqccbqdYlBs7ExOVXEuh9WSK wzkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QrhRnlztM32IaZrIGZ9Mi5bnSi+S4AFi7dtGVRZ3+oE=; b=a1FTwI0k4QNoju3qz9ZdG+aa+T6fFIkUtPkeatcRCn+G5SFbyXs9TZaNhyzgNC8FEv V1N/6ST+lv4/ik8nCPJQMvWruuXiBFpPKsNu4CdKWX0K/cYc0KKbZU0z/F/Xk2JTg7g9 DOcE4RaXzeFZnipr7xxRU6Sdh3tu0U37kL/VuenOCibXaitZM21tMEePna9gnFKjnmoD 092mJ3cRkXK172M30V0JoRlr/v3YQSdPcXSeCR80t4/osXTARZmkrtQT0s00fGg+AFL7 ueRCCKEto+mnfrtyncWbpP5CaI0SjmOgIWNHFEZYNTYJuuTYu2oPZfINXFzGqFlIfh1c 5EYQ== X-Gm-Message-State: AOAM531mxCRVv0R6a+poO+FPwUjgJN4PaDArvwgDytJg32TzeGY+SIij o0Lxn2vBb05c+fpVjtqE5sGKtgF3fsXvo01EgV8E6A== X-Google-Smtp-Source: ABdhPJxYEaa4G0PKpfOtWkOuWJlc/+m01d8/a9mzzT44r+II16GS1SFt58hWCXe5dgu781qx1ubqndrSao0dUKuOrsw= X-Received: by 2002:a65:6a0a:: with SMTP id m10mr368854pgu.82.1628634280452; Tue, 10 Aug 2021 15:24:40 -0700 (PDT) MIME-Version: 1.0 References: <20210810074504.957-1-phil@philpotter.co.uk> In-Reply-To: From: Phillip Potter Date: Tue, 10 Aug 2021 23:24:29 +0100 Message-ID: Subject: Re: [PATCH] staging: r8188eu: remove rtw_ioctl function To: gregkh Cc: Arnd Bergmann , Larry Finger , linux-staging@lists.linux.dev, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Aug 2021 at 11:23, gregkh wrote: > > On Tue, Aug 10, 2021 at 10:08:31AM +0200, Arnd Bergmann wrote: > > On Tue, Aug 10, 2021 at 9:45 AM Phillip Potter wrote: > > > -int rtw_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) > > > -{ > > > - struct iwreq *wrq = (struct iwreq *)rq; > > > - int ret = 0; > > > - > > > - switch (cmd) { > > > - case RTL_IOCTL_WPA_SUPPLICANT: > > > - ret = wpa_supplicant_ioctl(dev, &wrq->u.data); > > > - break; > > > -#ifdef CONFIG_88EU_AP_MODE > > > - case RTL_IOCTL_HOSTAPD: > > > - ret = rtw_hostapd_ioctl(dev, &wrq->u.data); > > > - break; > > > -#endif /* CONFIG_88EU_AP_MODE */ > > > - case SIOCDEVPRIVATE: > > > - ret = rtw_ioctl_wext_private(dev, &wrq->u); > > > - break; > > > > > > I think these functions are all defined 'static' in the same file, so > > removing the > > caller will cause a warning about an unused function. Better remove the > > called functions along with the caller. > > I get no build warnings/errors with this patch applied, which is odd. > > So I'll take this for now, but a follow-on patch to remove these unused > functions would be great to have. > > thanks, > > greg k-h Dear Greg, Many thanks, and of course, I shall prepare one now. Regards, Phil