From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751731AbdJBUBS (ORCPT ); Mon, 2 Oct 2017 16:01:18 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:45086 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751120AbdJBUBQ (ORCPT ); Mon, 2 Oct 2017 16:01:16 -0400 X-Google-Smtp-Source: AOwi7QBWOgOimIr/lJAhGs+zBPBGIcBCkSVMGRuJhASjmOy+m7GA3IE3lh2bwvvPExJUBHx7vKciWV4W7EphUtPw2d4= MIME-Version: 1.0 In-Reply-To: <20171002195601.3jeocmmzyf2jl3dw@dhcp22.suse.cz> References: <20170927074319.o3k26kja43rfqmvb@dhcp22.suse.cz> <20170927162300.GA5623@castle.DHCP.thefacebook.com> <20171002122434.llbaarb6yw3o3mx3@dhcp22.suse.cz> <20171002192814.sad75tqklp3nmr4m@dhcp22.suse.cz> <20171002195601.3jeocmmzyf2jl3dw@dhcp22.suse.cz> From: Tim Hockin Date: Mon, 2 Oct 2017 13:00:54 -0700 X-Google-Sender-Auth: 0MrY3B8OxzJLB9rMpLRussfpFNw Message-ID: Subject: Re: [v8 0/4] cgroup-aware OOM killer To: Michal Hocko Cc: Shakeel Butt , Roman Gushchin , Johannes Weiner , Tejun Heo , kernel-team@fb.com, David Rientjes , Linux MM , Vladimir Davydov , Tetsuo Handa , Andrew Morton , Cgroups , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the example above: root / \ A D / \ B C Does oom_group allow me to express "compare A and D; if A is chosen compare B and C; kill the loser" ? As I understand the proposal (from reading thread, not patch) it does not. On Mon, Oct 2, 2017 at 12:56 PM, Michal Hocko wrote: > On Mon 02-10-17 12:45:18, Shakeel Butt wrote: >> > I am sorry to cut the rest of your proposal because it simply goes over >> > the scope of the proposed solution while the usecase you are mentioning >> > is still possible. If we want to compare intermediate nodes (which seems >> > to be the case) then we can always provide a knob to opt-in - be it your >> > oom_gang or others. >> >> In the Roman's proposed solution we can already force the comparison >> of intermediate nodes using 'oom_group', I am just requesting to >> separate the killall semantics from it. > > oom_group _is_ about killall semantic. And comparing killable entities > is just a natural thing to do. So I am not sure what you mean > > -- > Michal Hocko > SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f71.google.com (mail-oi0-f71.google.com [209.85.218.71]) by kanga.kvack.org (Postfix) with ESMTP id 5D9016B0069 for ; Mon, 2 Oct 2017 16:01:17 -0400 (EDT) Received: by mail-oi0-f71.google.com with SMTP id q133so4310352oic.3 for ; Mon, 02 Oct 2017 13:01:17 -0700 (PDT) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id e78sor2580460oih.179.2017.10.02.13.01.15 for (Google Transport Security); Mon, 02 Oct 2017 13:01:16 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20171002195601.3jeocmmzyf2jl3dw@dhcp22.suse.cz> References: <20170927074319.o3k26kja43rfqmvb@dhcp22.suse.cz> <20170927162300.GA5623@castle.DHCP.thefacebook.com> <20171002122434.llbaarb6yw3o3mx3@dhcp22.suse.cz> <20171002192814.sad75tqklp3nmr4m@dhcp22.suse.cz> <20171002195601.3jeocmmzyf2jl3dw@dhcp22.suse.cz> From: Tim Hockin Date: Mon, 2 Oct 2017 13:00:54 -0700 Message-ID: Subject: Re: [v8 0/4] cgroup-aware OOM killer Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Shakeel Butt , Roman Gushchin , Johannes Weiner , Tejun Heo , kernel-team@fb.com, David Rientjes , Linux MM , Vladimir Davydov , Tetsuo Handa , Andrew Morton , Cgroups , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" In the example above: root / \ A D / \ B C Does oom_group allow me to express "compare A and D; if A is chosen compare B and C; kill the loser" ? As I understand the proposal (from reading thread, not patch) it does not. On Mon, Oct 2, 2017 at 12:56 PM, Michal Hocko wrote: > On Mon 02-10-17 12:45:18, Shakeel Butt wrote: >> > I am sorry to cut the rest of your proposal because it simply goes over >> > the scope of the proposed solution while the usecase you are mentioning >> > is still possible. If we want to compare intermediate nodes (which seems >> > to be the case) then we can always provide a knob to opt-in - be it your >> > oom_gang or others. >> >> In the Roman's proposed solution we can already force the comparison >> of intermediate nodes using 'oom_group', I am just requesting to >> separate the killall semantics from it. > > oom_group _is_ about killall semantic. And comparing killable entities > is just a natural thing to do. So I am not sure what you mean > > -- > Michal Hocko > SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org