From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B051EC43331 for ; Thu, 26 Mar 2020 11:02:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8301920409 for ; Thu, 26 Mar 2020 11:02:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="BoPnx1be" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728111AbgCZLC5 (ORCPT ); Thu, 26 Mar 2020 07:02:57 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:33822 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727948AbgCZLC5 (ORCPT ); Thu, 26 Mar 2020 07:02:57 -0400 Received: by mail-lf1-f68.google.com with SMTP id e7so4435466lfq.1 for ; Thu, 26 Mar 2020 04:02:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ynpcR6n8vAPdutY7ywfm1ArJ7pQbC0NhZJIcycKZNpo=; b=BoPnx1beyl1c+JOCY9zAv6v8ZiWm67MUPmXOEVFSE20nPI13ub6IgDjNGpCeYCxSrr ZhQjOdFaI/9nvTFjc9g/6hJMBKLKfFnoVGLtHXw5Li3VWuUc0srEZyoYGnjSIM3IySg/ 5U99RkTHx9jzeh81huEVyGy5cPb26H+cB1ToQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ynpcR6n8vAPdutY7ywfm1ArJ7pQbC0NhZJIcycKZNpo=; b=UujSiKv6TNvFqtXLQQrsWLT9I2Q8R61j9Didwnf7EomIJAriGyIYgxVDIhT2EhEhAW 8XQ+iWZpatUlFvk+XZc9vnmA0b5q8QhX70erDmzaV+eQPaxlA8A+IAttgq/sdch02GIh vGodnhCABiGaXag/C4JJeFV7EMSeijByotDW2jzgxgbmIjm8i0iWOXMa1ypaCd48w/ZS lEOMK5mgbSKGZVRyRqVK87lLYWAfiAHPDS6poRE6kpWLLX3vkvAwjmV9Q9R62Nkno/sN dWeq9zb0RCvZTHZnGzVxfZI/5ZVSvCUN5I6vViMkXPTVsCZvjlJS73h+ujEjKjBaww2U jQ5A== X-Gm-Message-State: ANhLgQ3LAAWqU4G5YwkiCerC7pdD2x4Gpb6B9GjXSjqiTrqW8BaFfpYx puumRrSD3ErmTKHH+Req7vRMGTKw8kn1wskmyzRJ/w== X-Google-Smtp-Source: ADFU+vtxwdi0VstprpGXE8kIKWpqGLkTNFZAj2NaX9aV5blHmlg3b0E2DLEIHRTX7ErxOM+aCjkC3E82u9myffv+H2c= X-Received: by 2002:a19:6144:: with SMTP id m4mr5251583lfk.192.1585220575274; Thu, 26 Mar 2020 04:02:55 -0700 (PDT) MIME-Version: 1.0 References: <1585204021-10317-1-git-send-email-vasundhara-v.volam@broadcom.com> <1585204021-10317-4-git-send-email-vasundhara-v.volam@broadcom.com> <20200326092648.GR11304@nanopsycho.orion> In-Reply-To: <20200326092648.GR11304@nanopsycho.orion> From: Vasundhara Volam Date: Thu, 26 Mar 2020 16:32:43 +0530 Message-ID: Subject: Re: [PATCH v2 net-next 3/7] devlink: Add macro for "hw.addr" to info_get cb. To: Jiri Pirko Cc: David Miller , Netdev , Jiri Pirko , Michael Chan Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Mar 26, 2020 at 2:56 PM Jiri Pirko wrote: > > Thu, Mar 26, 2020 at 07:27:00AM CET, vasundhara-v.volam@broadcom.com wrote: > >Add definition and documentation for the new generic info "hw.addr". > >"hw.addr" displays the hardware address of the interface. > > > >Cc: Jiri Pirko > >Signed-off-by: Vasundhara Volam > >Signed-off-by: Michael Chan > >--- > > Documentation/networking/devlink/devlink-info.rst | 5 +++++ > > include/net/devlink.h | 3 +++ > > 2 files changed, 8 insertions(+) > > > >diff --git a/Documentation/networking/devlink/devlink-info.rst b/Documentation/networking/devlink/devlink-info.rst > >index 650e2c0e3..56d13c5 100644 > >--- a/Documentation/networking/devlink/devlink-info.rst > >+++ b/Documentation/networking/devlink/devlink-info.rst > >@@ -144,6 +144,11 @@ board.manufacture > > > > An identifier of the company or the facility which produced the part. > > > >+hw.addr > >+------- > >+ > >+Hardware address of the interface. > >+ > > fw > > -- > > > >diff --git a/include/net/devlink.h b/include/net/devlink.h > >index d51482f..c9383f4 100644 > >--- a/include/net/devlink.h > >+++ b/include/net/devlink.h > >@@ -476,6 +476,9 @@ enum devlink_param_generic_id { > > /* Revision of asic design */ > > #define DEVLINK_INFO_VERSION_GENERIC_ASIC_REV "asic.rev" > > > >+/* Hardware address */ > >+#define DEVLINK_INFO_VERSION_GENERIC_HW_ADDR "hw.addr" > > Wait a second. Is this a MAC. I don't understand why MAC would be here. Yes, this is MAC address. Since, most of the information is displayed via info_get as one place. Would like to display MAC address as well under info_get. Thanks, Vasundhara > If not MAC, what is exactly this address about? > > > >+ > > /* Overall FW version */ > > #define DEVLINK_INFO_VERSION_GENERIC_FW "fw" > > /* Overall FW interface specification version */ > >-- > >1.8.3.1 > >