From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C94F9C282C0 for ; Wed, 23 Jan 2019 11:36:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9757120870 for ; Wed, 23 Jan 2019 11:36:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="D59Ei6Wn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727208AbfAWLgx (ORCPT ); Wed, 23 Jan 2019 06:36:53 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:46993 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726359AbfAWLgx (ORCPT ); Wed, 23 Jan 2019 06:36:53 -0500 Received: by mail-qt1-f194.google.com with SMTP id y20so1858576qtm.13 for ; Wed, 23 Jan 2019 03:36:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H5uapHjn25OuPrxNKgH3l4TpaQlSFCpAt4VIKY+v1IE=; b=D59Ei6WnranVr/254OuwNqDHPRNM3KLpJciltN5OEnBtwD0G3YIJcPg01t4vC1ECxT 8Xq73J5mL4p6yGprMgp6bIa5lWUNYYUuDo9CI0CdOt2wnMA1a2lAegpgaLa/i5vlP6yo FyZlhpNavVohEk3/cVtOePF8eRqtaPq3dGOuo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H5uapHjn25OuPrxNKgH3l4TpaQlSFCpAt4VIKY+v1IE=; b=goJ0vgG3qWEHsGEyR3treDVgxr8vCem1NuEQ0iM3H7WZ6DMI8PLPvZ4IWJRKWtZBvB VVRBktCY9EkViph8xUCVzXE+xgVgrSLVr2qadmkqkSAVIgO2A3a3gCJfOjYH+XXTD/Qy nJM12IO+ANDoRWECcomFMMloUKciklk5WthyTM1N/79YVgk/Mjj/IIwsR9jLe/LbJeUW R9lCvBmxzYIsN/HVu65KR45hkVFBppiuIALPak2Pxki4xvST+13Izgwn/hh8OBNA7COv tV0Q4GLptxz2wLCqU1pIRsmvtSNiKFz3+Ty34b11WfCIUEVjfMWmrwYqoWCivqtxgi0l nCbA== X-Gm-Message-State: AJcUukcbh6AISuLLgqTwWzAW7UX2R8ZRx1uT3B2vGyog2q3hVRvNNcBZ phUNnKwtlD5hYQhkdfKG6c8ANsszFEf9SSDOdNcH4Q== X-Google-Smtp-Source: ALg8bN4aGysdc67VbV5I0AYuBO/5VsjQZP4RH9313P9iAZ9hboc4vLJjoNlRUQfmyX78LCaIRk8lJMTPFt9vxuvzEkY= X-Received: by 2002:a0c:9dc6:: with SMTP id p6mr1558121qvf.217.1548243411794; Wed, 23 Jan 2019 03:36:51 -0800 (PST) MIME-Version: 1.0 References: <1547795385-12354-1-git-send-email-vasundhara-v.volam@broadcom.com> <1547795385-12354-5-git-send-email-vasundhara-v.volam@broadcom.com> <20190123110839.GD2191@nanopsycho> In-Reply-To: <20190123110839.GD2191@nanopsycho> From: Vasundhara Volam Date: Wed, 23 Jan 2019 17:06:40 +0530 Message-ID: Subject: Re: [PATCH net-next v7 4/8] devlink: Add support for driverinit get value for devlink_port To: Jiri Pirko Cc: David Miller , "michael.chan@broadcom.com" , Jiri Pirko , Jakub Kicinski , mkubecek@suse.cz, Netdev Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 23, 2019 at 4:47 PM Jiri Pirko wrote: > > Fri, Jan 18, 2019 at 08:09:41AM CET, vasundhara-v.volam@broadcom.com wrote: > >Add support for "driverinit" configuration mode value for devlink_port > >configuration parameters. Add devlink_port_param_driverinit_value_get() > >function to help the driver get the value from devlink_port. > > > >Also, move the common code to __devlink_param_driverinit_value_get() > >to be used by both device and port params. > > > >Cc: Jiri Pirko > >Signed-off-by: Vasundhara Volam > >--- > > include/net/devlink.h | 8 ++++++ > > net/core/devlink.c | 67 ++++++++++++++++++++++++++++++++++++++------------- > > 2 files changed, 58 insertions(+), 17 deletions(-) > > > >diff --git a/include/net/devlink.h b/include/net/devlink.h > >index 98b8a66..09f3f43 100644 > >--- a/include/net/devlink.h > >+++ b/include/net/devlink.h > >@@ -838,6 +838,14 @@ static inline bool devlink_dpipe_table_counter_enabled(struct devlink *devlink, > > { > > } > > > >+static inline int > >+devlink_port_param_driverinit_value_get(struct devlink_port *devlink_port, > >+ u32 param_id, > >+ union devlink_param_value *init_val) > >+{ > >+ return -EOPNOTSUPP; > >+} > > > You are missing function declaration in case IS_ENABLED(CONFIG_NET_DEVLINK > > Otherwise this looks fine. Thank you for pointing. It is a mistake. I will fix it in next version. > > > >+ > > static inline struct devlink_region * > > devlink_region_create(struct devlink *devlink, > > const char *region_name, > > [...] >