All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: "Jiri Olsa" <jolsa@kernel.org>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Andrii Nakryiko" <andriin@fb.com>,
	"Network Development" <netdev@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>, "Martin KaFai Lau" <kafai@fb.com>,
	"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"KP Singh" <kpsingh@chromium.org>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>,
	"Julia Lawall" <julia.lawall@inria.fr>
Subject: Re: [PATCHv5 bpf-next 0/7] bpf: Tracing and lsm programs re-attach
Date: Sun, 25 Apr 2021 21:14:31 -0700	[thread overview]
Message-ID: <CAADnVQ+D5ery27Qkswwn2z9aouiK3+F48hAHZd854sHwb=hRvg@mail.gmail.com> (raw)
In-Reply-To: <YHk0/QgLQagZMQpf@krava>

On Thu, Apr 15, 2021 at 11:56 PM Jiri Olsa <jolsa@redhat.com> wrote:
>
> On Thu, Apr 15, 2021 at 04:45:24PM -0700, Alexei Starovoitov wrote:
> > On Wed, Apr 14, 2021 at 12:52 PM Jiri Olsa <jolsa@kernel.org> wrote:
> > >
> > > hi,
> > > while adding test for pinning the module while there's
> > > trampoline attach to it, I noticed that we don't allow
> > > link detach and following re-attach for trampolines.
> > > Adding that for tracing and lsm programs.
> > >
> > > You need to have patch [1] from bpf tree for test module
> > > attach test to pass.
> > >
> > > v5 changes:
> > >   - fixed missing hlist_del_init change
> > >   - fixed several ASSERT calls
> > >   - added extra patch for missing ';'
> > >   - added ASSERT macros to lsm test
> > >   - added acks
> >
> > It doesn't work:
>
> hi,
> I got the same warning when running test without the
> patch [1] I mentioned:
>   861de02e5f3f bpf: Take module reference for trampoline in module
>
> I still don't see it in bpf-next/master

Finally applied to bpf-next.
Thank you and sorry for the delay.

      reply	other threads:[~2021-04-26  4:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-14 19:51 [PATCHv5 bpf-next 0/7] bpf: Tracing and lsm programs re-attach Jiri Olsa
2021-04-14 19:51 ` [PATCHv5 bpf-next 1/7] bpf: Allow trampoline re-attach for tracing and lsm programs Jiri Olsa
2021-04-15 23:22   ` Andrii Nakryiko
2021-04-19 22:47     ` KP Singh
2021-04-14 19:51 ` [PATCHv5 bpf-next 2/7] selftests/bpf: Add missing semicolon Jiri Olsa
2021-04-15 23:23   ` Andrii Nakryiko
2021-04-14 19:51 ` [PATCHv5 bpf-next 3/7] selftests/bpf: Add re-attach test to fentry_test Jiri Olsa
2021-04-14 19:51 ` [PATCHv5 bpf-next 4/7] selftests/bpf: Add re-attach test to fexit_test Jiri Olsa
2021-04-14 19:51 ` [PATCHv5 bpf-next 5/7] selftests/bpf: Add re-attach test to lsm test Jiri Olsa
2021-04-14 19:51 ` [PATCHv5 bpf-next 6/7] selftests/bpf: Test that module can't be unloaded with attached trampoline Jiri Olsa
2021-04-14 19:51 ` [PATCHv5 bpf-next 7/7] selftests/bpf: Use ASSERT macros in lsm test Jiri Olsa
2021-04-15 23:24   ` Andrii Nakryiko
2021-04-15 23:45 ` [PATCHv5 bpf-next 0/7] bpf: Tracing and lsm programs re-attach Alexei Starovoitov
2021-04-16  6:55   ` Jiri Olsa
2021-04-26  4:14     ` Alexei Starovoitov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAADnVQ+D5ery27Qkswwn2z9aouiK3+F48hAHZd854sHwb=hRvg@mail.gmail.com' \
    --to=alexei.starovoitov@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=julia.lawall@inria.fr \
    --cc=kafai@fb.com \
    --cc=kpsingh@chromium.org \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=toke@redhat.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.