From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59843C636CB for ; Sat, 28 Jan 2023 21:35:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231492AbjA1VfJ (ORCPT ); Sat, 28 Jan 2023 16:35:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230303AbjA1VfH (ORCPT ); Sat, 28 Jan 2023 16:35:07 -0500 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A92318162; Sat, 28 Jan 2023 13:35:05 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id n6so5059996edo.9; Sat, 28 Jan 2023 13:35:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+zXK+884dLrmhawA8xRQQwxUqchG7ZiNECezW2lOgQA=; b=BVhIi1wAHrJT0sZHx5IKQ6ERyLetJwEsTCVKMe8T2grAtiQV7QwxvxHEmv6xsJAwdF ZjdJF6jjhLdVv89FR55E2mr7soSxcX/14NJjeSkf4/fxXxZDulGyIyUJxu3ZquRtjz2G XW8MQAVmxxM3Vl74UhsCHjfDx+CnMggGvKtlm406tSyFBqQ+JZijnEBmkgYkoXdbJRyd yQ3d6k2fTNJ++nPFl3MpC1tdnjGXp1MU6N2WZW7TgLL7VQTJzMhqLYAtvSXCRxYlJSAt UwufJzQ5QuvrmwBtpfOPcIluWAqJ+1OfWPnZ1fR9JE1IooIaT+JCmWpdNWghdh/+eng5 Dqhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+zXK+884dLrmhawA8xRQQwxUqchG7ZiNECezW2lOgQA=; b=HpfVrLsKjzjVKAJjd8AsP0J8fJsxn35tAD/BDuZceBXkjAtEQIC2uNVV1YE/B3JTNe Ha7+ZpoAM8pcbi1/MAeAwN6wLIHPZyw1VZxMf1Pc3d4KAeOGgcwrJVdTOdseJam9QM9W VZpdrGz1xK3oaRJ/dqN+NGndg2lvEeqG9WEQ1v87/Qhl3CbP55iJNtjmcjXYCWdfhl1H sciTxF+MX9H1r6zlwmOrHfkIWVxT0NMgMBvl8dFv8CTBNWHXu5NKMYPF7P3E3DEKX+YK 7Bs0QXFwgq4DjEEP7z/G6Pu7GFtk9iGMWG94BGFlnhaTvoZue5jcrKWMX8tQ67njrg4K QZSw== X-Gm-Message-State: AFqh2kq6km9aQK1xN73Bnv7ShBtQLOOj7rZ3yX5u116PVFLq4VdSTKre KF1PXoVlTEpcQTaKPpOZRq4BykhQRg1tQFtV+IS4Dgqs X-Google-Smtp-Source: AMrXdXsZzarXZgPPZ/o1qFc85WWamUoar/+dUFn/SXh0NavSmkBXF2uugGK4uBHZdiG1JciMajqTm514M4a/kJkg/Jo= X-Received: by 2002:a05:6402:3814:b0:49e:6501:57a2 with SMTP id es20-20020a056402381400b0049e650157a2mr6932183edb.43.1674941703860; Sat, 28 Jan 2023 13:35:03 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexei Starovoitov Date: Sat, 28 Jan 2023 13:34:52 -0800 Message-ID: Subject: Re: [PATCH v4 bpf-next 8/8] selftests/bpf: introduce XDP compliance test tool To: Lorenzo Bianconi Cc: bpf , Network Development , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , Jesper Dangaard Brouer , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Kumar Kartikeya Dwivedi , Marek Majtyka , Saeed Mahameed , anthony.l.nguyen@intel.com, Andy Gospodarek , vladimir.oltean@nxp.com, Felix Fietkau , john@phrozen.org, Leon Romanovsky , Simon Horman , Ariel Elior , christophe.jaillet@wanadoo.fr, ecree.xilinx@gmail.com, "Michael S. Tsirkin" , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , "Karlsson, Magnus" , "Fijalkowski, Maciej" , intel-wired-lan , Lorenzo Bianconi , Martin KaFai Lau , Stanislav Fomichev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Sat, Jan 28, 2023 at 6:07 AM Lorenzo Bianconi wrote: > diff --git a/tools/testing/selftests/bpf/xdp_features.h b/tools/testing/selftests/bpf/xdp_features.h > new file mode 100644 > index 000000000000..28d7614c4f02 > --- /dev/null > +++ b/tools/testing/selftests/bpf/xdp_features.h > @@ -0,0 +1,33 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +/* test commands */ > +enum test_commands { > + CMD_STOP, /* CMD */ > + CMD_START, /* CMD + xdp feature */ > + CMD_ECHO, /* CMD */ > + CMD_ACK, /* CMD + data */ > + CMD_GET_XDP_CAP, /* CMD */ > + CMD_GET_STATS, /* CMD */ > +}; > + > +#define DUT_CTRL_PORT 12345 > +#define DUT_ECHO_PORT 12346 > + > +struct tlv_hdr { > + __be16 type; > + __be16 len; > + __be32 data[]; > +}; > + > +enum { > + XDP_FEATURE_ABORTED, > + XDP_FEATURE_DROP, > + XDP_FEATURE_PASS, > + XDP_FEATURE_TX, > + XDP_FEATURE_REDIRECT, > + XDP_FEATURE_NDO_XMIT, > + XDP_FEATURE_XSK_ZEROCOPY, > + XDP_FEATURE_HW_OFFLOAD, > + XDP_FEATURE_RX_SG, > + XDP_FEATURE_NDO_XMIT_SG, > +}; This doesn't match the kernel. How did you test this? What should be the way to prevent such mistakes in the future? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E821C38142 for ; Sat, 28 Jan 2023 21:35:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id E9E4B60E4A; Sat, 28 Jan 2023 21:35:09 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org E9E4B60E4A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1674941710; bh=fbU4/opsWicmJZRppLmwYElI6pw5tzqCDFNIglBCn3A=; h=References:In-Reply-To:From:Date:To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=U2692BltVu+IxsOQoZyRTZZEGGQR0m3pQ+vR1rpXog2kQW6VKSM8PNYJIjCStNDK/ vhenNXgmgfYNFwt2htsq4mRb9jkp6Wx78iNBxKTsvvrdaKHagsp6yx+JUcdLJ0OTHr gTuafSeN8pP7lPQiNlGWxgzPO+PVljIAA5nk5nrEf40bIJSB9i+4LeH5ZzrBPJ/RlA cGAD6NqtTR59wZR5DPuvAABWMvv2/AJebactW0Zy8m4vJetY7ZHsOwA02pedsNvyae kWNKQJrrOAg5HLNQfwzn4Ty81JFBexA1swYF0/1IPAC8Ks+iedh0v0vzyqQHOGUr75 gz1TU9ov1C5Hw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FzC0g49g278D; Sat, 28 Jan 2023 21:35:09 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id E18E760DC2; Sat, 28 Jan 2023 21:35:08 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org E18E760DC2 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id C7BAD1BF3C0 for ; Sat, 28 Jan 2023 21:35:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A9C6A81E38 for ; Sat, 28 Jan 2023 21:35:06 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A9C6A81E38 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cHp0a1A5Dr7M for ; Sat, 28 Jan 2023 21:35:06 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C8F2881E2B Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by smtp1.osuosl.org (Postfix) with ESMTPS id C8F2881E2B for ; Sat, 28 Jan 2023 21:35:05 +0000 (UTC) Received: by mail-ed1-x532.google.com with SMTP id x7so4474194edr.0 for ; Sat, 28 Jan 2023 13:35:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+zXK+884dLrmhawA8xRQQwxUqchG7ZiNECezW2lOgQA=; b=alpiZ6EmZb+4fd8tP8IoB9whH9dQJOdZW80sPhQS/RfyPdL8RB6Ulc4SdGFhiqFM32 bD7ZqoHK4df9zfvpWSqFjcLw7Jx80DkioURa61S4vb9etTRPPrqsejPi8qWbkLxuafxv ybcNpHDfp6sqVKv9pMeGMOkOGOh3H/jP/wvpv2iUwxHXfratwSBBMRgIC3A/th2iqg0b Ss3r1ejetn1vil0N/VMMfGPDxIQXcAKHWcHUNszNm627Pf7txcgaB006uDjXJNTtMmZJ jmOWOtzyKIrKgRyE/Ip+H3LGvYbWRgcNf2SQ4wHNRHuggY4QIR0zB6Z+2zUXozkCFuhY sG9Q== X-Gm-Message-State: AFqh2kr7EhxUK+7TkMFIDBe+FU6o+oCW29z8/f/WhNwe7OpvKEhMTP90 flU48lu1o1uQ3KGqmEZeCXVKsaFy4+iLgkxqb9w= X-Google-Smtp-Source: AMrXdXsZzarXZgPPZ/o1qFc85WWamUoar/+dUFn/SXh0NavSmkBXF2uugGK4uBHZdiG1JciMajqTm514M4a/kJkg/Jo= X-Received: by 2002:a05:6402:3814:b0:49e:6501:57a2 with SMTP id es20-20020a056402381400b0049e650157a2mr6932183edb.43.1674941703860; Sat, 28 Jan 2023 13:35:03 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexei Starovoitov Date: Sat, 28 Jan 2023 13:34:52 -0800 Message-ID: To: Lorenzo Bianconi X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+zXK+884dLrmhawA8xRQQwxUqchG7ZiNECezW2lOgQA=; b=BVhIi1wAHrJT0sZHx5IKQ6ERyLetJwEsTCVKMe8T2grAtiQV7QwxvxHEmv6xsJAwdF ZjdJF6jjhLdVv89FR55E2mr7soSxcX/14NJjeSkf4/fxXxZDulGyIyUJxu3ZquRtjz2G XW8MQAVmxxM3Vl74UhsCHjfDx+CnMggGvKtlm406tSyFBqQ+JZijnEBmkgYkoXdbJRyd yQ3d6k2fTNJ++nPFl3MpC1tdnjGXp1MU6N2WZW7TgLL7VQTJzMhqLYAtvSXCRxYlJSAt UwufJzQ5QuvrmwBtpfOPcIluWAqJ+1OfWPnZ1fR9JE1IooIaT+JCmWpdNWghdh/+eng5 Dqhg== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=BVhIi1wA Subject: Re: [Intel-wired-lan] [PATCH v4 bpf-next 8/8] selftests/bpf: introduce XDP compliance test tool X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , vladimir.oltean@nxp.com, Alexei Starovoitov , Eric Dumazet , anthony.l.nguyen@intel.com, Stanislav Fomichev , Daniel Borkmann , Andrii Nakryiko , intel-wired-lan , Simon Horman , Jakub Kicinski , Paolo Abeni , Ariel Elior , Jesper Dangaard Brouer , christophe.jaillet@wanadoo.fr, Kumar Kartikeya Dwivedi , john@phrozen.org, =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , bpf , "Karlsson, Magnus" , Leon Romanovsky , Network Development , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Martin KaFai Lau , ecree.xilinx@gmail.com, Marek Majtyka , Andy Gospodarek , Saeed Mahameed , "David S. Miller" , Felix Fietkau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Sat, Jan 28, 2023 at 6:07 AM Lorenzo Bianconi wrote: > diff --git a/tools/testing/selftests/bpf/xdp_features.h b/tools/testing/selftests/bpf/xdp_features.h > new file mode 100644 > index 000000000000..28d7614c4f02 > --- /dev/null > +++ b/tools/testing/selftests/bpf/xdp_features.h > @@ -0,0 +1,33 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +/* test commands */ > +enum test_commands { > + CMD_STOP, /* CMD */ > + CMD_START, /* CMD + xdp feature */ > + CMD_ECHO, /* CMD */ > + CMD_ACK, /* CMD + data */ > + CMD_GET_XDP_CAP, /* CMD */ > + CMD_GET_STATS, /* CMD */ > +}; > + > +#define DUT_CTRL_PORT 12345 > +#define DUT_ECHO_PORT 12346 > + > +struct tlv_hdr { > + __be16 type; > + __be16 len; > + __be32 data[]; > +}; > + > +enum { > + XDP_FEATURE_ABORTED, > + XDP_FEATURE_DROP, > + XDP_FEATURE_PASS, > + XDP_FEATURE_TX, > + XDP_FEATURE_REDIRECT, > + XDP_FEATURE_NDO_XMIT, > + XDP_FEATURE_XSK_ZEROCOPY, > + XDP_FEATURE_HW_OFFLOAD, > + XDP_FEATURE_RX_SG, > + XDP_FEATURE_NDO_XMIT_SG, > +}; This doesn't match the kernel. How did you test this? What should be the way to prevent such mistakes in the future? _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan