From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C6A7C433EF for ; Fri, 20 May 2022 21:18:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352944AbiETVSm (ORCPT ); Fri, 20 May 2022 17:18:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236005AbiETVSg (ORCPT ); Fri, 20 May 2022 17:18:36 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBA7319C74A; Fri, 20 May 2022 14:18:34 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id n23so12335896edy.0; Fri, 20 May 2022 14:18:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DDu/yTLze4KFg1yFxzaUGUfDQmxCo5o2Ixng2muyqhM=; b=cGT/MLA73M02bfwmF153L+N9j9VGqt4svVWLmTvd8me8wufermxRixpqT7FiftfEWw snz0jt0fvMmRJycvtC19EfxtGK0uJLEpqsINRZHAIqqJGJAidG3GhnE1JcDorl4KbQX0 U/yijzz++jneJNOfIv0LL0x7C6yfmr7DX6xT3nJk9Zto9Ra+FvcvEXKvVoeiVSAsGFdv qw0xXE4mEi5xNL1V+f/6usYfu8dha1bsepuEf309yAsCpxjkgzYvoOeO4WkooK7VEDev i+6XuTpJ/+khHFt4PCt8ogJCs284JujSoeaCEdicl39lyA+h5ojY5er7SAf3ZrVTH/Pr g42w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DDu/yTLze4KFg1yFxzaUGUfDQmxCo5o2Ixng2muyqhM=; b=xaYTWvq3jB9ymqJwktTlOmu5PrnxZWNgSSOTcw1f8ONkEqAtSkoxbSmd4aTAB+bH9Z /vXBnGOt+a8+Z0nh4W4zlwE1nziC6Q5B1gpM1nd7lItRIU3BRfVU12mAOS4i6KC+oBTZ axDnArJ5aNepuCCpqF2URxBtIbmS5TZ2HywDxTAgHyyKLmUjiIGIAunbw0kVYOiZ8yp4 boiTZCH4DdK2jj+v9H2pkVjsbvxAIQz9gunfQ1LTzlFRhniejiRO9vbIrId+LSz8Xxz0 stZ5MQKX3tniZgD4yKDtIx67h20BU1EVom+1hAlzwe5GGfLiT3g6y5AqOQpurNfET5Ud 3CLw== X-Gm-Message-State: AOAM530PEmh0BHEPZmM1WfpPA+KWTh7nRlRQ/xjDkxPNcxAfQzsUJuT6 CKZFAeL2GUO6yqDTHp3cPxbymmgllpVdekWWenHKkuMa X-Google-Smtp-Source: ABdhPJxjcBduBZ+3KMZKwOS16jDqf/LZsYbh4MNzUOUwuzvLfR/ciHJ9IfIzVmNsXrghMzHXByJKIR7piKRMzcpmlSM= X-Received: by 2002:a05:6402:1d48:b0:427:dfa3:2272 with SMTP id dz8-20020a0564021d4800b00427dfa32272mr12914264edb.333.1653081513187; Fri, 20 May 2022 14:18:33 -0700 (PDT) MIME-Version: 1.0 References: <20220518131638.3401509-1-xukuohai@huawei.com> <20220518131638.3401509-6-xukuohai@huawei.com> In-Reply-To: <20220518131638.3401509-6-xukuohai@huawei.com> From: Alexei Starovoitov Date: Fri, 20 May 2022 14:18:20 -0700 Message-ID: Subject: Re: [PATCH bpf-next v5 5/6] bpf, arm64: bpf trampoline for arm64 To: Xu Kuohai Cc: bpf , linux-arm-kernel , LKML , Network Development , "open list:KERNEL SELFTEST FRAMEWORK" , Catalin Marinas , Will Deacon , Steven Rostedt , Ingo Molnar , Daniel Borkmann , Alexei Starovoitov , Zi Shen Lim , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , "David S . Miller" , Hideaki YOSHIFUJI , David Ahern , Thomas Gleixner , Borislav Petkov , Dave Hansen , X86 ML , "H. Peter Anvin" , Shuah Khan , Jakub Kicinski , Jesper Dangaard Brouer , Mark Rutland , Pasha Tatashin , Ard Biesheuvel , Daniel Kiss , Steven Price , Sudeep Holla , Marc Zyngier , Peter Collingbourne , Mark Brown , Delyan Kratunov , Kumar Kartikeya Dwivedi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2022 at 6:54 AM Xu Kuohai wrote: > > Add bpf trampoline support for arm64. Most of the logic is the same as > x86. > > Tested on raspberry pi 4b and qemu with KASLR disabled (avoid long jump), > result: > #9 /1 bpf_cookie/kprobe:OK > #9 /2 bpf_cookie/multi_kprobe_link_api:FAIL > #9 /3 bpf_cookie/multi_kprobe_attach_api:FAIL > #9 /4 bpf_cookie/uprobe:OK > #9 /5 bpf_cookie/tracepoint:OK > #9 /6 bpf_cookie/perf_event:OK > #9 /7 bpf_cookie/trampoline:OK > #9 /8 bpf_cookie/lsm:OK > #9 bpf_cookie:FAIL > #18 /1 bpf_tcp_ca/dctcp:OK > #18 /2 bpf_tcp_ca/cubic:OK > #18 /3 bpf_tcp_ca/invalid_license:OK > #18 /4 bpf_tcp_ca/dctcp_fallback:OK > #18 /5 bpf_tcp_ca/rel_setsockopt:OK > #18 bpf_tcp_ca:OK > #51 /1 dummy_st_ops/dummy_st_ops_attach:OK > #51 /2 dummy_st_ops/dummy_init_ret_value:OK > #51 /3 dummy_st_ops/dummy_init_ptr_arg:OK > #51 /4 dummy_st_ops/dummy_multiple_args:OK > #51 dummy_st_ops:OK > #55 fentry_fexit:OK > #56 fentry_test:OK > #57 /1 fexit_bpf2bpf/target_no_callees:OK > #57 /2 fexit_bpf2bpf/target_yes_callees:OK > #57 /3 fexit_bpf2bpf/func_replace:OK > #57 /4 fexit_bpf2bpf/func_replace_verify:OK > #57 /5 fexit_bpf2bpf/func_sockmap_update:OK > #57 /6 fexit_bpf2bpf/func_replace_return_code:OK > #57 /7 fexit_bpf2bpf/func_map_prog_compatibility:OK > #57 /8 fexit_bpf2bpf/func_replace_multi:OK > #57 /9 fexit_bpf2bpf/fmod_ret_freplace:OK > #57 fexit_bpf2bpf:OK > #58 fexit_sleep:OK > #59 fexit_stress:OK > #60 fexit_test:OK > #67 get_func_args_test:OK > #68 get_func_ip_test:OK > #104 modify_return:OK > #237 xdp_bpf2bpf:OK > > bpf_cookie/multi_kprobe_link_api and bpf_cookie/multi_kprobe_attach_api > failed due to lack of multi_kprobe on arm64. > > Signed-off-by: Xu Kuohai > Acked-by: Song Liu Catalin, Will, Mark, could you please ack this patch that you don't mind us taking this set through bpf-next ? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09FD1C433EF for ; Fri, 20 May 2022 21:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=61ASF1mLA9Vax1K7q7kIzgSuS8+yhBL90LsoRjkP2so=; b=i1yhuXTL7TxKIP rzazxJPngV6I/C1kD+j9RrHWClIgg2WEW0lnYjKsyrQiIHobPTU0BHh8/jCMwGgRNeJSWnQ+D8shG zQKFdxDnKQynspsPMFrS37blHNdtUgNNY2FyBO01ZE2fKaxhkCHZg0tY1gPDjnPhZEAMZeIvIshh2 V8i83X05oFXuB75yEAZM7CmuYW39MCOUD/USCD+9nN+EQ2x4liw4Ouus+GSLR1IhhuenZgBV3+PPs q970+Av94PWVOaFyqyQTmzz+vmHfhuwAmulR1PosR5iK63/4O6kET0s/b9eJtk77k2FTcklA7BTwU 0FskvY/T9S5AcfEEhehQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsA19-00EZDB-0d; Fri, 20 May 2022 21:18:39 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsA16-00EZBe-7q for linux-arm-kernel@lists.infradead.org; Fri, 20 May 2022 21:18:37 +0000 Received: by mail-ed1-x52a.google.com with SMTP id g12so12278876edq.4 for ; Fri, 20 May 2022 14:18:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DDu/yTLze4KFg1yFxzaUGUfDQmxCo5o2Ixng2muyqhM=; b=cGT/MLA73M02bfwmF153L+N9j9VGqt4svVWLmTvd8me8wufermxRixpqT7FiftfEWw snz0jt0fvMmRJycvtC19EfxtGK0uJLEpqsINRZHAIqqJGJAidG3GhnE1JcDorl4KbQX0 U/yijzz++jneJNOfIv0LL0x7C6yfmr7DX6xT3nJk9Zto9Ra+FvcvEXKvVoeiVSAsGFdv qw0xXE4mEi5xNL1V+f/6usYfu8dha1bsepuEf309yAsCpxjkgzYvoOeO4WkooK7VEDev i+6XuTpJ/+khHFt4PCt8ogJCs284JujSoeaCEdicl39lyA+h5ojY5er7SAf3ZrVTH/Pr g42w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DDu/yTLze4KFg1yFxzaUGUfDQmxCo5o2Ixng2muyqhM=; b=7iIPDe9o/WPg/w2CHbeGjYiB3QBgsMhzElNN8gc+JiamXavUxP/1tfxv28xvcVhY/U KzH1RowJQgK5meoUDaJRlsUmMFUk0xuAMIvOj6pDeVMir5g8Eh/VkkHOd8UzRsb79A17 EDuHwrZsm9WY9h8z75ivjo+UT7cixUA0o+7yl4joFcdQeEWC0KVpX0LGWsocTC2xdTcs Su730eTZuzjJVpYT171SZ9Z8v06aG6goB5rqpZ6BEicWm80T1yeqtrSwjI9rAGOUruo4 X9gj9iXjXJao1FcLjDRazPAncQ7ApJyVchTuw7rXk4z1n6GDp7WuxibIujhgfhaB8nTY jI7w== X-Gm-Message-State: AOAM532CZsVvwSNfClaboZEiTmm5z2Jdi9Ww3DT+kwaeaqg3wA4nnQtO GQCT/Spf9Sy4lCWsvW2qPFkZgVVAaACg2IXu4jo= X-Google-Smtp-Source: ABdhPJxjcBduBZ+3KMZKwOS16jDqf/LZsYbh4MNzUOUwuzvLfR/ciHJ9IfIzVmNsXrghMzHXByJKIR7piKRMzcpmlSM= X-Received: by 2002:a05:6402:1d48:b0:427:dfa3:2272 with SMTP id dz8-20020a0564021d4800b00427dfa32272mr12914264edb.333.1653081513187; Fri, 20 May 2022 14:18:33 -0700 (PDT) MIME-Version: 1.0 References: <20220518131638.3401509-1-xukuohai@huawei.com> <20220518131638.3401509-6-xukuohai@huawei.com> In-Reply-To: <20220518131638.3401509-6-xukuohai@huawei.com> From: Alexei Starovoitov Date: Fri, 20 May 2022 14:18:20 -0700 Message-ID: Subject: Re: [PATCH bpf-next v5 5/6] bpf, arm64: bpf trampoline for arm64 To: Xu Kuohai Cc: bpf , linux-arm-kernel , LKML , Network Development , "open list:KERNEL SELFTEST FRAMEWORK" , Catalin Marinas , Will Deacon , Steven Rostedt , Ingo Molnar , Daniel Borkmann , Alexei Starovoitov , Zi Shen Lim , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , "David S . Miller" , Hideaki YOSHIFUJI , David Ahern , Thomas Gleixner , Borislav Petkov , Dave Hansen , X86 ML , "H. Peter Anvin" , Shuah Khan , Jakub Kicinski , Jesper Dangaard Brouer , Mark Rutland , Pasha Tatashin , Ard Biesheuvel , Daniel Kiss , Steven Price , Sudeep Holla , Marc Zyngier , Peter Collingbourne , Mark Brown , Delyan Kratunov , Kumar Kartikeya Dwivedi X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_141836_324984_1F7713E1 X-CRM114-Status: GOOD ( 12.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 18, 2022 at 6:54 AM Xu Kuohai wrote: > > Add bpf trampoline support for arm64. Most of the logic is the same as > x86. > > Tested on raspberry pi 4b and qemu with KASLR disabled (avoid long jump), > result: > #9 /1 bpf_cookie/kprobe:OK > #9 /2 bpf_cookie/multi_kprobe_link_api:FAIL > #9 /3 bpf_cookie/multi_kprobe_attach_api:FAIL > #9 /4 bpf_cookie/uprobe:OK > #9 /5 bpf_cookie/tracepoint:OK > #9 /6 bpf_cookie/perf_event:OK > #9 /7 bpf_cookie/trampoline:OK > #9 /8 bpf_cookie/lsm:OK > #9 bpf_cookie:FAIL > #18 /1 bpf_tcp_ca/dctcp:OK > #18 /2 bpf_tcp_ca/cubic:OK > #18 /3 bpf_tcp_ca/invalid_license:OK > #18 /4 bpf_tcp_ca/dctcp_fallback:OK > #18 /5 bpf_tcp_ca/rel_setsockopt:OK > #18 bpf_tcp_ca:OK > #51 /1 dummy_st_ops/dummy_st_ops_attach:OK > #51 /2 dummy_st_ops/dummy_init_ret_value:OK > #51 /3 dummy_st_ops/dummy_init_ptr_arg:OK > #51 /4 dummy_st_ops/dummy_multiple_args:OK > #51 dummy_st_ops:OK > #55 fentry_fexit:OK > #56 fentry_test:OK > #57 /1 fexit_bpf2bpf/target_no_callees:OK > #57 /2 fexit_bpf2bpf/target_yes_callees:OK > #57 /3 fexit_bpf2bpf/func_replace:OK > #57 /4 fexit_bpf2bpf/func_replace_verify:OK > #57 /5 fexit_bpf2bpf/func_sockmap_update:OK > #57 /6 fexit_bpf2bpf/func_replace_return_code:OK > #57 /7 fexit_bpf2bpf/func_map_prog_compatibility:OK > #57 /8 fexit_bpf2bpf/func_replace_multi:OK > #57 /9 fexit_bpf2bpf/fmod_ret_freplace:OK > #57 fexit_bpf2bpf:OK > #58 fexit_sleep:OK > #59 fexit_stress:OK > #60 fexit_test:OK > #67 get_func_args_test:OK > #68 get_func_ip_test:OK > #104 modify_return:OK > #237 xdp_bpf2bpf:OK > > bpf_cookie/multi_kprobe_link_api and bpf_cookie/multi_kprobe_attach_api > failed due to lack of multi_kprobe on arm64. > > Signed-off-by: Xu Kuohai > Acked-by: Song Liu Catalin, Will, Mark, could you please ack this patch that you don't mind us taking this set through bpf-next ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel