From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC77DC7618F for ; Wed, 17 Jul 2019 01:36:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB2962173E for ; Wed, 17 Jul 2019 01:36:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rM956dfh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725876AbfGQBgJ (ORCPT ); Tue, 16 Jul 2019 21:36:09 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:45807 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725850AbfGQBgJ (ORCPT ); Tue, 16 Jul 2019 21:36:09 -0400 Received: by mail-lj1-f195.google.com with SMTP id m23so21851466lje.12; Tue, 16 Jul 2019 18:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qWO940pMJO4ZymWj5Lb7uIRr1s/46e+FeEyw+BZ1KrQ=; b=rM956dfhNiUfnI6x3mNUjAp19DwuSqYBCXebjUx36tROXnICbcajZ0F4WWdDs/u4P8 QkYoWtvQcmDIMUOWE2IZIAWsRYokDYZHXiscRHl15VmJdT9T8pHuP0J+vI84Cy2vTsWU KVVO5JzPbmPzzBuM2HkvR7epHTX0HZvlVb2RsdkEA8n+UtGO/d7ncHfKR/P5xLPaHqyP kxoqJTt0AtQKgNJpCWhA///DpF6QXXO7t7cqH/qxlFnORmynH0pvCK91opipUr1xlHms jaDtGvjxSOvMrq+P5uAbvWNwb6XCAycA5OqznknghUIX2trqIw7nCgEFglR5FdIOnim1 SCwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qWO940pMJO4ZymWj5Lb7uIRr1s/46e+FeEyw+BZ1KrQ=; b=ZRN+hU8EOB+3uRQgXQKKR+DZxQfMHLm2OCDMjLmAk8GuMbYDzbFAZKZ4Og8quDRzQt 4CCgMJxBr+zRGkBty/FpIdaHqTveinF/TI1mLaZy0Leoq5Ld3dJgu4+QlGTpXWwXWQaa TbToKSiPDZRw09B+16TEoQl0+1eQWKmYc7cNHrdUxZNPY9b6QKT5bgj1CATi5T1l/jrW YwmvUHHMz7DY6QugEZIDR2vf6FrTUBkDSlKNmoAOE03YIj4VQ9kVlXSBQXWaB9WVN8tC mv/BKtaisxJNAvD9Fd22U1ru79/f41k8Vuh4nl34s4BJY76geGec5cvNcmcuDPDZu27H 8ITw== X-Gm-Message-State: APjAAAXgVR3X/OuVLit/q+cu6r5uo/VdkaZWHyHQMwItx5otIO+pg29s Ay0Ps4rBtphUZ7ydg8o1T42/lAEUeco2xJXV0qg= X-Google-Smtp-Source: APXvYqwjmBPeJyt7/FpBY830uGJ+ncWrhpcaSVI85aV1J7rGG4UWVSAqKxXZ2ETt9WWVoML43ELhP9XTl7mHxaRxbX8= X-Received: by 2002:a2e:93cc:: with SMTP id p12mr19531900ljh.11.1563327366873; Tue, 16 Jul 2019 18:36:06 -0700 (PDT) MIME-Version: 1.0 References: <20190716193837.2808971-1-andriin@fb.com> <20190716195544.GB14834@mini-arch> <20190716225735.GC14834@mini-arch> <20190717001457.GD14834@mini-arch> In-Reply-To: From: Alexei Starovoitov Date: Tue, 16 Jul 2019 18:35:55 -0700 Message-ID: Subject: Re: [PATCH bpf 1/2] selftests/bpf: fix test_verifier/test_maps make dependencies To: Andrii Nakryiko Cc: Stanislav Fomichev , Andrii Nakryiko , bpf , Networking , Daniel Borkmann , Alexei Starovoitov , Kernel Team , Ilya Leoshkevich , Stanislav Fomichev , Martin KaFai Lau Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Jul 16, 2019 at 5:22 PM Andrii Nakryiko wrote: > > Makefile becomes hairier by the day, thx for cleaning it up a bit :-) > > > > > But I also don't think we need to worry about creating them, because > > > there is always at least one test (otherwise those tests are useless > > > anyways) in those directories, so we might as well just remove those > > > dependencies, I guess. > > We probably care about them for "make -C tools/selftests O=$PWD/xyz" case > > where OUTPUT would point to a fresh/clean directory. > > Oh, yes, out-of-tree builds, forgot about that, so yeah, we need that. Anyhow the patches fixed the issue I was seeing. Hence both applied.