All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: "sunyucong@gmail.com" <sunyucong@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Quentin Monnet <quentin@isovalent.com>,
	Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v3 bpf-next] libbpf: add LIBBPF_DEPRECATED_SINCE macro for scheduling API deprecations
Date: Mon, 13 Sep 2021 12:32:18 -0700	[thread overview]
Message-ID: <CAADnVQKq5-ku4J3-nVf3bDLbxHwfHEPDZSCrcG+SXbP3VmPP1A@mail.gmail.com> (raw)
In-Reply-To: <CAEf4BzYF7r6BvgB6tiVfDYKk3Yf92=E=CcX7CVkj4ANFU4T6cw@mail.gmail.com>

On Mon, Sep 13, 2021 at 11:13 AM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Mon, Sep 13, 2021 at 7:29 AM sunyucong@gmail.com <sunyucong@gmail.com> wrote:
> >
> > I ran into the same issue
> >
> >   DESCEND objtool
> >   DESCEND bpf/resolve_btfids
> >   CALL    scripts/atomic/check-atomics.sh
> >   CALL    scripts/checksyscalls.sh
> >   CHK     include/generated/compile.h
> >   CC      kernel/rseq.o
> >   CC [U]  kernel/bpf/preload/iterators/iterators.o
> > In file included from ./tools/lib/bpf/libbpf.h:20,
> >                  from kernel/bpf/preload/iterators/iterators.c:10:
> > ./tools/lib/bpf/libbpf_common.h:13:10: fatal error: libbpf_version.h:
> > No such file or directory
> >    13 | #include "libbpf_version.h"
> >       |          ^~~~~~~~~~~~~~~~~~
> > compilation terminated.
> > make[3]: *** [scripts/Makefile.userprogs:43:
> > kernel/bpf/preload/iterators/iterators.o] Error 1
> > make[2]: *** [scripts/Makefile.build:540: kernel/bpf/preload] Error 2
> > make[1]: *** [scripts/Makefile.build:540: kernel/bpf] Error 2
> > make[1]: *** Waiting for unfinished jobs....
> > make: *** [Makefile:1872: kernel] Error 2
> > make: *** Waiting for unfinished jobs....
> >
> >
> > And I tried `make clean` in tools/lib/bpf , which didn't solve the
>
> make clean in tools/lib/bpf won't help, you'd need to clean kernel/bpf/preload
>
> > issue, had to do a full clean.  To me it seems we should add
> > "libbpf_version.h" along with LIBBPF_A  in kernel/bpf/preload/Makefile
>
> LIBBPF_A should force generation of libbpf_version.h, so there is no
> need to add libbpf_version.h explicitly. I wonder if maybe adding
> FORCE would help, like this:
>
> $(LIBBPF_A): FORCE
>    ...
>
> If you can still repro this, can you please try that? You might need
> to also have
>
> .PHONY: FORCE
> FORCE:
>
> in that file for this to work. It should force calling into libbpf's
> Makefile, even if Kbuild believes LIBBPF_A is up to date.

I've hit this issue as well and could easily repro.
The (LIBBPF_A): FORCE fixed it for me and I pushed this one liner to bpf-next.
The later hunk wasn't necessary.

  reply	other threads:[~2021-09-13 19:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08 21:32 [PATCH v3 bpf-next] libbpf: add LIBBPF_DEPRECATED_SINCE macro for scheduling API deprecations Andrii Nakryiko
2021-09-09 12:58 ` Daniel Borkmann
2021-09-09 16:37   ` Andrii Nakryiko
2021-09-09 18:08     ` Andrii Nakryiko
2021-09-09 21:43       ` Daniel Borkmann
2021-09-09 22:31         ` Andrii Nakryiko
2021-09-13 14:28           ` sunyucong
2021-09-13 18:13             ` Andrii Nakryiko
2021-09-13 19:32               ` Alexei Starovoitov [this message]
2021-09-09 21:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAADnVQKq5-ku4J3-nVf3bDLbxHwfHEPDZSCrcG+SXbP3VmPP1A@mail.gmail.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=quentin@isovalent.com \
    --cc=sunyucong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.