From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F7E8C31E47 for ; Wed, 12 Jun 2019 00:05:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A9082173C for ; Wed, 12 Jun 2019 00:05:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iDBd+Nyh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407038AbfFLAFV (ORCPT ); Tue, 11 Jun 2019 20:05:21 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:41495 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387864AbfFLAFV (ORCPT ); Tue, 11 Jun 2019 20:05:21 -0400 Received: by mail-lj1-f193.google.com with SMTP id s21so13434812lji.8; Tue, 11 Jun 2019 17:05:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=twnhTVYd7tn35O7vvlIa3XEgKYk2/zieh7kgQ5Ms1VY=; b=iDBd+Nyh60vWHvSGtVHWVETugM2fnnm+FqmmiJZ56NZHl6V9Aty9AmjFW8CRdEnVVB aGKuXc3BMI1WRmMN59ZmT1r6kVO7qzb4q1bDpYmpS/ZUrVuenxbQGoF2Qv4WS5P5xTYu MgUGL2vvXlsZ04GvxKv4oWOnyz8mNGE24H+bdBFJTo0aHTJ0k0u+7bh9tcE9VNAMwAtH iKtxqCy1DSmKDdJUUU93WbsyygyX8RtwvZ5Owd5cCDJ9ZU6yAlx8+gKU6PDNIGy1Yrds 5FOvUqOWwAWAd5bt0eEYz6DGK7Ot7sHrl6lNbuwYOmPXTEQ7T1WTuP7Qnyr0A/A07xpx QkCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=twnhTVYd7tn35O7vvlIa3XEgKYk2/zieh7kgQ5Ms1VY=; b=fqEU0XMyfNflfhQT79oxZghavXpJ1dAzYWSMm/qb4gmos8iA2TeNBJ0PUDAE/Hziuc bcmkQUVGTodSXW4WmUcE9UbCbklB1P7Hfg+uvtOj6dEzEdotDAAFyArOd3ScHgIQNVs5 0JS9pIniFAgDhZ4tXvbDA5Wd7OJm5Til/+3lHBMc+FZ4Th9Uj7DK21wcJRIHCksoumid oyUuStSybwP7edfVFrdhM6JvHk+DDVpdY1QTx93zhasPNw8m+Rv31ORF54nq/akB0sbh SVkLKb03VXRyP+j7I9Yb4Iqiz7BHFYtNrpDNWePKx+aosKbJYg7P7LG1/Z8/MzWuKwy8 Zlbw== X-Gm-Message-State: APjAAAVdLDPQZSMGnTI0GPYm3j5E17tzyOWa4m4EfXM7tVCJe8oCX3/+ qfJ4ROah2uLK8s8qnMM5gMeTz+fyeeBSbUV9JBw= X-Google-Smtp-Source: APXvYqyO/Oi3PmoK5iJ0YzdPrMw5xZcqUF1R75rhMCOs6SLJy8NUkUXX4LUB1wFJr6ZxPQT0SJAlgxYZrwxAPMCixo8= X-Received: by 2002:a2e:298a:: with SMTP id p10mr12710225ljp.74.1560297918252; Tue, 11 Jun 2019 17:05:18 -0700 (PDT) MIME-Version: 1.0 References: <20190611193836.2772-1-shyam.saini@amarulasolutions.com> In-Reply-To: <20190611193836.2772-1-shyam.saini@amarulasolutions.com> From: Alexei Starovoitov Date: Tue, 11 Jun 2019 17:05:06 -0700 Message-ID: Subject: Re: [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro To: Shyam Saini Cc: Kernel Hardening , LKML , Andrew Morton , Kees Cook , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Network Development , linux-ext4@vger.kernel.org, devel@lists.orangefs.org, linux-mm , linux-sctp@vger.kernel.org, bpf , kvm@vger.kernel.org, mayhs11saini@gmail.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 11, 2019 at 5:00 PM Shyam Saini wrote: > > Currently, there are 3 different macros, namely sizeof_field, SIZEOF_FIELD > and FIELD_SIZEOF which are used to calculate the size of a member of > structure, so to bring uniformity in entire kernel source tree lets use > FIELD_SIZEOF and replace all occurrences of other two macros with this. > > For this purpose, redefine FIELD_SIZEOF in include/linux/stddef.h and > tools/testing/selftests/bpf/bpf_util.h and remove its defination from > include/linux/kernel.h please dont. bpf_util.h is a user space header. Please leave it as-is. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Date: Wed, 12 Jun 2019 00:05:06 +0000 Subject: Re: [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro Message-Id: List-Id: References: <20190611193836.2772-1-shyam.saini@amarulasolutions.com> In-Reply-To: <20190611193836.2772-1-shyam.saini@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Shyam Saini Cc: Kernel Hardening , LKML , Andrew Morton , Kees Cook , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Network Development , linux-ext4@vger.kernel.org, devel@lists.orangefs.org, linux-mm , linux-sctp@vger.kernel.org, bpf , kvm@vger.kernel.org, mayhs11saini@gmail.com On Tue, Jun 11, 2019 at 5:00 PM Shyam Saini wrote: > > Currently, there are 3 different macros, namely sizeof_field, SIZEOF_FIELD > and FIELD_SIZEOF which are used to calculate the size of a member of > structure, so to bring uniformity in entire kernel source tree lets use > FIELD_SIZEOF and replace all occurrences of other two macros with this. > > For this purpose, redefine FIELD_SIZEOF in include/linux/stddef.h and > tools/testing/selftests/bpf/bpf_util.h and remove its defination from > include/linux/kernel.h please dont. bpf_util.h is a user space header. Please leave it as-is. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF5FC31E44 for ; Wed, 12 Jun 2019 00:05:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 42907208C2 for ; Wed, 12 Jun 2019 00:05:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iDBd+Nyh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42907208C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C4E2E6B000D; Tue, 11 Jun 2019 20:05:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFF826B000E; Tue, 11 Jun 2019 20:05:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEE476B0010; Tue, 11 Jun 2019 20:05:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by kanga.kvack.org (Postfix) with ESMTP id 4A9E26B000D for ; Tue, 11 Jun 2019 20:05:20 -0400 (EDT) Received: by mail-lj1-f197.google.com with SMTP id 77so666636ljf.0 for ; Tue, 11 Jun 2019 17:05:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:mime-version:references :in-reply-to:from:date:message-id:subject:to:cc; bh=twnhTVYd7tn35O7vvlIa3XEgKYk2/zieh7kgQ5Ms1VY=; b=g0d/qL+B1sNYjBjEFWOu/z13Ofd7SN25SBWIq0ZkQZMJJ35xtFJcM14yhiqVub2tXR ej/0t+XiDx9dQyae1cETV2gc3MotPxeGp7UqSAWl3lHGK2pMYA/HzYLdXzlkRlSGI/Zi PhyAlmQ3X3K5+1RgQtsiUdpFvPZNCWTS8NdIVJhCgfGWG2NTonftPG71ylUpwUTkifHt Bi/EC/0GEtwR9Mx04Z5+F8OL4DRQIhthG6sMSwd1sWEYQmqTavvhY8dxoAOtMp3JXL+L fxDSh5JF+u+4/VHCIEOKjrIlfZGRRPLZu6tT3IYugju5OyzfdwF3thT0XDI2hViL+GMK fK0A== X-Gm-Message-State: APjAAAX0IcebOLRTSB6iIF+cXZuz/FMe3zU3dJxmfKXSqrCzXqtCzdTo WyQUxjPHeicCi2uivTkrVm3r2twdD8BjT20AFz7AcBZWOdi/GWgKRB7+nky02qTdci6BclQSR2P tjiKrD4WRmyjXdU0Qf0aLF9a9lYw3irNFenTyKQgz6olsGkYJy7d82/VfmtePb/0tPA== X-Received: by 2002:ac2:46f9:: with SMTP id q25mr42339038lfo.181.1560297919438; Tue, 11 Jun 2019 17:05:19 -0700 (PDT) X-Received: by 2002:ac2:46f9:: with SMTP id q25mr42339017lfo.181.1560297918652; Tue, 11 Jun 2019 17:05:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560297918; cv=none; d=google.com; s=arc-20160816; b=LQ1EUzEz1qKXk6qrRllX+/Bl50zfreTTCfRP3bkJElMXA+JGxYwolUAMrVqJRP7/w7 Jw7kyy4ILovqlbR0VnTf9Jz4nYtwZBlZaLwxVtvF/gAlzwvnYdgkQHLQwWm2+7QluhEC FWYUPgscxi9psQmxvSyQg0Pjd2YLaKz2X1DfOhieKSfL32sHcqJWPUGH5P4LtNJoD5sK HpdAzW6Isg7RXOIf/Ls8z6ZiFvtHzQ5RVGhj77AP9V+cKA8gTN8UZTSarIClKxJqiThW ykx5syefH8fU8KHih80SnEdcAZd5j9KtIiocPKapJTDfyJ5zimHbsQ5szIcgh46BhWX9 kO/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=twnhTVYd7tn35O7vvlIa3XEgKYk2/zieh7kgQ5Ms1VY=; b=Nb6YTlxDtK7/M2foyMWd8ctLkBIlLCVM92HsS4WJDo8tUDweGEqlz8VRIBBztmNhTp AnQ6lzimap9R7DJnSsE0SASd5MbzXEBRXnLhdDhl3T0IHjbNgG8IHTK0C6WE6yCiXtZj Q5HvceW3hmHDvQVmbu9mvUyq6ONrn9WQRfpWK4qnMW5b+wlXfOSVRuEoqdk82rFU+d5D TBKkqIEh2VhqX7wo7xlQpWJyFWCjIuQASDFzKQNTcwAFbLcNtGhCHA/upJMVyar1vOzc FVmxwNu5uPXx106FbH4Em6bmgvOhgl0hFYjmxbA1RDshJVEv2w+LnWAegdms8AszTNCm rUrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iDBd+Nyh; spf=pass (google.com: domain of alexei.starovoitov@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id b20sor4733666ljj.6.2019.06.11.17.05.18 for (Google Transport Security); Tue, 11 Jun 2019 17:05:18 -0700 (PDT) Received-SPF: pass (google.com: domain of alexei.starovoitov@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iDBd+Nyh; spf=pass (google.com: domain of alexei.starovoitov@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=twnhTVYd7tn35O7vvlIa3XEgKYk2/zieh7kgQ5Ms1VY=; b=iDBd+Nyh60vWHvSGtVHWVETugM2fnnm+FqmmiJZ56NZHl6V9Aty9AmjFW8CRdEnVVB aGKuXc3BMI1WRmMN59ZmT1r6kVO7qzb4q1bDpYmpS/ZUrVuenxbQGoF2Qv4WS5P5xTYu MgUGL2vvXlsZ04GvxKv4oWOnyz8mNGE24H+bdBFJTo0aHTJ0k0u+7bh9tcE9VNAMwAtH iKtxqCy1DSmKDdJUUU93WbsyygyX8RtwvZ5Owd5cCDJ9ZU6yAlx8+gKU6PDNIGy1Yrds 5FOvUqOWwAWAd5bt0eEYz6DGK7Ot7sHrl6lNbuwYOmPXTEQ7T1WTuP7Qnyr0A/A07xpx QkCw== X-Google-Smtp-Source: APXvYqyO/Oi3PmoK5iJ0YzdPrMw5xZcqUF1R75rhMCOs6SLJy8NUkUXX4LUB1wFJr6ZxPQT0SJAlgxYZrwxAPMCixo8= X-Received: by 2002:a2e:298a:: with SMTP id p10mr12710225ljp.74.1560297918252; Tue, 11 Jun 2019 17:05:18 -0700 (PDT) MIME-Version: 1.0 References: <20190611193836.2772-1-shyam.saini@amarulasolutions.com> In-Reply-To: <20190611193836.2772-1-shyam.saini@amarulasolutions.com> From: Alexei Starovoitov Date: Tue, 11 Jun 2019 17:05:06 -0700 Message-ID: Subject: Re: [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro To: Shyam Saini Cc: Kernel Hardening , LKML , Andrew Morton , Kees Cook , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Network Development , linux-ext4@vger.kernel.org, devel@lists.orangefs.org, linux-mm , linux-sctp@vger.kernel.org, bpf , kvm@vger.kernel.org, mayhs11saini@gmail.com Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 11, 2019 at 5:00 PM Shyam Saini wrote: > > Currently, there are 3 different macros, namely sizeof_field, SIZEOF_FIELD > and FIELD_SIZEOF which are used to calculate the size of a member of > structure, so to bring uniformity in entire kernel source tree lets use > FIELD_SIZEOF and replace all occurrences of other two macros with this. > > For this purpose, redefine FIELD_SIZEOF in include/linux/stddef.h and > tools/testing/selftests/bpf/bpf_util.h and remove its defination from > include/linux/kernel.h please dont. bpf_util.h is a user space header. Please leave it as-is. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70552C31E44 for ; Wed, 12 Jun 2019 00:05:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 473EE208C2 for ; Wed, 12 Jun 2019 00:05:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QgVlqqAB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iDBd+Nyh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 473EE208C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bjeidCZ698s64POYozz/9yyN02zyGNPAzn3ywWfuFRk=; b=QgVlqqABwqDULC b3m/Pef/s6dnT91q03Y8Oxo/JTT2VF9UzMB0I2D2pwe4mMJngodyZPxgTNHoI/tA8Q/x/VKyGLcDL kDFiWBOwd6+9TPzCa2xjZvtwwfIgebD1lGJGNN+WGCikL5CV1ffccXWjwgdDgWJd8Kc6hrjcpFRwU G0mSdWKT4c60nuwbT4lbel6fkkB0PDyNlg0+eVGCyFunWpSga9iU+jyXXxypKpXj+/Its8s/9j/AJ TxI9hHNQ/omP01nrShPj5SdK+gfpQE1NZSlCRBca3oYWqAzLmBgxyhM0myvqZX9BXOcGboZPwdfDs D5sUiJAtuqD0SnvlZy7g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haqlZ-0006iW-5P; Wed, 12 Jun 2019 00:05:25 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1haqlV-0006i3-IH for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2019 00:05:23 +0000 Received: by mail-lj1-x244.google.com with SMTP id p17so6139111ljg.1 for ; Tue, 11 Jun 2019 17:05:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=twnhTVYd7tn35O7vvlIa3XEgKYk2/zieh7kgQ5Ms1VY=; b=iDBd+Nyh60vWHvSGtVHWVETugM2fnnm+FqmmiJZ56NZHl6V9Aty9AmjFW8CRdEnVVB aGKuXc3BMI1WRmMN59ZmT1r6kVO7qzb4q1bDpYmpS/ZUrVuenxbQGoF2Qv4WS5P5xTYu MgUGL2vvXlsZ04GvxKv4oWOnyz8mNGE24H+bdBFJTo0aHTJ0k0u+7bh9tcE9VNAMwAtH iKtxqCy1DSmKDdJUUU93WbsyygyX8RtwvZ5Owd5cCDJ9ZU6yAlx8+gKU6PDNIGy1Yrds 5FOvUqOWwAWAd5bt0eEYz6DGK7Ot7sHrl6lNbuwYOmPXTEQ7T1WTuP7Qnyr0A/A07xpx QkCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=twnhTVYd7tn35O7vvlIa3XEgKYk2/zieh7kgQ5Ms1VY=; b=j6UTycd6u07rkjaFL1tFcIvjHdcZZub0WjNVOwm8Frj6tW/ZKJYMl1CeSUeKwD2hHQ qXrQmJtHwK7S1Qzi4aVjM9lkdVJsHnvdup68i5t0/MEgSRnUS6N118uxhIP0ZSE7O5DR aQ9JIUqYzQ/Jq/FAvZA1ZKCMx53CFQaEYBNqKGFx46owhj34w0lBvoc7YG5AzMjbEWN6 U7gauhl6Ma9qImq4kvoXT21MeQmjjX7Pc1/lX3t/fJ4LVWfczrpOEextkyv6WfSyfRZG mT/xEaDofK6QLvEKLIMJmojeLfFzJHupIsboKWSVWbA9v1PlsCG54mUqjjLGNx7lqh0x LiEw== X-Gm-Message-State: APjAAAU2Gp22kCLT5z5wIKj5Pc0wY01M8Y5eD4kNLcg4o8u8y1rQ7FZo R88BoEp0elK0MLuTx0cD8M+oVPC3JVsfDUWCN8Y= X-Google-Smtp-Source: APXvYqyO/Oi3PmoK5iJ0YzdPrMw5xZcqUF1R75rhMCOs6SLJy8NUkUXX4LUB1wFJr6ZxPQT0SJAlgxYZrwxAPMCixo8= X-Received: by 2002:a2e:298a:: with SMTP id p10mr12710225ljp.74.1560297918252; Tue, 11 Jun 2019 17:05:18 -0700 (PDT) MIME-Version: 1.0 References: <20190611193836.2772-1-shyam.saini@amarulasolutions.com> In-Reply-To: <20190611193836.2772-1-shyam.saini@amarulasolutions.com> From: Alexei Starovoitov Date: Tue, 11 Jun 2019 17:05:06 -0700 Message-ID: Subject: Re: [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro To: Shyam Saini X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190611_170521_629896_6481042E X-CRM114-Status: UNSURE ( 8.42 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , kvm@vger.kernel.org, Kernel Hardening , Network Development , intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org, LKML , linux-mm , linux-sctp@vger.kernel.org, devel@lists.orangefs.org, Andrew Morton , linux-ext4@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, bpf , linux-arm-kernel@lists.infradead.org, mayhs11saini@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 11, 2019 at 5:00 PM Shyam Saini wrote: > > Currently, there are 3 different macros, namely sizeof_field, SIZEOF_FIELD > and FIELD_SIZEOF which are used to calculate the size of a member of > structure, so to bring uniformity in entire kernel source tree lets use > FIELD_SIZEOF and replace all occurrences of other two macros with this. > > For this purpose, redefine FIELD_SIZEOF in include/linux/stddef.h and > tools/testing/selftests/bpf/bpf_util.h and remove its defination from > include/linux/kernel.h please dont. bpf_util.h is a user space header. Please leave it as-is. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel