From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AC2BC76195 for ; Fri, 24 Mar 2023 19:49:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231873AbjCXTtI (ORCPT ); Fri, 24 Mar 2023 15:49:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230038AbjCXTtH (ORCPT ); Fri, 24 Mar 2023 15:49:07 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1784D59D5; Fri, 24 Mar 2023 12:49:06 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id x3so12040282edb.10; Fri, 24 Mar 2023 12:49:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679687344; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5dGXja0zvpydJsZsuWVMkoEKw4WPEINUjm2uBsr6JaU=; b=hs+ldOsjN8SnevYkzSOcp4cUBEN4Xz3SacCSZd9EtvwORoBt+sjEovcWxwL5NRPud/ 5xtC+0z/mihjmMb9UwUJHVANr65g4XGxlUbowxfEyRQNVL2fbf3D5UnoHBKwlTNdqeca DellOa12KN2h9XCNNadej7ttPf9Gq9ezLz03YnxpIXt59Fs36Ey5JUYBA8ovvNhEviUz TMXBWFTpwMXnuTPYUzvqp5WSAIybWC7VCvuMCTc33hipAa9Cb1fYT1PSGeyqZH1VSsRZ s7RuGtEbereB47YaGeVgLLSSFeeOZFk6r68ZoYAYvf54FwKsYH/54Xofkpik0jJRGogR SPMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679687344; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5dGXja0zvpydJsZsuWVMkoEKw4WPEINUjm2uBsr6JaU=; b=4oNYKaVCrwr4JYztL+Cl5b+qUkOeaKqtdiPlUc/pKZUX6NUTr6DbdYjmz/ZDsKdhuW 514SiHA1AjmfkYfhsL7PsbwetXQpicEckjmGvuCr2SmjwDmhXcYIUc9LCUlvP5iUzctg TeGMp+Dna7sc9Ign2id2fAwteYL8WrALTgvZaQYFZNNO7DCs0mV4YXEc87T4cwXp/HrE QZ2HIw9Knp0tTIpUCynPStsGsMdBx2lRaZNTrh9ZMlYzodeZ8PfkxX/vnzyIyOkVsdI7 pgRSSGOD/Ux2jhXMaEfaaGyo33P65lVkiWSL41PFrS/vNKnn+vmiyhfBUhBve78bDKWc Vjgw== X-Gm-Message-State: AAQBX9dzy/XsYjSyO8BNTaDFYYaeK80+qVI6gJd5QwgCkAxPEYArasK+ f5ODvs//Y9NGiO9UYeKkunMmE8qoBVy3+0GEEQ6M+2Kurg0tTidF X-Google-Smtp-Source: AKy350ZSA0zMugpWag/aWNzDe6DH4VbciU7FRSO8/Ns0h3xwxK448eN6P/ZPeRUIQsY0L0n+v2e7VRgBj5PuJtuhA4U= X-Received: by 2002:a50:cc94:0:b0:4fb:c8e3:1ae2 with SMTP id q20-20020a50cc94000000b004fbc8e31ae2mr2144838edi.3.1679687344430; Fri, 24 Mar 2023 12:49:04 -0700 (PDT) MIME-Version: 1.0 References: <20230324123626.2177476-1-sashal@kernel.org> In-Reply-To: From: Alexei Starovoitov Date: Fri, 24 Mar 2023 12:48:53 -0700 Message-ID: Subject: Re: [PATCH] capability: test_deny_namespace breakage due to capability conversion to u64 To: Linus Torvalds Cc: Sasha Levin , Andrii Nakryiko , Mykola Lysenko , bpf , "open list:KERNEL SELFTEST FRAMEWORK" , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 24, 2023 at 9:49=E2=80=AFAM Linus Torvalds wrote: > > On Fri, Mar 24, 2023 at 5:36=E2=80=AFAM Sasha Levin w= rote: > > > > Commit f122a08b197d ("capability: just use a 'u64' instead of a 'u32[2]= ' > > array") attempts to use BIT_LL() but actually wanted to use BIT_ULL(), > > fix it up to make the test compile and run again. It would only fix the compilation error, but the test would still fail. > This got fixed differently by e8c8361cfdbf ("selftests/bpf: Fix > progs/test_deny_namespace.c issues"). exactly. It's not just the macro that had to be adjusted. > I wonder what drugs made me think BIT_LL() was ok. Maybe my wife puts > something in the coffee? $ make C=3D2 kernel/bpf/core.o kernel/bpf/core.c:1822:43: error: arithmetics on pointers to functions kernel/bpf/core.c:1827:48: error: arithmetics on pointers to functions kernel/bpf/core.c:2073:77: error: subtraction of functions? Share your drug= s :)