From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6BF6C433E0 for ; Thu, 13 Aug 2020 01:09:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72FF4206DA for ; Thu, 13 Aug 2020 01:09:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="umBqOlR8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbgHMBJK (ORCPT ); Wed, 12 Aug 2020 21:09:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726126AbgHMBJJ (ORCPT ); Wed, 12 Aug 2020 21:09:09 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63EC3C061383; Wed, 12 Aug 2020 18:09:09 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id v12so4305578ljc.10; Wed, 12 Aug 2020 18:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=r99e4fgx1qPr7K6tkmxzVrj7pntaKTgmbE6RKbCCUXM=; b=umBqOlR83D9PJQMUEy369oLCGZieRkeZXLVbeRozfGKdpXH24SmMsUeALbLeyLcp6H nYhALgzhdgyke3pyzoHUEpNhPgkpnJyr2BL/F2Mi8sUplVeQOqIfJjpKXJdvjczMErP3 0c4Q8lClBHp8q4FMgBf0JBUokVtl9n5KFLpwH5D6QRvZuTgxzPwzGeXJMN1RA6Tf1o30 S812bczj14gSEWKYgMSz3U+3U5sjFlE/aSx9m8sIgMdo5KX8NRGFsKtXMsKj9pJRgd3h ueN9xMSyGWqXmkADdD1efX9jomJBij4DDEkG7WK5ZHG9OVGOZPHVy/a4O7ENpX15w7H5 5F8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=r99e4fgx1qPr7K6tkmxzVrj7pntaKTgmbE6RKbCCUXM=; b=l8tyP+1MetGpyqAdnSG+F7TEQUI1ouTwXa0X0eFutFzo4JyqgqXB74ebES/mzhOXBH irXddaqeAAm9WmEYK4MTT3YqyJ+IrBZvQ+PRdNrBtT575qGCfM71s4YfLoBO9JnZWfVq 79szWE1pX9Glut25me4m+gdHwL10q6JqApwD6z/jnPryFY7tf+U6sl2WtHspevWqm3sR kvZTHlzjvB0J0IVw7monndmtM2IjfraTSjtMoaQSCSpbsBZor/lAvt0Yho61R3RK7Xu3 Hn2AMFplEV75Eg4W32iPHS+9IugU/dG01papKxcoTGA95QAUIgnhsNBzCJzsAXQf2K/0 5GbA== X-Gm-Message-State: AOAM530+LsuvJq+gcXq03HfMre7ILu89Il5vcY9D/H/L6rjq37T5odKg OwF8JfUaRO8tx0vvzn4cjJJykUrvYRWddUCjte4= X-Google-Smtp-Source: ABdhPJz8U18qpvkxwr0EKPQZINKnRrFQvl08GZPWqfItXj9lmhmUMGNDPjH1j3NWaH7rs+uTV20W/ofwQPX1RI1Ajz4= X-Received: by 2002:a2e:a17b:: with SMTP id u27mr846869ljl.2.1597280947619; Wed, 12 Aug 2020 18:09:07 -0700 (PDT) MIME-Version: 1.0 References: <20200812022923.1217922-1-andriin@fb.com> <87imdo1ajl.fsf@toke.dk> In-Reply-To: From: Alexei Starovoitov Date: Wed, 12 Aug 2020 18:08:56 -0700 Message-ID: Subject: Re: [PATCH bpf] bpf: fix XDP FD-based attach/detach logic around XDP_FLAGS_UPDATE_IF_NOEXIST To: Stanislav Fomichev Cc: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Andrii Nakryiko , bpf , Netdev , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Kernel Team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Aug 12, 2020 at 8:48 AM Stanislav Fomichev wrote: > > On Wed, Aug 12, 2020 at 2:24 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > > > Andrii Nakryiko writes: > > > > > Enforce XDP_FLAGS_UPDATE_IF_NOEXIST only if new BPF program to be att= ached is > > > non-NULL (i.e., we are not detaching a BPF program). > > > > > > Reported-by: Stanislav Fomichev > > > Fixes: d4baa9368a5e ("bpf, xdp: Extract common XDP program attachment= logic") > > > Signed-off-by: Andrii Nakryiko > > > > Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen > That fixed it for me, thank you! > > Tested-by: Stanislav Fomichev Applied. Thanks