From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Song Liu <songliubraving@fb.com>
Cc: Andrii Nakryiko <andriin@fb.com>, bpf <bpf@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"andrii.nakryiko@gmail.com" <andrii.nakryiko@gmail.com>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH bpf] tools/bpftool: make skeleton code C++17-friendly by dropping typeof()
Date: Wed, 12 Aug 2020 18:10:53 -0700 [thread overview]
Message-ID: <CAADnVQLbhyOwGuV0+Kq-nuACC3mUVFOUU9mG+aPkUV5N-6ykDg@mail.gmail.com> (raw)
In-Reply-To: <510B2A6E-60EA-459D-A40D-9C21182C166A@fb.com>
On Wed, Aug 12, 2020 at 8:35 AM Song Liu <songliubraving@fb.com> wrote:
>
>
>
> > On Aug 11, 2020, at 7:59 PM, Andrii Nakryiko <andriin@fb.com> wrote:
> >
> > Seems like C++17 standard mode doesn't recognize typeof() anymore. This can
> > be tested by compiling test_cpp test with -std=c++17 or -std=c++1z options.
> > The use of typeof in skeleton generated code is unnecessary, all types are
> > well-known at the time of code generation, so remove all typeof()'s to make
> > skeleton code more future-proof when interacting with C++ compilers.
> >
> > Fixes: 985ead416df3 ("bpftool: Add skeleton codegen command")
> > Signed-off-by: Andrii Nakryiko <andriin@fb.com>
>
> Acked-by: Song Liu <songliubraving@fb.com>
Applied. Thanks
prev parent reply other threads:[~2020-08-13 1:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 2:59 [PATCH bpf] tools/bpftool: make skeleton code C++17-friendly by dropping typeof() Andrii Nakryiko
2020-08-12 15:34 ` Song Liu
2020-08-13 1:10 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQLbhyOwGuV0+Kq-nuACC3mUVFOUU9mG+aPkUV5N-6ykDg@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=Kernel-team@fb.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.