From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [PATCH bpf-next v2] bpftool: make libbfd optional
Date: Fri, 16 Nov 2018 20:47:45 -0800
Message-ID: <CAADnVQLoJuBsjp3CRD9TNFT0yFdiP9p=D1Mo3Yq5q48jJdEfvA@mail.gmail.com>
References: <20181112214410.14270-1-sdf@google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Network Development <netdev@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jakub Kicinski <jakub.kicinski@netronome.com>,
        Quentin Monnet <quentin.monnet@netronome.com>
To: Stanislav Fomichev <sdf@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wm1-f65.google.com ([209.85.128.65]:36197 "EHLO
        mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728478AbeKQPDV (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 17 Nov 2018 10:03:21 -0500
Received: by mail-wm1-f65.google.com with SMTP id s11so463856wmh.1
        for <netdev@vger.kernel.org>; Fri, 16 Nov 2018 20:47:57 -0800 (PST)
In-Reply-To: <20181112214410.14270-1-sdf@google.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, Nov 12, 2018 at 1:44 PM Stanislav Fomichev <sdf@google.com> wrote:
>
> Make it possible to build bpftool without libbfd. libbfd and libopcodes are
> typically provided in dev/dbg packages (binutils-dev in debian) which we
> usually don't have installed on the fleet machines and we'd like a way to have
> bpftool version that works without installing any additional packages.
> This excludes support for disassembling jit-ted code and prints an error if
> the user tries to use these features.
>
> Tested by:
> cat > FEATURES_DUMP.bpftool <<EOF
> feature-libbfd=0
> feature-disassembler-four-args=1
> feature-reallocarray=0
> feature-libelf=1
> feature-libelf-mmap=1
> feature-bpf=1
> EOF
> FEATURES_DUMP=$PWD/FEATURES_DUMP.bpftool make
> ldd bpftool | grep libbfd
>
> Signed-off-by: Stanislav Fomichev <sdf@google.com>

applied, thanks