From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F1FCC433E0 for ; Tue, 9 Mar 2021 20:39:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5306665274 for ; Tue, 9 Mar 2021 20:39:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230266AbhCIUij (ORCPT ); Tue, 9 Mar 2021 15:38:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231526AbhCIUiV (ORCPT ); Tue, 9 Mar 2021 15:38:21 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DAF2C06174A for ; Tue, 9 Mar 2021 12:38:21 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id x4so22819121lfu.7 for ; Tue, 09 Mar 2021 12:38:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lyP6j+ZtJdltq5she/GEKEy2lAs3MPhk+nX+6aH6wBc=; b=HUEzteRdiEU+qtvHPBHmVFa5eLJ1zcmRYPOdmH/putIRMnd3sQIzQtMRdF3alViL58 eq79AuZNsRPh3A/ICriQXLXHPbbWCliY0qc7TIKjft43llwZ3pMpIp4syWpKTCTQKcXQ 4A4RoO50OWofVxD7OXlAK+Lw6JN3rovza5J4xVpCPtOx3lKtCCy2pfeGlpAm8OQBrUTz kMhZX9VNKNLELlDCh4A7nIZ/0yS9IBifjRvWYaOCzvSx++QKpBTvGEG9n0nCh3n0n3a4 VdS8ANG7CDVPliGX6ZNS/x+yZA1y/+BoTYgwgoscutPWsvZWucfjihvcca5PmdmVupKB KaaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lyP6j+ZtJdltq5she/GEKEy2lAs3MPhk+nX+6aH6wBc=; b=EGrozf0i8stUPLkJ5NVx5LhWcd7yl5ARnm2Km2aO9lAjfd83KKjiUC2OPjlemthkV3 o5X6b402cN6bLY4H9c40gKSGMMXCnqMlVN9ol1DRmsienjdvqdnv+C64HF7EMgLrfGle kACH5/tfV5ljPJiDF+3QPjvxRxDtvvwygzAf22dxz4V63QQiHu4v6h0EZ0dZEG5Ld2/Z k5PEtTkloM92THWi3AAm2zYJByGAC+SFrHqAOnfooplyiRP6bXqh4mjg2l6MYH0EDVaQ 8R4Ikjqn14TozKrVF9YfaRbz+zpLB4Pxhnv7ucKcbmf0CVbuIsM363vGcBF4FXmC0zZw hz3Q== X-Gm-Message-State: AOAM532hago1yjPF+4C7mFnNtUZ2WhjgHFvuwSqkKgPpAZfiyb3E5p0Q KccFIVwenkZNTJ4E8PwCAAblRPkSf0P2O4n5xPc= X-Google-Smtp-Source: ABdhPJyya3mPL8NBQCN8AxnnuRIUj9HjN5nc7nL12e/YS9yjjqQDE05/uiqCvUtZWkHPdZBt2A47D6yv4pih9NYiDEM= X-Received: by 2002:ac2:5ec2:: with SMTP id d2mr19424098lfq.214.1615322299803; Tue, 09 Mar 2021 12:38:19 -0800 (PST) MIME-Version: 1.0 References: <20210309185028.3763817-1-yhs@fb.com> In-Reply-To: <20210309185028.3763817-1-yhs@fb.com> From: Alexei Starovoitov Date: Tue, 9 Mar 2021 12:38:08 -0800 Message-ID: Subject: Re: [PATCH bpf v2] bpf: don't do bpf_cgroup_storage_set() for kuprobe/tp programs To: Yonghong Song Cc: bpf , Alexei Starovoitov , Daniel Borkmann , Kernel Team , Roman Gushchin Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Mar 9, 2021 at 10:50 AM Yonghong Song wrote: > while ((_prog = READ_ONCE(_item->prog))) { \ > - bpf_cgroup_storage_set(_item->cgroup_storage); \ > + if (set_cg_storage) { \ > + bpf_cgroup_storage_set(_item->cgroup_storage); \ > + } \ Extra {} are unnecessary. I removed them while applying. Thanks!