From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit Date: Tue, 13 Dec 2016 18:21:16 -0800 Message-ID: References: <20161213172118.2f55c503@xeon-e3> <20161214020305.qck2bpxmfh6ltrw7@rere.qmqm.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Stephen Hemminger , "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "moderated list:ETHERNET BRIDGE" , "open list:OPENVSWITCH" To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Return-path: In-Reply-To: <20161214020305.qck2bpxmfh6ltrw7-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Errors-To: ovs-dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org List-Id: netdev.vger.kernel.org T24gVHVlLCBEZWMgMTMsIDIwMTYgYXQgNjowMyBQTSwgTWljaGHFgiBNaXJvc8WCYXcKPG1pcnEt bGludXhAcmVyZS5xbXFtLnBsPiB3cm90ZToKPiBPbiBUdWUsIERlYyAxMywgMjAxNiBhdCAwNToy MToxOFBNIC0wODAwLCBTdGVwaGVuIEhlbW1pbmdlciB3cm90ZToKPj4gT24gU2F0LCAgMyBEZWMg MjAxNiAxMDoyMjoyOCArMDEwMCAoQ0VUKQo+PiBNaWNoYcWCIE1pcm9zxYJhdyA8bWlycS1saW51 eEByZXJlLnFtcW0ucGw+IHdyb3RlOgo+PiA+IFRoaXMgQWxsLWluLW9uZSBwYXRjaCByZW1vdmVz IGFidXNlIG9mIFZMQU4gQ0ZJIGJpdCwgc28gaXQgY2FuIGJlIHBhc3NlZAo+PiA+IGludGFjdCB0 aHJvdWdoIGxpbnV4IG5ldHdvcmtpbmcgc3RhY2suCj4+ID4KPj4gPiBTaWduZWQtb2ZmLWJ5OiBN aWNoYcWCIE1pcm9zxYJhdyA8bWljaGFsLm1pcm9zbGF3QGF0ZW5kZXNvZnR3YXJlLnBsPgo+PiA+ IC0tLQo+PiA+Cj4+ID4gRGVhciBOZXREZXZzCj4+ID4KPj4gPiBJIGd1ZXNzIHRoaXMgbmVlZHMg dG8gYmUgc3BsaXQgdG8gdGhlIHByZXAuLmNvbnZlcnRbXS4uZmluaXNoIHNlcXVlbmNlLAo+PiA+ IGJ1dCBpZiB5b3UgbGlrZSBpdCBhcyBpcywgdGhlbiBpdCdzIHJlYWR5Lgo+PiA+Cj4+ID4gVGhl IGJpZ2dlc3QgcXVlc3Rpb24gaXMgaWYgdGhlIG1vZGlmaWVkIGludGVyZmFjZSBhbmQgdmxhbl9w cmVzZW50Cj4+ID4gaXMgdGhlIHdheSB0byBnby4gVGhpcyBjYW4gYmUgY2hhbmdlZCB0byB1c2Ug dmxhbl9wcm90byAhPSAwIGluc3RlYWQKPj4gPiBvZiBhbiBleHRyYSBmbGFnIGJpdC4KPj4gPgo+ PiA+IEFzIEkgY2FuJ3QgdGVzdCBtb3N0IG9mIHRoZSBkcml2ZXIgY2hhbmdlcywgcGxlYXNlIGxv b2sgYXQgdGhlbSBjYXJlZnVsbHkuCj4+ID4gT1ZTIGFuZCBicmlkZ2UgZXllcyBhcmUgZXNwZWNp YWxseSB3ZWxjb21lLgo+PiA+Cj4+ID4gQmVzdCBSZWdhcmRzLAo+PiA+IE1pY2hhxYIgTWlyb3PF gmF3Cj4+IElzIHRoZSBtb3RpdmF0aW9uIHRvIHN1cHBvcnQgODAyLjFhZCBEcm9wIEVsaWdhYmls aXR5IEluZGljYXRvciAoREVJKT8KPj4KPj4gSWYgc28gdGhlbiB5b3UgbmVlZCB0byBiZSBtb3Jl IHZlcmJvc2UgaW4gdGhlIGNvbW1pdCBsb2csIGFuZCBsb3RzIG1vcmUKPj4gd29yayBpcyBuZWVk ZWQuIFlvdSBuZWVkIHRvIHJlbmFtZSBmaWVsZHMgYW5kIHZhbGlkYXRlIGV2ZXJ5IHBsYWNlIGEK Pj4gZHJpdmVyIGlzIHVzaW5nIERFSSBiaXQgdG8gbWFrZSBzdXJlIGl0IHJlYWxseSBkb2VzIHRo ZSByaWdodCB0aGluZwo+PiBvbiB0aGF0IGhhcmR3YXJlLiBJdCBpcyBub3QganVzdCBhIG1lY2hh bmljYWwgY2hhbmdlLgo+Cj4gTXkgbWFpbiBtb3RpdmF0aW9uIGlzIHRvIGJlIGFibGUgdG8gc2Vl IHRoZSBiaXQgaW50YWN0IGluIHRjcGR1bXAgYW5kIGJlCj4gYWJsZSB0byBwYXNzIGl0IHVudG91 Y2hlZCB0aHJvdWdoIGF0IGxlYXN0IGEgdmV0aCBwYWlyLiBJdCB3b3VsZCBiZSBncmVhdAo+IGlm IGFsbCBkZXZpY2VzIGRpZG4ndCBkbyBzb21ldGhpbmcgc3R1cGlkIHdpdGggdGhlIGJpdCwgYnV0 IGl0J3Mgbm90Cj4gc29tZXRoaW5nIEkgYW0gYWJsZSB0byBtYWtlIGhhcHBlbi4KCmltbyAiYmUg YWJsZSB0byBwYXNzIHVudG91Y2hlZCB0aHJvdWdoIHZldGgiIGlzIG5vdCBnb29kIGVub3VnaApq dXN0aWZpY2F0aW9uIGZvciBzdWNoIGludmFzaXZlIHBhdGNoZXMuCkknbSBzdGlsbCBub3Qgc3Vy ZSB0aGF0IGFsbCBvZiB0aGVzZSBjaGFuZ2VzIGRvbid0IGFmZmVjdCB1c2VyIHNwYWNlLgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXYgbWFpbGluZyBs aXN0CmRldkBvcGVudnN3aXRjaC5vcmcKaHR0cHM6Ly9tYWlsLm9wZW52c3dpdGNoLm9yZy9tYWls bWFuL2xpc3RpbmZvL292cy1kZXYK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=mCzejHZ/2yoVlMhkGz9SwyfxiYSaJxx70hl775sv1Cs=; b=S7hiDPGiryCtefqeKBfvU0DsPQoMVSBHqYjlLofdZDR32Z+8lh3dWXAbkCHktq48ur qJVK1fMP04ZIhZbBRkN7phx+l+oA/dmpnRot/7nyA93Edp1l7u01jNKO+E/lAbJZkWWb 2rFmcJ5bLxkZHgDBD3fOd2Y3obMigAG0DgavUr8VjKLQWUpUt7ke4wNEPTBkkyI+t2Q1 oO1K5M7ZQJJcCkREUzfJd+AkE3JGElsLWDCTucJ+LG1oX+Qr+3ezDtLGK+SfryNd42RG 78IjUsYkAKEfOBWlTU+/U1lmgoykc1ya3Ms3A8ShJI7Yb3muZBc/LTrCF0ocSahf1+9b likA== MIME-Version: 1.0 In-Reply-To: <20161214020305.qck2bpxmfh6ltrw7@rere.qmqm.pl> References: <20161213172118.2f55c503@xeon-e3> <20161214020305.qck2bpxmfh6ltrw7@rere.qmqm.pl> From: Alexei Starovoitov Date: Tue, 13 Dec 2016 18:21:16 -0800 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Bridge] [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: "netdev@vger.kernel.org" , "moderated list:ETHERNET BRIDGE" , "open list:OPENVSWITCH" On Tue, Dec 13, 2016 at 6:03 PM, Micha=C5=82 Miros=C5=82aw wrote: > On Tue, Dec 13, 2016 at 05:21:18PM -0800, Stephen Hemminger wrote: >> On Sat, 3 Dec 2016 10:22:28 +0100 (CET) >> Micha=C5=82 Miros=C5=82aw wrote: >> > This All-in-one patch removes abuse of VLAN CFI bit, so it can be pass= ed >> > intact through linux networking stack. >> > >> > Signed-off-by: Micha=C5=82 Miros=C5=82aw >> > --- >> > >> > Dear NetDevs >> > >> > I guess this needs to be split to the prep..convert[]..finish sequence= , >> > but if you like it as is, then it's ready. >> > >> > The biggest question is if the modified interface and vlan_present >> > is the way to go. This can be changed to use vlan_proto !=3D 0 instead >> > of an extra flag bit. >> > >> > As I can't test most of the driver changes, please look at them carefu= lly. >> > OVS and bridge eyes are especially welcome. >> > >> > Best Regards, >> > Micha=C5=82 Miros=C5=82aw >> Is the motivation to support 802.1ad Drop Eligability Indicator (DEI)? >> >> If so then you need to be more verbose in the commit log, and lots more >> work is needed. You need to rename fields and validate every place a >> driver is using DEI bit to make sure it really does the right thing >> on that hardware. It is not just a mechanical change. > > My main motivation is to be able to see the bit intact in tcpdump and be > able to pass it untouched through at least a veth pair. It would be great > if all devices didn't do something stupid with the bit, but it's not > something I am able to make happen. imo "be able to pass untouched through veth" is not good enough justification for such invasive patches. I'm still not sure that all of these changes don't affect user space.