From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Date: Mon, 11 Mar 2019 21:15:55 +0000 Subject: Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems Message-Id: List-Id: References: <20190309214852.12233-1-dante.paz@gmail.com> <20190311162527.GA20652@ravnborg.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: DANTE JAVIER PAZ Cc: devel@driverdev.osuosl.org, leobras.c@gmail.com, linux-fbdev@vger.kernel.org, nishadkamdar@gmail.com, Greg KH , Dante Paz , dri-devel , renatoys08@gmail.com, Sam Ravnborg Hi everyone, Dante: please avoid top-posting. In other words, put your replies in-line, like I'm gonna do now. See below (and see how discussion goes on other thre= ads). On Mon, 11 Mar 2019 at 17:34, DANTE JAVIER PAZ wrote: > > Hello Sam, thank you very much for your comments, > As I told Dan (my email did not reach the mailing list) this is my > first attempt to contribute, > So I'm learning a lot from your advice and corrections. > > I will look for TODO lists to see if there are more useful > contributions to make, all suggestions are also welcome. > > Thanks again for the patience of all of you. > Best, > Dante > > > El lun., 11 mar. 2019 a las 13:25, Sam Ravnborg () escr= ibi=C3=B3: > > > > Hi Dante > > > > Thanks for the patch. > > On Sat, Mar 09, 2019 at 06:48:52PM -0300, Dante Paz wrote: > > > From: Dante Paz > > > > > > Style and coding function issues were corrected, by avoiding macr= o functions with a conflicting coding style. > > > Signed-off-by: Dante Paz > > > > But it raised a few comments. > > > > The staging/fbtft is a dumping of a set of drivers that > > in the end will be migrated to DRM. > > And there is not much gained trying to do coding style changes to these > > drivers. > > So please conmsider finding a drver where this is more relevant. > > Sam, Why is this driver still here? I thought we migrated everyhing to tinydrm already. Maybe there's a list of panels still not migrated? Thanks, Eze From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems Date: Mon, 11 Mar 2019 18:15:55 -0300 Message-ID: References: <20190309214852.12233-1-dante.paz@gmail.com> <20190311162527.GA20652@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-vs1-xe42.google.com (mail-vs1-xe42.google.com [IPv6:2607:f8b0:4864:20::e42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5BAE98912D for ; Mon, 11 Mar 2019 21:16:07 +0000 (UTC) Received: by mail-vs1-xe42.google.com with SMTP id y19so305895vsc.4 for ; Mon, 11 Mar 2019 14:16:07 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: DANTE JAVIER PAZ Cc: devel@driverdev.osuosl.org, leobras.c@gmail.com, linux-fbdev@vger.kernel.org, nishadkamdar@gmail.com, Greg KH , Dante Paz , dri-devel , renatoys08@gmail.com, Sam Ravnborg List-Id: dri-devel@lists.freedesktop.org SGkgZXZlcnlvbmUsCgpEYW50ZTogcGxlYXNlIGF2b2lkIHRvcC1wb3N0aW5nLiBJbiBvdGhlciB3 b3JkcywgcHV0IHlvdXIgcmVwbGllcyBpbi1saW5lLApsaWtlIEknbSBnb25uYSBkbyBub3cuIFNl ZSBiZWxvdyAoYW5kIHNlZSBob3cgZGlzY3Vzc2lvbiBnb2VzIG9uIG90aGVyIHRocmVhZHMpLgoK T24gTW9uLCAxMSBNYXIgMjAxOSBhdCAxNzozNCwgREFOVEUgSkFWSUVSIFBBWiA8ZHBhekB1bmMu ZWR1LmFyPiB3cm90ZToKPgo+IEhlbGxvIFNhbSwgdGhhbmsgeW91IHZlcnkgbXVjaCBmb3IgeW91 ciBjb21tZW50cywKPiBBcyBJIHRvbGQgRGFuIChteSBlbWFpbCBkaWQgbm90IHJlYWNoIHRoZSBt YWlsaW5nIGxpc3QpIHRoaXMgaXMgbXkKPiBmaXJzdCBhdHRlbXB0IHRvIGNvbnRyaWJ1dGUsCj4g U28gSSdtIGxlYXJuaW5nIGEgbG90IGZyb20geW91ciBhZHZpY2UgYW5kIGNvcnJlY3Rpb25zLgo+ Cj4gSSB3aWxsIGxvb2sgZm9yIFRPRE8gbGlzdHMgdG8gc2VlIGlmIHRoZXJlIGFyZSBtb3JlIHVz ZWZ1bAo+IGNvbnRyaWJ1dGlvbnMgdG8gbWFrZSwgYWxsIHN1Z2dlc3Rpb25zIGFyZSBhbHNvIHdl bGNvbWUuCj4KPiBUaGFua3MgYWdhaW4gZm9yIHRoZSBwYXRpZW5jZSBvZiBhbGwgb2YgeW91Lgo+ IEJlc3QsCj4gRGFudGUKPgo+Cj4gRWwgbHVuLiwgMTEgbWFyLiAyMDE5IGEgbGFzIDEzOjI1LCBT YW0gUmF2bmJvcmcgKDxzYW1AcmF2bmJvcmcub3JnPikgZXNjcmliacOzOgo+ID4KPiA+IEhpIERh bnRlCj4gPgo+ID4gVGhhbmtzIGZvciB0aGUgcGF0Y2guCj4gPiBPbiBTYXQsIE1hciAwOSwgMjAx OSBhdCAwNjo0ODo1MlBNIC0wMzAwLCBEYW50ZSBQYXogd3JvdGU6Cj4gPiA+IEZyb206IERhbnRl IFBheiA8ZHBhekB1bmMuZWR1LmFyPgo+ID4gPgo+ID4gPiAgICAgU3R5bGUgYW5kIGNvZGluZyBm dW5jdGlvbiBpc3N1ZXMgd2VyZSBjb3JyZWN0ZWQsIGJ5IGF2b2lkaW5nIG1hY3JvIGZ1bmN0aW9u cyB3aXRoIGEgY29uZmxpY3RpbmcgY29kaW5nIHN0eWxlLgo+ID4gPiAgICAgU2lnbmVkLW9mZi1i eTogRGFudGUgUGF6IDxkcGF6QHVuYy5lZHUuYXI+Cj4gPgo+ID4gQnV0IGl0IHJhaXNlZCBhIGZl dyBjb21tZW50cy4KPiA+Cj4gPiBUaGUgc3RhZ2luZy9mYnRmdCBpcyBhIGR1bXBpbmcgb2YgYSBz ZXQgb2YgZHJpdmVycyB0aGF0Cj4gPiBpbiB0aGUgZW5kIHdpbGwgYmUgbWlncmF0ZWQgdG8gRFJN Lgo+ID4gQW5kIHRoZXJlIGlzIG5vdCBtdWNoIGdhaW5lZCB0cnlpbmcgdG8gZG8gY29kaW5nIHN0 eWxlIGNoYW5nZXMgdG8gdGhlc2UKPiA+IGRyaXZlcnMuCj4gPiBTbyBwbGVhc2UgY29ubXNpZGVy IGZpbmRpbmcgYSBkcnZlciB3aGVyZSB0aGlzIGlzIG1vcmUgcmVsZXZhbnQuCj4gPgoKU2FtLAoK V2h5IGlzIHRoaXMgZHJpdmVyIHN0aWxsIGhlcmU/IEkgdGhvdWdodCB3ZSBtaWdyYXRlZCBldmVy eWhpbmcgdG8KdGlueWRybSBhbHJlYWR5LgoKTWF5YmUgdGhlcmUncyBhIGxpc3Qgb2YgcGFuZWxz IHN0aWxsIG5vdCBtaWdyYXRlZD8KClRoYW5rcywKRXplCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==