From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BA362CA1 for ; Fri, 10 Dec 2021 18:33:08 +0000 (UTC) Received: by mail-ed1-f48.google.com with SMTP id o20so33083499eds.10 for ; Fri, 10 Dec 2021 10:33:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R+5wfzvY98r911pdlNHS5MRZhjqkHPF9SqDy5RQ+nGs=; b=0FrAeyHRpiQDLNRCH38LGYEW5OlercFk3DROOyI+5MF4Aiw8BvLF+GCTJpv3NKxJy8 w6XzrFa0A4VvMMlEU5z/Z298tMnaEJKBq6VeGIjX+thf/iO5KbDMg1BG2s0ux0pQV0XL L0w0pukiLEDpC5eKc8vPyhFf4+3+6sceGamqAVhs5Kn+fhrwpRXew7EnfGZfjV1KOpOo GsbDXtupxwNXVLa7onRj0aOr7ByIMeeLVr8b9i5Ih2ez3BMkuu+Noz8qQcPqLFM956T3 mU1cLd9j/5Aeb5XROTdKgsLG6YeZUnyInnb8MjJCX3TEKg+E78spgZbNmQA8jGbD++MV Xm+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R+5wfzvY98r911pdlNHS5MRZhjqkHPF9SqDy5RQ+nGs=; b=x6x2rHOeuAi+iH14qEUKkEvd/lcgQutlB18lpumOdORcL3mg236Tet3oDxdrA18tSP v3G2K4XfPFaau8i5rf2QUzZG+bgdv+uBWoovasMNnbtdRCZqKr5mIWXkdfy96EougkHn qh9tBJn9LdI59/+pgWazzEMFL9+8Ze27rQwAsI64LxMsb6Yva1UqYAnloV/0NhV/LWV4 Ylq3aTnp0ahFg0kks+BUxTAOx8ypccVE1Ziv8lr18X+dXkVQjcqpkKrhrK0Eh3t2CyG0 sL5nfIG82GfV944AazjgwI3R4w2BWNdxjvIISy+mksrBy3CPG615T8ccjpPKh2xvczCG hf7Q== X-Gm-Message-State: AOAM5305kYkJivx2gywewC0lMQ/7/+d+vXx5K/WKp/ZTcowU+0m8IFq5 aKHozwjw3+twVfahe/snkJNtP2mWzygTnSXhoUopWg== X-Google-Smtp-Source: ABdhPJw2lS/O2yAfLVTw6WVq78ELyMdt5/AEs5anuvPRPowAgkoa3NmZtsHE2c0DEj0r6fuPtxiB7KX0gypvQotrn6Q= X-Received: by 2002:aa7:c30e:: with SMTP id l14mr40506518edq.370.1639161186439; Fri, 10 Dec 2021 10:33:06 -0800 (PST) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20211208225030.2018923-1-aford173@gmail.com> <20211208225030.2018923-5-aford173@gmail.com> In-Reply-To: From: Ezequiel Garcia Date: Fri, 10 Dec 2021 15:32:54 -0300 Message-ID: Subject: Re: [PATCH 04/10] dt-bindings: media: nxp,imx8mq-vpu: Support split G1 and G2 nodes with vpu-blk-ctrl To: Adam Ford Cc: Lucas Stach , Rob Herring , linux-media , Benjamin Gaignard , Chris Healy , Adam Ford-BE , Nicolas Dufresne , Philipp Zabel , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Greg Kroah-Hartman , "open list:HANTRO VPU CODEC DRIVER" , devicetree , arm-soc , Linux Kernel Mailing List , "open list:STAGING SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" > > > > I'm in favor of dropping the old binding from the schema. New DTs > > should clearly use the new binding and old DTs shouldn't change > > anymore, so validation is less useful there. > > I wonder if it makes sense to have a more standardized hantro schema > for all the users instead of one dedicated to each platform using a > hantro driver. The unified schema could have all the various > compatible flags so the driver still knows which features are > enabled/disabled and it's very clear who all the users are for it. I > would think it could cover both the encoder and decoder variants as > well. We do something similar for 8250 serial ports. > > If so, can someone from the media group suggest the best one to > follow? Ezequiel suggested I look at the sama5d4-vdec to help reduce > some clutter in the driver. If that binding is good enough, should I > just add the compatible flags to that and potentially rename it. > A unified schema might sound elegant and compelling, but I suspect it can bite us down the road, due to differences in the platform integration. Seems we are all on-board going forward with a patch similar to this one, but also dropping the deprecated binding from the schema (while of course still supporting old DTBs on new kernels). Rob's suggestion about having a warning in the platform if the binding has not been updated, sounds like very useful too. Keep in mind v5.16-rc5 is near, which means we still have a few weeks to discuss this patch, until the next linux-media merge season. Thanks, Ezequiel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16423C433EF for ; Fri, 10 Dec 2021 18:33:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D/EuJ/oTaqcC7uIMHdQFbjSvk97R8DoX9PbHQ0Qlg6U=; b=i8dOY+wqnS5/Nq UeIz2X/OvTKCQp7rWI3qoyRMhXvWB3njCirMAxWqUI1GgXEh64o5ONdEzj5e7AtUMpMW08kApN4EO rRskY33wSpwEVo/7KC32G4ynk17zSFNH5bMS4sxvyubAFmztPGSPt7Gb6RXRJEQ3eaWsCfV9xwFC5 2Ln9ccqIPD/rUf5oT36eXCTTSW+PsL5p01OuPkmYxgEt7vSYQq2I6kcI6TI1Bq9Zq7iXIKtiEY0BH kAxhT3sxXqGcgZ1JnXfapm118jyNRFMJfGSP7RFMIM+pZBa/cLRHVT4UfBOocD4lmPyTHp1e27DAw UcncUbM5UYd6agscaE/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvkhj-003DML-HJ; Fri, 10 Dec 2021 18:33:11 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvkhg-003DKu-TL for linux-rockchip@lists.infradead.org; Fri, 10 Dec 2021 18:33:10 +0000 Received: by mail-ed1-x52e.google.com with SMTP id x15so33480969edv.1 for ; Fri, 10 Dec 2021 10:33:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R+5wfzvY98r911pdlNHS5MRZhjqkHPF9SqDy5RQ+nGs=; b=0FrAeyHRpiQDLNRCH38LGYEW5OlercFk3DROOyI+5MF4Aiw8BvLF+GCTJpv3NKxJy8 w6XzrFa0A4VvMMlEU5z/Z298tMnaEJKBq6VeGIjX+thf/iO5KbDMg1BG2s0ux0pQV0XL L0w0pukiLEDpC5eKc8vPyhFf4+3+6sceGamqAVhs5Kn+fhrwpRXew7EnfGZfjV1KOpOo GsbDXtupxwNXVLa7onRj0aOr7ByIMeeLVr8b9i5Ih2ez3BMkuu+Noz8qQcPqLFM956T3 mU1cLd9j/5Aeb5XROTdKgsLG6YeZUnyInnb8MjJCX3TEKg+E78spgZbNmQA8jGbD++MV Xm+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R+5wfzvY98r911pdlNHS5MRZhjqkHPF9SqDy5RQ+nGs=; b=N9Gv86ZD2ckqAILBuyuJNy9RJS+GSNpBjFy3hQ/Tv3y+lNVH+qYgdQOhCy7H6MclA7 6ZlF/YBSsae6Wk0Qy0p5pn9RlRBvmkA6jPyZ+r/bGJIXw78K/E21gAbOBEO8EqJWKYGB uArcXYpqX9f9cUk0ZwtJJ+osxcKJILamYMQeQ5yPxfM07KyrcbnQCluMMpUVf4u47oYJ BGeybobBEEhwEZTBAfY/KaUQ8Yx8nb2F+RdOUAzr7fNoG0R8h+jQWqdqoSByB4XbeGCo SeCgA+odtRgyC4S4DATU9dHfzwcSTTAfjULtUDDCoUhuujQLH5mBsVKPJepQtI+83KLy lLnw== X-Gm-Message-State: AOAM530H27JWNVB/mU9y22PlZRbTpp9yy9nuY8NIpQmNUm+5E355D+VQ ea8nfoy8gMG7flSMY/h4pKIlet0D6hVjbZsaNCAFtA== X-Google-Smtp-Source: ABdhPJw2lS/O2yAfLVTw6WVq78ELyMdt5/AEs5anuvPRPowAgkoa3NmZtsHE2c0DEj0r6fuPtxiB7KX0gypvQotrn6Q= X-Received: by 2002:aa7:c30e:: with SMTP id l14mr40506518edq.370.1639161186439; Fri, 10 Dec 2021 10:33:06 -0800 (PST) MIME-Version: 1.0 References: <20211208225030.2018923-1-aford173@gmail.com> <20211208225030.2018923-5-aford173@gmail.com> In-Reply-To: From: Ezequiel Garcia Date: Fri, 10 Dec 2021 15:32:54 -0300 Message-ID: Subject: Re: [PATCH 04/10] dt-bindings: media: nxp,imx8mq-vpu: Support split G1 and G2 nodes with vpu-blk-ctrl To: Adam Ford Cc: Lucas Stach , Rob Herring , linux-media , Benjamin Gaignard , Chris Healy , Adam Ford-BE , Nicolas Dufresne , Philipp Zabel , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Greg Kroah-Hartman , "open list:HANTRO VPU CODEC DRIVER" , devicetree , arm-soc , Linux Kernel Mailing List , "open list:STAGING SUBSYSTEM" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211210_103309_185402_06D01633 X-CRM114-Status: GOOD ( 19.97 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org > > > > I'm in favor of dropping the old binding from the schema. New DTs > > should clearly use the new binding and old DTs shouldn't change > > anymore, so validation is less useful there. > > I wonder if it makes sense to have a more standardized hantro schema > for all the users instead of one dedicated to each platform using a > hantro driver. The unified schema could have all the various > compatible flags so the driver still knows which features are > enabled/disabled and it's very clear who all the users are for it. I > would think it could cover both the encoder and decoder variants as > well. We do something similar for 8250 serial ports. > > If so, can someone from the media group suggest the best one to > follow? Ezequiel suggested I look at the sama5d4-vdec to help reduce > some clutter in the driver. If that binding is good enough, should I > just add the compatible flags to that and potentially rename it. > A unified schema might sound elegant and compelling, but I suspect it can bite us down the road, due to differences in the platform integration. Seems we are all on-board going forward with a patch similar to this one, but also dropping the deprecated binding from the schema (while of course still supporting old DTBs on new kernels). Rob's suggestion about having a warning in the platform if the binding has not been updated, sounds like very useful too. Keep in mind v5.16-rc5 is near, which means we still have a few weeks to discuss this patch, until the next linux-media merge season. Thanks, Ezequiel _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D00BCC433EF for ; Fri, 10 Dec 2021 18:34:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T3RYtcFJFUc7zsmSpHIDPW4vXEKTHNAk7ME6lZKPMuo=; b=SHWqko/uqUBvxo zGceLv63owrN1sOQlX09Noc5YPQC2lHq9WeybLhGWUis0iD/G+PCSEB5yZ8pnwId9QUlXKVjQUsxB TY2GNNdENAyWfYjTeWvKzfNLM/u0L1xPPB+Fb8IiA/q+5KU9ute/ahm1jdqhabab5TFUjF3sPkW6t OVUP9PffchW9As2i7d/dDPs80rkDPrL74mYgArDxr1U5CHffTPFqNdt9FLeMjTb4tXhhENExXBWPo Szf0Iq5JCKA6YG52PWtH3ysmmmcG6oLhzA6t2z2Uvs2D8DSFfCq+yhxuIBx/E3fbFfHL7EvWSEWbP gM9vDraD7XMQtPB0XifA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvkhl-003DMS-2n; Fri, 10 Dec 2021 18:33:13 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvkhg-003DKx-TX for linux-arm-kernel@lists.infradead.org; Fri, 10 Dec 2021 18:33:10 +0000 Received: by mail-ed1-x52e.google.com with SMTP id r25so32205527edq.7 for ; Fri, 10 Dec 2021 10:33:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R+5wfzvY98r911pdlNHS5MRZhjqkHPF9SqDy5RQ+nGs=; b=0FrAeyHRpiQDLNRCH38LGYEW5OlercFk3DROOyI+5MF4Aiw8BvLF+GCTJpv3NKxJy8 w6XzrFa0A4VvMMlEU5z/Z298tMnaEJKBq6VeGIjX+thf/iO5KbDMg1BG2s0ux0pQV0XL L0w0pukiLEDpC5eKc8vPyhFf4+3+6sceGamqAVhs5Kn+fhrwpRXew7EnfGZfjV1KOpOo GsbDXtupxwNXVLa7onRj0aOr7ByIMeeLVr8b9i5Ih2ez3BMkuu+Noz8qQcPqLFM956T3 mU1cLd9j/5Aeb5XROTdKgsLG6YeZUnyInnb8MjJCX3TEKg+E78spgZbNmQA8jGbD++MV Xm+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R+5wfzvY98r911pdlNHS5MRZhjqkHPF9SqDy5RQ+nGs=; b=u0gyAbDAoi8OlWQtYDq4W9+ehfW8k0tY3x7h96aruLw4couEX2mJoyBh/JysVPG2iY NRi2Vc+09rCIUL6iwNk5wFuKYmYwlJFmaKru0Kq/mJwtGGD54Us8yrEMO8DkB5Y8mba1 0pUCGVwoNIbYldOatX9AgvxNK2DirPJH9FK/Io891ofpBBTvzpT4W+o26KDAfKmEydoI /gs2zQThCcbkoyik5bZ4zPhddcA4HizBeZFSiivFQNVragfT2aFJmCphLg+6mnx02orX bsrEKVxg2CoiKuO/TjZkpqCyc1QnHF000iG5BDstzo1Ood5H5TjIrmviVDf3jb+sp8d4 CgnQ== X-Gm-Message-State: AOAM53388f4pVQjuy8fBAJhxNfWvAu8qguYyZkh5kFd5qqo4Q0uWUkvB qx37VSY5ZkqgNt7z0ZrE4gbnv0tj+q735aRnxvuN4Q== X-Google-Smtp-Source: ABdhPJw2lS/O2yAfLVTw6WVq78ELyMdt5/AEs5anuvPRPowAgkoa3NmZtsHE2c0DEj0r6fuPtxiB7KX0gypvQotrn6Q= X-Received: by 2002:aa7:c30e:: with SMTP id l14mr40506518edq.370.1639161186439; Fri, 10 Dec 2021 10:33:06 -0800 (PST) MIME-Version: 1.0 References: <20211208225030.2018923-1-aford173@gmail.com> <20211208225030.2018923-5-aford173@gmail.com> In-Reply-To: From: Ezequiel Garcia Date: Fri, 10 Dec 2021 15:32:54 -0300 Message-ID: Subject: Re: [PATCH 04/10] dt-bindings: media: nxp,imx8mq-vpu: Support split G1 and G2 nodes with vpu-blk-ctrl To: Adam Ford Cc: Lucas Stach , Rob Herring , linux-media , Benjamin Gaignard , Chris Healy , Adam Ford-BE , Nicolas Dufresne , Philipp Zabel , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Greg Kroah-Hartman , "open list:HANTRO VPU CODEC DRIVER" , devicetree , arm-soc , Linux Kernel Mailing List , "open list:STAGING SUBSYSTEM" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211210_103309_192366_71DB6559 X-CRM114-Status: GOOD ( 21.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > > > I'm in favor of dropping the old binding from the schema. New DTs > > should clearly use the new binding and old DTs shouldn't change > > anymore, so validation is less useful there. > > I wonder if it makes sense to have a more standardized hantro schema > for all the users instead of one dedicated to each platform using a > hantro driver. The unified schema could have all the various > compatible flags so the driver still knows which features are > enabled/disabled and it's very clear who all the users are for it. I > would think it could cover both the encoder and decoder variants as > well. We do something similar for 8250 serial ports. > > If so, can someone from the media group suggest the best one to > follow? Ezequiel suggested I look at the sama5d4-vdec to help reduce > some clutter in the driver. If that binding is good enough, should I > just add the compatible flags to that and potentially rename it. > A unified schema might sound elegant and compelling, but I suspect it can bite us down the road, due to differences in the platform integration. Seems we are all on-board going forward with a patch similar to this one, but also dropping the deprecated binding from the schema (while of course still supporting old DTBs on new kernels). Rob's suggestion about having a warning in the platform if the binding has not been updated, sounds like very useful too. Keep in mind v5.16-rc5 is near, which means we still have a few weeks to discuss this patch, until the next linux-media merge season. Thanks, Ezequiel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel