All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [media] tw686x: add a missing newline when printing parameter 'dma_mode'
@ 2020-05-11  8:43 Xiongfeng Wang
  2020-05-13 19:32 ` Ezequiel Garcia
  0 siblings, 1 reply; 4+ messages in thread
From: Xiongfeng Wang @ 2020-05-11  8:43 UTC (permalink / raw)
  To: ezequiel, mchehab; +Cc: linux-media, linux-kernel, wangxiongfeng2

When I cat module parameter 'dma_mode' by sysfs, it displays as follows.
It is better to add a newline for easy reading.

[root@hulk-202 ~]# cat /sys/module/tw686x/parameters/dma_mode
memcpy[root@hulk-202 ~]#

Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
---
 drivers/media/pci/tw686x/tw686x-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/pci/tw686x/tw686x-core.c b/drivers/media/pci/tw686x/tw686x-core.c
index 74ae4f0..bfc61da 100644
--- a/drivers/media/pci/tw686x/tw686x-core.c
+++ b/drivers/media/pci/tw686x/tw686x-core.c
@@ -71,7 +71,7 @@ static const char *dma_mode_name(unsigned int mode)
 
 static int tw686x_dma_mode_get(char *buffer, const struct kernel_param *kp)
 {
-	return sprintf(buffer, "%s", dma_mode_name(dma_mode));
+	return sprintf(buffer, "%s\n", dma_mode_name(dma_mode));
 }
 
 static int tw686x_dma_mode_set(const char *val, const struct kernel_param *kp)
-- 
1.7.12.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-14 12:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-11  8:43 [PATCH] [media] tw686x: add a missing newline when printing parameter 'dma_mode' Xiongfeng Wang
2020-05-13 19:32 ` Ezequiel Garcia
2020-05-14  1:32   ` Xiongfeng Wang
2020-05-14 12:54     ` Ezequiel Garcia

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.