From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7992BC433E0 for ; Thu, 14 May 2020 12:54:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A7F220727 for ; Thu, 14 May 2020 12:54:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=vanguardiasur-com-ar.20150623.gappssmtp.com header.i=@vanguardiasur-com-ar.20150623.gappssmtp.com header.b="s8j+sgJ6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726707AbgENMy2 (ORCPT ); Thu, 14 May 2020 08:54:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725955AbgENMy2 (ORCPT ); Thu, 14 May 2020 08:54:28 -0400 Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1561C061A0E for ; Thu, 14 May 2020 05:54:27 -0700 (PDT) Received: by mail-ej1-x642.google.com with SMTP id yc10so2656160ejb.12 for ; Thu, 14 May 2020 05:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fjip1Ie1htf9qxDq8PCAKqJG1NaLpqgyInPG5lEcjjg=; b=s8j+sgJ6VjR22Fhk0hmQnYiI52B9LgCrmNqp/umlpWvHENy9Oq4RIOO2LNU9//ScHp Jb65xAd2K6Tzz9RZEmY0zr+grD2ZBPGhMRGxJwYl/2iruqAHnF9bQClTGLkjKLh4BoiW 7xOD1/BOSbpjAYVkS8kNx/XXtgVhMQ4tipFy7E4CmWOHFHzlKcK5mXuq1X9a0nr/1Bsj 4XWSneNtstIuLpZqYN/7+J5/NiCjPFmqGBtLlPjQF3GpEMeETzIdHDO132MEjN899nnh xMLkJTrKgRqhFZdTIMn6UyJpPTaisk6Fiv3JpDKAdaY1OsUZjrZ6zmMw7mZFd/TNB4WQ K/7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fjip1Ie1htf9qxDq8PCAKqJG1NaLpqgyInPG5lEcjjg=; b=SlNc869jg1BpevYGLbN5pG/UPuS5S1gh8bzAl65R3kll2eOkB+UbIV3tdaIFY02MRw 4woKl6bLIjKAP8ki6rXKnHgnljmvx5blKdeSCPxVqmxmAjSk31Hkp7GNlw+lyxtWI0ca cy6Y50KsNEBYa2C8lLN033l2nw4pPJh6M4DslA6Uze2WQBQ+udlGTWDnDUVheMCXiEfv TnZAt4G0cSZzvf2aqaa5WV3NVaJGtOhR3Vdo/6JW2iI0NhqOhctzZDaW+FwetEYUK2sB 9Flsl6o2aAoTdgcH1OUp6mItUDBL4Joj/6h6EjR21EOqFgFE1hRExMqR7Quk6bQk9uF6 4t1Q== X-Gm-Message-State: AOAM532jPI1jZyfH/EN7AojxVOkqdhDKfuy5PZjjuS9X0RVW9zKqqimM UAQltQMPlvdCahIfQkHfFb79KSzqGdGT4Y2HiC7pJdlJ X-Google-Smtp-Source: ABdhPJwyK75E3zgY3ai+dbAXBTla0/niGFZdQptXrtrQo8yu9wj/ixxYRWOqkFmu+4YypqvLYsbQbHt+3lz4tNXGjjo= X-Received: by 2002:a17:906:390a:: with SMTP id f10mr3647685eje.74.1589460866379; Thu, 14 May 2020 05:54:26 -0700 (PDT) MIME-Version: 1.0 References: <1589186626-17243-1-git-send-email-wangxiongfeng2@huawei.com> In-Reply-To: From: Ezequiel Garcia Date: Thu, 14 May 2020 09:54:15 -0300 Message-ID: Subject: Re: [PATCH] [media] tw686x: add a missing newline when printing parameter 'dma_mode' To: Xiongfeng Wang Cc: Mauro Carvalho Chehab , linux-media , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 May 2020 at 22:32, Xiongfeng Wang wrote: > > Hi Ezequiel, > > Thanks for your reply ! > > On 2020/5/14 3:32, Ezequiel Garcia wrote: > > On Mon, 11 May 2020 at 05:49, Xiongfeng Wang wrote: > >> > >> When I cat module parameter 'dma_mode' by sysfs, it displays as follows. > >> It is better to add a newline for easy reading. > >> > >> [root@hulk-202 ~]# cat /sys/module/tw686x/parameters/dma_mode > >> memcpy[root@hulk-202 ~]# > >> > >> Signed-off-by: Xiongfeng Wang > > > > I don't mind this change, but I don't think this is standard. > > The lack of newline follows what other drivers are doing. > > > > # hexdump -c /sys/module/acpi/parameters/ec_event_clearing > > 0000000 q u e r y > > 0000005 > > > > Is it really an issue for you? > > It's not an issue for me. It's just that if the result is in a separate line, it > reads more easily. I am also planning to fix the parameters below > '/sys/module/acpi/parameters'. > If you don't have a real reason behind this, such as a documented expectation or something breaking due to this, but just readability, then I don't think it's worth going through _all_ the module parameters fixing this. While I appreciate your effort, this cleanup exceeds the level of nitpicking I care for. Thanks! Ezequiel > Thanks, > Xiongfeng > > > > > Thanks, > > Ezequiel > > > >> --- > >> drivers/media/pci/tw686x/tw686x-core.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/media/pci/tw686x/tw686x-core.c b/drivers/media/pci/tw686x/tw686x-core.c > >> index 74ae4f0..bfc61da 100644 > >> --- a/drivers/media/pci/tw686x/tw686x-core.c > >> +++ b/drivers/media/pci/tw686x/tw686x-core.c > >> @@ -71,7 +71,7 @@ static const char *dma_mode_name(unsigned int mode) > >> > >> static int tw686x_dma_mode_get(char *buffer, const struct kernel_param *kp) > >> { > >> - return sprintf(buffer, "%s", dma_mode_name(dma_mode)); > >> + return sprintf(buffer, "%s\n", dma_mode_name(dma_mode)); > >> } > >> > >> static int tw686x_dma_mode_set(const char *val, const struct kernel_param *kp) > >> -- > >> 1.7.12.4 > >> > > >