From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5000AC433EF for ; Mon, 9 May 2022 14:17:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236866AbiEIOVV (ORCPT ); Mon, 9 May 2022 10:21:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236921AbiEIOVT (ORCPT ); Mon, 9 May 2022 10:21:19 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E7A320131D for ; Mon, 9 May 2022 07:17:16 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id gh6so27178168ejb.0 for ; Mon, 09 May 2022 07:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+8+QqXVKL5wTk1USxhSJy91rHhDM1q+WdZU6lGP6JQ4=; b=Se5eMb8Ygo8+NTsu2WGGmLwSiZe3RssFpzMyc+7jXSDykSJnAVSZVnd/OngGPWZciL TqOhSSgSmDT040EiixkOlRjSjs+ukuyf54/dNj07uwd2adCU7iAHQeyZ6NPWcbIYVPwR pnseMj0cI03Ui9b5xM9w/yOlvf2/OlxlznUm1jexmSPMmaEiax93PQoJ/G6Q+n7fow9z IeuitDasdXBRSpB+6VIA+P3OanKlTTP+m6n8bakAwn+q9cJfZqwF1lR8LLdZPHpM+15i QZvAmWZBOy2/SBull0eHOksCzYbIomn1nr2T6ttdbSEDr1YAhsbO0VVKPlHOwot8XrnA S8LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+8+QqXVKL5wTk1USxhSJy91rHhDM1q+WdZU6lGP6JQ4=; b=zPS/1cFUbKZF2yUZG2zYwfeoBshwDaeCI4DjUxdu5zFkZRpAoHhImGqw//PsHMg1Pq VXcH4XoU0z9k5SjxTKiTsxxMBZ5wVCPDxL790K5YwjTDcRJz32v0NbsHC/6Hgy+4hAQt ampOY6LpXS8IdEB/PkdQW8/mtoxW2Crc94evougXKQkcB7C6+zMqjWqLShmdx8iMpcVz mO/3adkn21+SdVOCzDYyzXZczg7KsP0O1vTDcq4W7nRxLvtie6lccprdV5Iti5vL3FRh cdPu9lvm77aHchtzIfu0PjgIWRLloyhl0JW8qPHJnVAp9/ZcAUeAM1NA6qQqCQo3gcG4 89uA== X-Gm-Message-State: AOAM533hQBw93xtMHuB/oYVLpkzwLPU+yLmkPOL3uQ+H7sPyPEDOfU2o EOpa1qckpAOHMSXYHo+x2gUju60Z7s15SD00NfvM6w== X-Google-Smtp-Source: ABdhPJz4oPKheaglIPZCKrUFsKejt51Mh50V9/DGs7u8F7syBlw3wHnbVvg9K8d9bl9luUK/vJye5kZrXA5cwi3Keig= X-Received: by 2002:a17:907:a0c8:b0:6f7:492e:e74c with SMTP id hw8-20020a170907a0c800b006f7492ee74cmr11393092ejc.670.1652105834875; Mon, 09 May 2022 07:17:14 -0700 (PDT) MIME-Version: 1.0 References: <20220508202544.501981-1-frattaroli.nicolas@gmail.com> <20220508202544.501981-4-frattaroli.nicolas@gmail.com> In-Reply-To: <20220508202544.501981-4-frattaroli.nicolas@gmail.com> From: Ezequiel Garcia Date: Mon, 9 May 2022 11:17:03 -0300 Message-ID: Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: Add Hantro encoder node to rk356x To: Nicolas Frattaroli Cc: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , devicetree , linux-arm-kernel , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nicolas, On Sun, May 8, 2022 at 5:26 PM Nicolas Frattaroli wrote: > > The RK3566 and RK3568 come with a dedicated Hantro instance solely for > encoding. This patch adds a node for this to the device tree, along with > a node for its MMU. > > Signed-off-by: Nicolas Frattaroli > --- > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > index 7cdef800cb3c..2e3c9e1887e3 100644 > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > @@ -508,6 +508,27 @@ gpu: gpu@fde60000 { > status = "disabled"; > }; > > + vepu: video-codec@fdee0000 { > + compatible = "rockchip,rk3568-vepu"; > + reg = <0x0 0xfdee0000 0x0 0x800>; > + interrupts = ; > + interrupt-names = "vepu"; It this block "encoder only" and if so, maybe we should remove the "interrupt-names" [1]? The driver is able to handle it. See: https://elixir.bootlin.com/linux/latest/source/drivers/staging/media/hantro/hantro_drv.c#L962 You might have to adjust the dt-bindings for this. [1] https://lore.kernel.org/linux-media/20210324151715.GA3070006@robh.at.kernel.org/ Thanks, Ezequiel > + clocks = <&cru ACLK_JENC>, <&cru HCLK_JENC>; > + clock-names = "aclk", "hclk"; > + iommus = <&vepu_mmu>; > + power-domains = <&power RK3568_PD_RGA>; > + }; > + > + vepu_mmu: iommu@fdee0800 { > + compatible = "rockchip,rk3568-iommu"; > + reg = <0x0 0xfdee0800 0x0 0x40>; > + interrupts = ; > + clocks = <&cru ACLK_JENC>, <&cru HCLK_JENC>; > + clock-names = "aclk", "iface"; > + power-domains = <&power RK3568_PD_RGA>; > + #iommu-cells = <0>; > + }; > + > sdmmc2: mmc@fe000000 { > compatible = "rockchip,rk3568-dw-mshc", "rockchip,rk3288-dw-mshc"; > reg = <0x0 0xfe000000 0x0 0x4000>; > -- > 2.36.0 > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07BEBC433F5 for ; Mon, 9 May 2022 14:17:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q9of6OIqMkXJut961MVVElhbBBVhrpQeiauAuQ7bkzU=; b=OdBvduQIni5scY 7FK9ZylkJE39pBQWIX9R50tX38BjpZy3i5qnU+V2qNHNkru1DkaQtrZwLmSMm8NlH8SCIYqrKUqv3 6xjk/NWQKYcdURNPm86bthkOUGei9JAv71rWfHE45JRrbDID51omjCaGksDlki7vU6cHxkTXffRRW kKs4Pi2Ki7nxuBz0O1ip6kRtBnUZZbNfBXYcw+e55kMsS1vImRL0wqW0FTJHJODTvDwFV7qOOz/xr jM36jb9S0Cz3+XlCQhz+ySf8TrIrwZp90J6CYgx1Vbg8XDpXAlWz7GBiLUM7DeNg88VA1YhMfp/87 DEaa9RKhLLiBuDsOOyzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1no4Cb-00Elh3-Oo; Mon, 09 May 2022 14:17:33 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1no4CN-00ElZb-Us for linux-rockchip@lists.infradead.org; Mon, 09 May 2022 14:17:21 +0000 Received: by mail-ej1-x62c.google.com with SMTP id ks9so20692971ejb.2 for ; Mon, 09 May 2022 07:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+8+QqXVKL5wTk1USxhSJy91rHhDM1q+WdZU6lGP6JQ4=; b=Se5eMb8Ygo8+NTsu2WGGmLwSiZe3RssFpzMyc+7jXSDykSJnAVSZVnd/OngGPWZciL TqOhSSgSmDT040EiixkOlRjSjs+ukuyf54/dNj07uwd2adCU7iAHQeyZ6NPWcbIYVPwR pnseMj0cI03Ui9b5xM9w/yOlvf2/OlxlznUm1jexmSPMmaEiax93PQoJ/G6Q+n7fow9z IeuitDasdXBRSpB+6VIA+P3OanKlTTP+m6n8bakAwn+q9cJfZqwF1lR8LLdZPHpM+15i QZvAmWZBOy2/SBull0eHOksCzYbIomn1nr2T6ttdbSEDr1YAhsbO0VVKPlHOwot8XrnA S8LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+8+QqXVKL5wTk1USxhSJy91rHhDM1q+WdZU6lGP6JQ4=; b=N1DWMRX4zSgcdy/EomMz9/KLN/DWg39dnt8T3LQMz9LceWxZ3mfSelHzGWh6N3QVi1 Lkr3mfGKsYz92JYwEOR+ffdTaR7I/ss1YgclmiSLXZAOPCjFbwrrrasNgYx4egCKGA9B PeuGfhg1Z428gK3jI9aVn+uBJ0X+JuR5ugTdnIZasDpRvI/rgYaWYoUcbKX8TASdGwhI +8H9sVQd+qMiQdcOkv+TOwn7vZIkInbTynw0GkzoZnOc+cG6IE/eKFifjDygN7Mbf68V bYpUqV6sX3zeO688SWkU7NyJELLJKpGeCXF1GaVgdWd5ewZUEva0I+G8r6JWsZcUyZVy TZLw== X-Gm-Message-State: AOAM532r1rQYMuzmOLli/G/VkA1ePImxasPNyIbpgoL2RPYPx3FibIa/ SzMwDzr7MwXAwHUF9+3sO/Q5KHAzB2ZyCSQspPcCrQ== X-Google-Smtp-Source: ABdhPJz4oPKheaglIPZCKrUFsKejt51Mh50V9/DGs7u8F7syBlw3wHnbVvg9K8d9bl9luUK/vJye5kZrXA5cwi3Keig= X-Received: by 2002:a17:907:a0c8:b0:6f7:492e:e74c with SMTP id hw8-20020a170907a0c800b006f7492ee74cmr11393092ejc.670.1652105834875; Mon, 09 May 2022 07:17:14 -0700 (PDT) MIME-Version: 1.0 References: <20220508202544.501981-1-frattaroli.nicolas@gmail.com> <20220508202544.501981-4-frattaroli.nicolas@gmail.com> In-Reply-To: <20220508202544.501981-4-frattaroli.nicolas@gmail.com> From: Ezequiel Garcia Date: Mon, 9 May 2022 11:17:03 -0300 Message-ID: Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: Add Hantro encoder node to rk356x To: Nicolas Frattaroli Cc: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , devicetree , linux-arm-kernel , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220509_071720_394570_3F8EF2FF X-CRM114-Status: GOOD ( 19.87 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Nicolas, On Sun, May 8, 2022 at 5:26 PM Nicolas Frattaroli wrote: > > The RK3566 and RK3568 come with a dedicated Hantro instance solely for > encoding. This patch adds a node for this to the device tree, along with > a node for its MMU. > > Signed-off-by: Nicolas Frattaroli > --- > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > index 7cdef800cb3c..2e3c9e1887e3 100644 > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > @@ -508,6 +508,27 @@ gpu: gpu@fde60000 { > status = "disabled"; > }; > > + vepu: video-codec@fdee0000 { > + compatible = "rockchip,rk3568-vepu"; > + reg = <0x0 0xfdee0000 0x0 0x800>; > + interrupts = ; > + interrupt-names = "vepu"; It this block "encoder only" and if so, maybe we should remove the "interrupt-names" [1]? The driver is able to handle it. See: https://elixir.bootlin.com/linux/latest/source/drivers/staging/media/hantro/hantro_drv.c#L962 You might have to adjust the dt-bindings for this. [1] https://lore.kernel.org/linux-media/20210324151715.GA3070006@robh.at.kernel.org/ Thanks, Ezequiel > + clocks = <&cru ACLK_JENC>, <&cru HCLK_JENC>; > + clock-names = "aclk", "hclk"; > + iommus = <&vepu_mmu>; > + power-domains = <&power RK3568_PD_RGA>; > + }; > + > + vepu_mmu: iommu@fdee0800 { > + compatible = "rockchip,rk3568-iommu"; > + reg = <0x0 0xfdee0800 0x0 0x40>; > + interrupts = ; > + clocks = <&cru ACLK_JENC>, <&cru HCLK_JENC>; > + clock-names = "aclk", "iface"; > + power-domains = <&power RK3568_PD_RGA>; > + #iommu-cells = <0>; > + }; > + > sdmmc2: mmc@fe000000 { > compatible = "rockchip,rk3568-dw-mshc", "rockchip,rk3288-dw-mshc"; > reg = <0x0 0xfe000000 0x0 0x4000>; > -- > 2.36.0 > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5C83C433EF for ; Mon, 9 May 2022 14:18:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PF4LZN4/MoPmPnfVYa1NB0Ci+zx17O7e+S6kDvuX2QY=; b=CnvtvMWoztq/Yb BYysrEfu+mixZ5ZJO0KhzjFRTh/fMqlaqDKx8udIxRl2V8uyFupkNbNKsAzw+j0COv/rTUcgT+B/f QXbcnM9jP40OR0OBzHFeZ72rORTNVVJOXHZ5RDUGaDQbIK8NGIQ5ZGxEcnoCez1XK6NoG/U3uB9Dd uTUHTp5oQ5MNGrJ9ddjRFy58iEgrW8MDnGsgBNAhBEoUnwT99puAekLYue5bmvtkC2tPtUWnx5y7/ ihlS1ivHDEoOtBS4bVpcpHPZFfy+t1wjCYbRq1Aq7u3Z/IO/qQBKX/B3CPhNb+/iA2qXS8PYOFYrq fDHQRgZYeqQrALMs7/XQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1no4CS-00EldK-RG; Mon, 09 May 2022 14:17:24 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1no4CN-00ElZc-Va for linux-arm-kernel@lists.infradead.org; Mon, 09 May 2022 14:17:21 +0000 Received: by mail-ej1-x62d.google.com with SMTP id g6so27131361ejw.1 for ; Mon, 09 May 2022 07:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+8+QqXVKL5wTk1USxhSJy91rHhDM1q+WdZU6lGP6JQ4=; b=Se5eMb8Ygo8+NTsu2WGGmLwSiZe3RssFpzMyc+7jXSDykSJnAVSZVnd/OngGPWZciL TqOhSSgSmDT040EiixkOlRjSjs+ukuyf54/dNj07uwd2adCU7iAHQeyZ6NPWcbIYVPwR pnseMj0cI03Ui9b5xM9w/yOlvf2/OlxlznUm1jexmSPMmaEiax93PQoJ/G6Q+n7fow9z IeuitDasdXBRSpB+6VIA+P3OanKlTTP+m6n8bakAwn+q9cJfZqwF1lR8LLdZPHpM+15i QZvAmWZBOy2/SBull0eHOksCzYbIomn1nr2T6ttdbSEDr1YAhsbO0VVKPlHOwot8XrnA S8LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+8+QqXVKL5wTk1USxhSJy91rHhDM1q+WdZU6lGP6JQ4=; b=SpMBnojan0M4n1FMpwgLYtYtWnYxNztjKEZDM0vVWpyj5+Acrmg24/sp5zZSQquNCg IcuABKlJEZ1U0fXNTv7anb9wh/JlruOT6B0nN1yrrEMf4iQjknUJ/HQRpL4Nu8uxZrKK pKr3Y5ULy97RHnwOWAKE0UtgJu4/lVVgt9YZxa8YXc+IIXH3j7d4XItpmU8zmJumK1qH E237oHfwgapLV08bWAZKgqFI8vBah/bd1x4GRT+6PWJeoNp314MknvN0R8V2m2f7eqTU MWOuKkDiDW1LzEcojgq51HQrWQfvIsdi2sgtrKiYbV9n/ph3xexGiJ5mbKwUR3xdOmrn CKIA== X-Gm-Message-State: AOAM5314FDzwOpjf4h5D2nTegolMdRzBjfcPFbnFsaBINQ+Hfe/8phYa fFxIKmKVGS1vtAQzjmy0T2mtv70fgUUftyWShxD0XjPPrIq6Ug== X-Google-Smtp-Source: ABdhPJz4oPKheaglIPZCKrUFsKejt51Mh50V9/DGs7u8F7syBlw3wHnbVvg9K8d9bl9luUK/vJye5kZrXA5cwi3Keig= X-Received: by 2002:a17:907:a0c8:b0:6f7:492e:e74c with SMTP id hw8-20020a170907a0c800b006f7492ee74cmr11393092ejc.670.1652105834875; Mon, 09 May 2022 07:17:14 -0700 (PDT) MIME-Version: 1.0 References: <20220508202544.501981-1-frattaroli.nicolas@gmail.com> <20220508202544.501981-4-frattaroli.nicolas@gmail.com> In-Reply-To: <20220508202544.501981-4-frattaroli.nicolas@gmail.com> From: Ezequiel Garcia Date: Mon, 9 May 2022 11:17:03 -0300 Message-ID: Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: Add Hantro encoder node to rk356x To: Nicolas Frattaroli Cc: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , devicetree , linux-arm-kernel , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220509_071720_394857_E94E3409 X-CRM114-Status: GOOD ( 21.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nicolas, On Sun, May 8, 2022 at 5:26 PM Nicolas Frattaroli wrote: > > The RK3566 and RK3568 come with a dedicated Hantro instance solely for > encoding. This patch adds a node for this to the device tree, along with > a node for its MMU. > > Signed-off-by: Nicolas Frattaroli > --- > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > index 7cdef800cb3c..2e3c9e1887e3 100644 > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > @@ -508,6 +508,27 @@ gpu: gpu@fde60000 { > status = "disabled"; > }; > > + vepu: video-codec@fdee0000 { > + compatible = "rockchip,rk3568-vepu"; > + reg = <0x0 0xfdee0000 0x0 0x800>; > + interrupts = ; > + interrupt-names = "vepu"; It this block "encoder only" and if so, maybe we should remove the "interrupt-names" [1]? The driver is able to handle it. See: https://elixir.bootlin.com/linux/latest/source/drivers/staging/media/hantro/hantro_drv.c#L962 You might have to adjust the dt-bindings for this. [1] https://lore.kernel.org/linux-media/20210324151715.GA3070006@robh.at.kernel.org/ Thanks, Ezequiel > + clocks = <&cru ACLK_JENC>, <&cru HCLK_JENC>; > + clock-names = "aclk", "hclk"; > + iommus = <&vepu_mmu>; > + power-domains = <&power RK3568_PD_RGA>; > + }; > + > + vepu_mmu: iommu@fdee0800 { > + compatible = "rockchip,rk3568-iommu"; > + reg = <0x0 0xfdee0800 0x0 0x40>; > + interrupts = ; > + clocks = <&cru ACLK_JENC>, <&cru HCLK_JENC>; > + clock-names = "aclk", "iface"; > + power-domains = <&power RK3568_PD_RGA>; > + #iommu-cells = <0>; > + }; > + > sdmmc2: mmc@fe000000 { > compatible = "rockchip,rk3568-dw-mshc", "rockchip,rk3288-dw-mshc"; > reg = <0x0 0xfe000000 0x0 0x4000>; > -- > 2.36.0 > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel