From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A962C5519F for ; Wed, 25 Nov 2020 07:33:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 171B8208B8 for ; Wed, 25 Nov 2020 07:33:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OFT2Hs8U" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727786AbgKYHcy (ORCPT ); Wed, 25 Nov 2020 02:32:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726330AbgKYHcx (ORCPT ); Wed, 25 Nov 2020 02:32:53 -0500 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D404C0613D4 for ; Tue, 24 Nov 2020 23:32:43 -0800 (PST) Received: by mail-ed1-x544.google.com with SMTP id v22so1452838edt.9 for ; Tue, 24 Nov 2020 23:32:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z0kiqVefEuj1c1EK0YD5O7NC2u+drbKVj6pcJlOBK3w=; b=OFT2Hs8UzKOKtSOzYf/ERtas1sZ0mVebhVkiTnGj2k/sH24GLOCfOTd3/9d0Lpq1Gj ZwfDKcVdxAd/OKobI4rXJ0hBRNGhfLb0nxKnPIpQpeuQElV9hQpvSZx1BL4XKlAmsQLA UkO1UUiWf3yaF/Oq6aLm8vtXwVYRuv0r9oXgo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z0kiqVefEuj1c1EK0YD5O7NC2u+drbKVj6pcJlOBK3w=; b=oZCkwMh9HC0B4YJoAn9o9SZgw94BaunC1LOMxFIRxCgXzGRlTW4SJeOAvNDuLpVgKZ FoFO7ypjn8PEfPuzfKXAm+uhLFRQHmdC7Wtvyp39CYrdta35E+6S5T6byG9smW9FaZn+ mKIXMpjDS+tcZmJweYssgZdfhD3bevePU5hvSjaUBK7vWTK1uxVVqApuLFK2ygrHl9RA m9KlI7wW1Jss3jZPFpgTUZX7e4GrQZidd6e9owI7sj0rG+mxRFzHDWWwNJvz6NrmfF6n c8lQuPI1M3p4PwpjX0MABXERuQTtVhn1AKZj5X8tIlbzw7Q02y7ww90oKjQcSm9aXaqD cBKg== X-Gm-Message-State: AOAM531PAz3jU/j0bf546iKsqzL7QkNZkgJF5o9LMmVIAVuqXEYo/7Cm Kja1QNUzR/GWehh2EmQawLNHwmWO4SpidQ== X-Google-Smtp-Source: ABdhPJxBMd7Kfop0HqSuySACa5e8gyM2tNQasVo2nxVY9bAJ8uFsbZqNVrpQVnvT7g1gdvOXKaAbTQ== X-Received: by 2002:a05:6402:1714:: with SMTP id y20mr2258694edu.306.1606289561909; Tue, 24 Nov 2020 23:32:41 -0800 (PST) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com. [209.85.221.52]) by smtp.gmail.com with ESMTPSA id d22sm708738ejy.15.2020.11.24.23.32.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Nov 2020 23:32:41 -0800 (PST) Received: by mail-wr1-f52.google.com with SMTP id 64so836909wra.11 for ; Tue, 24 Nov 2020 23:32:40 -0800 (PST) X-Received: by 2002:adf:ed11:: with SMTP id a17mr2449865wro.197.1606289560075; Tue, 24 Nov 2020 23:32:40 -0800 (PST) MIME-Version: 1.0 References: <20201116155008.118124-1-robert.foss@linaro.org> In-Reply-To: From: Tomasz Figa Date: Wed, 25 Nov 2020 16:32:28 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] media: ov8856: Remove 3280x2464 mode To: Bingbu Cao Cc: Robert Foss , Dongchun Zhu , Mauro Carvalho Chehab , linux-media , linux-kernel , Sakari Ailus , Ben Kao Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bingbu, On Wed, Nov 25, 2020 at 1:15 PM Bingbu Cao wrote: > > > > On 11/24/20 6:20 PM, Robert Foss wrote: > > On Tue, 24 Nov 2020 at 10:42, Bingbu Cao wrote: > >> > >> Hi, Robert > >> > >> I remember that the full size of ov8856 image sensor is 3296x2480 and we can get the 3280x2464 > >> frames based on current settings. > >> > >> Do you have any issues with this mode? > > > > As far as I can tell using the 3280x2464 mode actually yields an > > output resolution that is 3264x2448. > > > > What does your hardware setup look like? And which revision of the > > sensor are you using? > > > > Robert, the sensor revision I am using is v1.1. I just checked the actual output pixels on our > hardware, the output resolution with 2464 mode is 3280x2464, no black pixels. > > As Tomasz said, some ISP has the requirement of extra pixel padding, From the ov8856 datasheet, > the central 3264x2448 pixels are *suggested* to be output from the pixel array and the boundary > pixels can be used for additional processing. In my understanding, the 32 dummy lines are not > black lines. The datasheet says that only 3264x2448 are active pixels. What pixel values are you seeing outside of that central area? In the datasheet, those look like "optically black" pixels, which are not 100% black, but rather as if the sensor cells didn't receive any light - noise can be still there. Best regards, Tomasz