From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF5C3C433E3 for ; Sat, 22 Aug 2020 15:20:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD08720738 for ; Sat, 22 Aug 2020 15:20:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="GqRC2h7Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728245AbgHVPUi (ORCPT ); Sat, 22 Aug 2020 11:20:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727899AbgHVPUd (ORCPT ); Sat, 22 Aug 2020 11:20:33 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 078DDC061755 for ; Sat, 22 Aug 2020 08:20:32 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id kq25so6033903ejb.3 for ; Sat, 22 Aug 2020 08:20:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=LN5JFqdEmJKSQD9LQroiOhG0/S7s6+UdrWun1PeHIeU=; b=GqRC2h7ZpP/gqzffABDnoB7CwyD+X7HNnxeNruuV8wiICFNZI6sVKjwF16rr3BwbGv EAmTCNLmcNCLY2+DmUhCTPgb/Xx1jS0xFIxgCQftI5TVWVOFyLt12b9cKsY5uvkqX8e4 AkPUumv0jeqjqk/zyjjYDLED1HLlTfJAG7MDs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LN5JFqdEmJKSQD9LQroiOhG0/S7s6+UdrWun1PeHIeU=; b=pZt4+YtfBQJv18kkSG20ujCVuWAN3ove4TdTllZbsgU5+Y+N+jtMq3QUYPr7qZeDw8 n7/ct8U0cZNOL+Q1M70sLd8ntQ2f5H7q7OSCYMmtYsmolbWP939qMzXs7jixAbC8W3Xw 3shCh3FWmZVjC7LWv7EslEzbs+xu0dkXpNQnW+pVYW4qJ7ioKO7BFf6nA/D18F/Cgt4w bhigGjRU22jLY1GEprC+0B8dJuCFEzkScF+3LAgu48tHA9fT9TkNO02pBIDVobc1bNPl dyoMCoq0iD2IQC6r5GqpSTsUhjSb6byUG05yL+mDSpquhrp9PGeY88nDlI8zkCPBhSxK +aAA== X-Gm-Message-State: AOAM533eICUr1drl3LruJ7S3gXAPJyJimbT3xPMHvxsZcXMNk5FmsUNa jjJEGRCS5KKDFfSTKnFfVNnXfbNtT49vdg== X-Google-Smtp-Source: ABdhPJxxShW98XkAQk2zX74m8uyE/KPY7345gq3dtNxbOdQAxWM5NE6vc+IK2/sRmB/b+5OdASfDQQ== X-Received: by 2002:a17:906:6bc9:: with SMTP id t9mr7517672ejs.372.1598109629390; Sat, 22 Aug 2020 08:20:29 -0700 (PDT) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com. [209.85.221.44]) by smtp.gmail.com with ESMTPSA id ar2sm3481368ejc.61.2020.08.22.08.20.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Aug 2020 08:20:28 -0700 (PDT) Received: by mail-wr1-f44.google.com with SMTP id r2so4553159wrs.8 for ; Sat, 22 Aug 2020 08:20:28 -0700 (PDT) X-Received: by 2002:a5d:6744:: with SMTP id l4mr7993640wrw.105.1598109628053; Sat, 22 Aug 2020 08:20:28 -0700 (PDT) MIME-Version: 1.0 References: <20200821161401.11307-1-l.stelmach@samsung.com> <20200821161401.11307-8-l.stelmach@samsung.com> <20200822124325.GF20423@kozik-lap> <20200822151819.GA13668@kozik-lap> In-Reply-To: <20200822151819.GA13668@kozik-lap> From: Tomasz Figa Date: Sat, 22 Aug 2020 17:20:16 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 7/9] spi: spi-s3c64xx: Ensure cur_speed holds actual clock value To: Krzysztof Kozlowski Cc: =?UTF-8?Q?=C5=81ukasz_Stelmach?= , Kukjin Kim , Andi Shyti , Mark Brown , linux-spi@vger.kernel.org, linux-samsung-soc , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Linux Kernel Mailing List , Marek Szyprowski , Bartlomiej Zolnierkiewicz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 22, 2020 at 5:18 PM Krzysztof Kozlowski wrote= : > > On Sat, Aug 22, 2020 at 04:52:40PM +0200, Tomasz Figa wrote: > > On Sat, Aug 22, 2020 at 2:43 PM Krzysztof Kozlowski w= rote: > > > > > > On Fri, Aug 21, 2020 at 06:13:59PM +0200, =C5=81ukasz Stelmach wrote: > > > > cur_speed is used to calculate transfer timeout and needs to be > > > > set to the actual value of (half) the clock speed for precise > > > > calculations. > > > > > > If you need this only for timeout calculation just divide it in > > > s3c64xx_wait_for_dma(). > > > > Division is not the point of the patch. The point is that > > clk_set_rate() that was originally there doesn't guarantee that the > > rate is set exactly. > > Unfortunately onlt that point of timeout is mentioned in commit msg. If > the correction of timeout was not the point of the patch, then describe > the real point... > > > The rate directly determines the SPI transfer > > speed and thus the driver needs to use the rate that was actually set > > for further calculations. > > Yep, makes sense. > > > > > > Otherwise why only if (cmu) case is updated? > > > > Right, the !cmu case actually suffers from the same problem. The code > > divides the parent clock rate with the requested speed to obtain the > > divider to program into the register. This is subject to integer > > rounding, so (parent / (parent / speed)) doesn't always equal (speed). > > It is not only this problem. The meaning of cur_speed is now changed. > For !cmu_case this the requested in trasnfer SPI bus clock frequency, > for cmu_case this is now real src_clk frequency. It's getting slightly > messier. > > > > > > > > > You are also affecting here not only timeout but > > > s3c64xx_enable_datapath() which is not mentioned in commit log. In ot= her > > > words, this looks wrong. > > > > Actually this is right and fixes one more problem, which I didn't spot > > when looking at this code when I suggested the change (I only spotted > > the effects on timeout calculation). The rounding error might have > > caused wrong configuration there, because e.g. 30000000 Hz could be > > requested and rounded to 28000000 Hz. The former is a threshold for > > setting the S3C64XX_SPI_CH_HS_EN bit, but the real frequency wouldn't > > actually require setting it. > > Wrong is here describing one thing and doing much more. Yeah, agreed that the description could be improved. :) Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC7BBC433E1 for ; Sat, 22 Aug 2020 15:21:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8E5020738 for ; Sat, 22 Aug 2020 15:21:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UrgXrEtp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="GqRC2h7Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8E5020738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Up+yDg7VhM3Nb41jd3hNH+kFzRh29BGkagtTcNbub3M=; b=UrgXrEtp98jZaNAJUznVjyHKY UWYGYoxng2v6g/YGpqb+p/sMoFiR0hyk4cza/INf2UqolYS7VKtOa0tt8JIUXt+DreNylG7t7PEpL 6c6X4RsPJFwZ9EpEtPJ8Hf4JQ5AA4QCvo9gneZav+Cw99PjK+CdPcVGVGueyx5S1o4gMsMgDKt0iC Ip6XCjQ0NgGurUmzpwn5zjeG691oCtaMecPi+HJDt6URO2jNc7HnOVDVRKIr2Q/6gV918EiFVSQDH gB2PhTC5M/j/ufW/IidNhpPEutBXmjDj5Bk9nqMIIR30ngWBYx+u2U9mAgU7e5wuFA8C54wsRXbsv UoQ+2tKtg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9VJo-0001GQ-P1; Sat, 22 Aug 2020 15:20:32 +0000 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k9VJm-0001Fw-Sx for linux-arm-kernel@lists.infradead.org; Sat, 22 Aug 2020 15:20:31 +0000 Received: by mail-ed1-x543.google.com with SMTP id l63so981299edl.9 for ; Sat, 22 Aug 2020 08:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=LN5JFqdEmJKSQD9LQroiOhG0/S7s6+UdrWun1PeHIeU=; b=GqRC2h7ZpP/gqzffABDnoB7CwyD+X7HNnxeNruuV8wiICFNZI6sVKjwF16rr3BwbGv EAmTCNLmcNCLY2+DmUhCTPgb/Xx1jS0xFIxgCQftI5TVWVOFyLt12b9cKsY5uvkqX8e4 AkPUumv0jeqjqk/zyjjYDLED1HLlTfJAG7MDs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LN5JFqdEmJKSQD9LQroiOhG0/S7s6+UdrWun1PeHIeU=; b=AMP0HucpquHsR2QtijWh9UwMXYsz0cjskIMlnzvSD9FX53VOAaGiEbokfJ29iuoMXN W77t8pqYkOkLf7bM19e6g139SNfGhrv0ZvBiKrK6WSP0R6gTKou9J2TYw/lnOZV41hTZ bkH7LwfCaxuyib5U0bDJBI8B/NqMgwXUoa4zgru+A0DhOWKNgb6rjKB+07UM8atNlR9p NywlBbCC6SBj173kCCfigNgbZMR2PVob2cEaREtHtxnIIdKXJIVTenYpOeRKYBeysGRx 2Vdixi6lOQ0HHstoyn0MuGdINFK0sGkqaXbCIIt3ktpZEfdDP2yqi8kE5DkFyo9KbKZ0 o2hQ== X-Gm-Message-State: AOAM531pNhSyBiI+QKlAMfzViPNvHnqGI7OoKJ3NR3spzDePGnvykuNI IzQwi19uI20d5OJhK84v86mbJ6fdXR+C4A== X-Google-Smtp-Source: ABdhPJxHRu+4TIpTzgX8sp4bbQa5kWzdaQgjW00ZN6pLcp0j1h5KRhk1Zu3Opd00hHjJW4OaedeDCQ== X-Received: by 2002:aa7:c606:: with SMTP id h6mr7802906edq.288.1598109629437; Sat, 22 Aug 2020 08:20:29 -0700 (PDT) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com. [209.85.221.52]) by smtp.gmail.com with ESMTPSA id t6sm3430638ejc.40.2020.08.22.08.20.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Aug 2020 08:20:28 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id a15so4543506wrh.10 for ; Sat, 22 Aug 2020 08:20:28 -0700 (PDT) X-Received: by 2002:a5d:6744:: with SMTP id l4mr7993640wrw.105.1598109628053; Sat, 22 Aug 2020 08:20:28 -0700 (PDT) MIME-Version: 1.0 References: <20200821161401.11307-1-l.stelmach@samsung.com> <20200821161401.11307-8-l.stelmach@samsung.com> <20200822124325.GF20423@kozik-lap> <20200822151819.GA13668@kozik-lap> In-Reply-To: <20200822151819.GA13668@kozik-lap> From: Tomasz Figa Date: Sat, 22 Aug 2020 17:20:16 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 7/9] spi: spi-s3c64xx: Ensure cur_speed holds actual clock value To: Krzysztof Kozlowski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200822_112030_977658_C5656C4C X-CRM114-Status: GOOD ( 28.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc , Bartlomiej Zolnierkiewicz , =?UTF-8?Q?=C5=81ukasz_Stelmach?= , Linux Kernel Mailing List , linux-spi@vger.kernel.org, Mark Brown , Kukjin Kim , Andi Shyti , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Marek Szyprowski Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBBdWcgMjIsIDIwMjAgYXQgNToxOCBQTSBLcnp5c3p0b2YgS296bG93c2tpIDxrcnpr QGtlcm5lbC5vcmc+IHdyb3RlOgo+Cj4gT24gU2F0LCBBdWcgMjIsIDIwMjAgYXQgMDQ6NTI6NDBQ TSArMDIwMCwgVG9tYXN6IEZpZ2Egd3JvdGU6Cj4gPiBPbiBTYXQsIEF1ZyAyMiwgMjAyMCBhdCAy OjQzIFBNIEtyenlzenRvZiBLb3psb3dza2kgPGtyemtAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPiA+ Cj4gPiA+IE9uIEZyaSwgQXVnIDIxLCAyMDIwIGF0IDA2OjEzOjU5UE0gKzAyMDAsIMWBdWthc3og U3RlbG1hY2ggd3JvdGU6Cj4gPiA+ID4gY3VyX3NwZWVkIGlzIHVzZWQgdG8gY2FsY3VsYXRlIHRy YW5zZmVyIHRpbWVvdXQgYW5kIG5lZWRzIHRvIGJlCj4gPiA+ID4gc2V0IHRvIHRoZSBhY3R1YWwg dmFsdWUgb2YgKGhhbGYpIHRoZSBjbG9jayBzcGVlZCBmb3IgcHJlY2lzZQo+ID4gPiA+IGNhbGN1 bGF0aW9ucy4KPiA+ID4KPiA+ID4gSWYgeW91IG5lZWQgdGhpcyBvbmx5IGZvciB0aW1lb3V0IGNh bGN1bGF0aW9uIGp1c3QgZGl2aWRlIGl0IGluCj4gPiA+IHMzYzY0eHhfd2FpdF9mb3JfZG1hKCku Cj4gPgo+ID4gRGl2aXNpb24gaXMgbm90IHRoZSBwb2ludCBvZiB0aGUgcGF0Y2guIFRoZSBwb2lu dCBpcyB0aGF0Cj4gPiBjbGtfc2V0X3JhdGUoKSB0aGF0IHdhcyBvcmlnaW5hbGx5IHRoZXJlIGRv ZXNuJ3QgZ3VhcmFudGVlIHRoYXQgdGhlCj4gPiByYXRlIGlzIHNldCBleGFjdGx5Lgo+Cj4gVW5m b3J0dW5hdGVseSBvbmx0IHRoYXQgcG9pbnQgb2YgdGltZW91dCBpcyBtZW50aW9uZWQgaW4gY29t bWl0IG1zZy4gSWYKPiB0aGUgY29ycmVjdGlvbiBvZiB0aW1lb3V0IHdhcyBub3QgdGhlIHBvaW50 IG9mIHRoZSBwYXRjaCwgdGhlbiBkZXNjcmliZQo+IHRoZSByZWFsIHBvaW50Li4uCj4KPiA+IFRo ZSByYXRlIGRpcmVjdGx5IGRldGVybWluZXMgdGhlIFNQSSB0cmFuc2Zlcgo+ID4gc3BlZWQgYW5k IHRodXMgdGhlIGRyaXZlciBuZWVkcyB0byB1c2UgdGhlIHJhdGUgdGhhdCB3YXMgYWN0dWFsbHkg c2V0Cj4gPiBmb3IgZnVydGhlciBjYWxjdWxhdGlvbnMuCj4KPiBZZXAsIG1ha2VzIHNlbnNlLgo+ Cj4gPgo+ID4gPiBPdGhlcndpc2Ugd2h5IG9ubHkgaWYgKGNtdSkgY2FzZSBpcyB1cGRhdGVkPwo+ ID4KPiA+IFJpZ2h0LCB0aGUgIWNtdSBjYXNlIGFjdHVhbGx5IHN1ZmZlcnMgZnJvbSB0aGUgc2Ft ZSBwcm9ibGVtLiBUaGUgY29kZQo+ID4gZGl2aWRlcyB0aGUgcGFyZW50IGNsb2NrIHJhdGUgd2l0 aCB0aGUgcmVxdWVzdGVkIHNwZWVkIHRvIG9idGFpbiB0aGUKPiA+IGRpdmlkZXIgdG8gcHJvZ3Jh bSBpbnRvIHRoZSByZWdpc3Rlci4gVGhpcyBpcyBzdWJqZWN0IHRvIGludGVnZXIKPiA+IHJvdW5k aW5nLCBzbyAocGFyZW50IC8gKHBhcmVudCAvIHNwZWVkKSkgZG9lc24ndCBhbHdheXMgZXF1YWwg KHNwZWVkKS4KPgo+IEl0IGlzIG5vdCBvbmx5IHRoaXMgcHJvYmxlbS4gVGhlIG1lYW5pbmcgb2Yg Y3VyX3NwZWVkIGlzIG5vdyBjaGFuZ2VkLgo+IEZvciAhY211X2Nhc2UgdGhpcyB0aGUgcmVxdWVz dGVkIGluIHRyYXNuZmVyIFNQSSBidXMgY2xvY2sgZnJlcXVlbmN5LAo+IGZvciBjbXVfY2FzZSB0 aGlzIGlzIG5vdyByZWFsIHNyY19jbGsgZnJlcXVlbmN5LiBJdCdzIGdldHRpbmcgc2xpZ2h0bHkK PiBtZXNzaWVyLgo+Cj4gPgo+ID4gPgo+ID4gPiBZb3UgYXJlIGFsc28gYWZmZWN0aW5nIGhlcmUg bm90IG9ubHkgdGltZW91dCBidXQKPiA+ID4gczNjNjR4eF9lbmFibGVfZGF0YXBhdGgoKSB3aGlj aCBpcyBub3QgbWVudGlvbmVkIGluIGNvbW1pdCBsb2cuIEluIG90aGVyCj4gPiA+IHdvcmRzLCB0 aGlzIGxvb2tzIHdyb25nLgo+ID4KPiA+IEFjdHVhbGx5IHRoaXMgaXMgcmlnaHQgYW5kIGZpeGVz IG9uZSBtb3JlIHByb2JsZW0sIHdoaWNoIEkgZGlkbid0IHNwb3QKPiA+IHdoZW4gbG9va2luZyBh dCB0aGlzIGNvZGUgd2hlbiBJIHN1Z2dlc3RlZCB0aGUgY2hhbmdlIChJIG9ubHkgc3BvdHRlZAo+ ID4gdGhlIGVmZmVjdHMgb24gdGltZW91dCBjYWxjdWxhdGlvbikuIFRoZSByb3VuZGluZyBlcnJv ciBtaWdodCBoYXZlCj4gPiBjYXVzZWQgd3JvbmcgY29uZmlndXJhdGlvbiB0aGVyZSwgYmVjYXVz ZSBlLmcuIDMwMDAwMDAwIEh6IGNvdWxkIGJlCj4gPiByZXF1ZXN0ZWQgYW5kIHJvdW5kZWQgdG8g MjgwMDAwMDAgSHouIFRoZSBmb3JtZXIgaXMgYSB0aHJlc2hvbGQgZm9yCj4gPiBzZXR0aW5nIHRo ZSBTM0M2NFhYX1NQSV9DSF9IU19FTiBiaXQsIGJ1dCB0aGUgcmVhbCBmcmVxdWVuY3kgd291bGRu J3QKPiA+IGFjdHVhbGx5IHJlcXVpcmUgc2V0dGluZyBpdC4KPgo+IFdyb25nIGlzIGhlcmUgZGVz Y3JpYmluZyBvbmUgdGhpbmcgYW5kIGRvaW5nIG11Y2ggbW9yZS4KClllYWgsIGFncmVlZCB0aGF0 IHRoZSBkZXNjcmlwdGlvbiBjb3VsZCBiZSBpbXByb3ZlZC4gOikKCkJlc3QgcmVnYXJkcywKVG9t YXN6CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==