From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 630D3C433E0 for ; Fri, 12 Jun 2020 18:45:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BEB6207F7 for ; Fri, 12 Jun 2020 18:45:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bRJxS+Q2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726263AbgFLSpk (ORCPT ); Fri, 12 Jun 2020 14:45:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726085AbgFLSpj (ORCPT ); Fri, 12 Jun 2020 14:45:39 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C608DC03E96F for ; Fri, 12 Jun 2020 11:45:39 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id f7so11088243ejq.6 for ; Fri, 12 Jun 2020 11:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P8sNBYcte/zk1gJm2YzOJRDjejnEUqN/A2ieuNyUweg=; b=bRJxS+Q2KQuM54a8erBJ8qt32TXVRsXhyMB8WWOq3eNmxwrN4tec98hY1I3dgRAadb ts7ymaPP/cxcISqUJMVR1rg0hvz0g6hLj31QBZ2Q4wp8U7XtRblQESknjGvBDfox0Z06 uKeyun3azaUw4eFf03EUYyLAv5q0HMR3PsF8E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P8sNBYcte/zk1gJm2YzOJRDjejnEUqN/A2ieuNyUweg=; b=ONkwvcxeHdB2EleUUva0aIDanEWgD4ZDv+Zwf1HuOG106up4JOaee2hDr0qS2zAwrQ yNmL2catPACqsR7TPPsU9rr0NFUuSEDUP7IWJcZIQ5TIMviilXMeDLPqOGJ/PqL23oK2 IiRWnYQ0kkl5fXBiQsbs21VMN/ZcDeTbOgSPsxk07QJ33jVmcgyHj2nFtsfZTzO5pp/8 g5dsxqv2kxjI9mDwiT4jpo1+P1FYcS6iRC2SRjWBbHwG+18qkDhl/MaUeapdGLs5Nij/ 53K4KlGTIPYpiEnACI5+IGVT/E8zeaTfcnG79YfPtPOBXwdqeDSoP587GJvvEp7tL9Tm krPQ== X-Gm-Message-State: AOAM531P4PMlwp3AEhrx71GpC+AdcOtPX8qMq/PEvVKUyXp6LGJv1Y/7 scN7N4elP6oD1bQXUJC78NlbgI3v08heeg== X-Google-Smtp-Source: ABdhPJxB40oWvKauvYQp7GgS01z+ZZSXZJslOO3BxwosgT1E1lnq6U4bk4Tlud5OV2JdSPZzDhJ4vQ== X-Received: by 2002:a17:906:d8bc:: with SMTP id qc28mr15394028ejb.167.1591987538249; Fri, 12 Jun 2020 11:45:38 -0700 (PDT) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com. [209.85.221.52]) by smtp.gmail.com with ESMTPSA id ew9sm3974870ejb.121.2020.06.12.11.45.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jun 2020 11:45:38 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id e1so10740023wrt.5 for ; Fri, 12 Jun 2020 11:45:37 -0700 (PDT) X-Received: by 2002:a1c:2e0e:: with SMTP id u14mr257126wmu.55.1591987183150; Fri, 12 Jun 2020 11:39:43 -0700 (PDT) MIME-Version: 1.0 References: <20200523084103.31276-1-dongchun.zhu@mediatek.com> <20200523084103.31276-3-dongchun.zhu@mediatek.com> <20200610194455.GK201868@chromium.org> <1591958798.8804.660.camel@mhfsdcap03> In-Reply-To: <1591958798.8804.660.camel@mhfsdcap03> From: Tomasz Figa Date: Fri, 12 Jun 2020 20:39:30 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [V9, 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver To: Dongchun Zhu Cc: Linus Walleij , Bartosz Golaszewski , Mauro Carvalho Chehab , Andy Shevchenko , Rob Herring , Mark Rutland , Sakari Ailus , Nicolas Boichat , Matthias Brugger , Cao Bing Bu , srv_heupstream , "moderated list:ARM/Mediatek SoC support" , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Sj Huang , Linux Media Mailing List , linux-devicetree , Louis Kuo , =?UTF-8?B?U2hlbmduYW4gV2FuZyAo546L5Zyj55S3KQ==?= Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Jun 12, 2020 at 12:49 PM Dongchun Zhu wrote: > > Hi Tomasz, > > On Wed, 2020-06-10 at 19:44 +0000, Tomasz Figa wrote: > > Hi Dongchun, > > > > On Sat, May 23, 2020 at 04:41:03PM +0800, Dongchun Zhu wrote: > > > Add a V4L2 sub-device driver for OV02A10 image sensor. > > > > > > Signed-off-by: Dongchun Zhu > > > --- > > > MAINTAINERS | 1 + > > > drivers/media/i2c/Kconfig | 13 + > > > drivers/media/i2c/Makefile | 1 + > > > drivers/media/i2c/ov02a10.c | 1025 +++++++++++++++++++++++++++++++++++++++++++ > > > 4 files changed, 1040 insertions(+) > > > create mode 100644 drivers/media/i2c/ov02a10.c > > > > > > > Thank you for the patch. Please see my comments inline. > > > > [snip] > > > diff --git a/drivers/media/i2c/ov02a10.c b/drivers/media/i2c/ov02a10.c > > > new file mode 100644 > > > index 0000000..160a0b5 > > > --- /dev/null > > > +++ b/drivers/media/i2c/ov02a10.c > > [snip] > > > +static const char * const ov02a10_test_pattern_menu[] = { > > > + "Disabled", > > > + "Color Bar", > > > > nit: We should normalize this to one of the standard names. What is the > > pattern on this sensor? Is it perhaps "Eight Vertical Colour Bars"? > > > > Yes. It is one kind of 'Eight Vertical Colour Bars'. > This pattern is called as 'MIPI color bar' per the datasheet. > Can we here use 'Vertical Color Bar' or 'MIPI Color Bar'? > We should try to stick to the names as exposed by existing drivers. There was an attempt to unify the naming of some Sony sensors some time ago [1]. Perhaps one of the names there matches the pattern of this sensor? [1] https://patchwork.kernel.org/patch/10711777/ Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28816C433DF for ; Fri, 12 Jun 2020 18:39:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1B2F206DC for ; Fri, 12 Jun 2020 18:39:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Upskv8wv"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bRJxS+Q2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1B2F206DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kWIE4IEScdIae3ij2KX+v16Cd1YbhIgBdIXpSjXNLBs=; b=Upskv8wv6o0+o0 z+isJdxngMhEiwKGrPRH5VvUkgQWrHbW0QZLI0mcc2ovdBFZsEKumEXwhpSxagN2QfBNmaoW9DUlf LuDw3d178eo7Gd+wUJEUqFhl2SLD2XI0B8Qo7mcvyszAH/Ym+xYK+J57BQIgfQ9OtsVebEFMD7KNs iy9HEQEeJHfcTg/jM0PVbqqOf+f2/GZ/gPOPxJyWIg6RFSL5RvxLpomn6zgz+YfPCWCr2OdY4SLjx NAPlfmUtKsHv7BfJG0vAVm2D8FhZ4uYqGFzM756ef7K5DbTi/feV78HoIKarSPE/VBg160XYAnpxs /KfTJKGBoVkuGluHvCvw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjoaj-00059I-RW; Fri, 12 Jun 2020 18:39:49 +0000 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjoah-00058o-6c for linux-mediatek@lists.infradead.org; Fri, 12 Jun 2020 18:39:49 +0000 Received: by mail-ej1-x644.google.com with SMTP id o15so11035594ejm.12 for ; Fri, 12 Jun 2020 11:39:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P8sNBYcte/zk1gJm2YzOJRDjejnEUqN/A2ieuNyUweg=; b=bRJxS+Q2KQuM54a8erBJ8qt32TXVRsXhyMB8WWOq3eNmxwrN4tec98hY1I3dgRAadb ts7ymaPP/cxcISqUJMVR1rg0hvz0g6hLj31QBZ2Q4wp8U7XtRblQESknjGvBDfox0Z06 uKeyun3azaUw4eFf03EUYyLAv5q0HMR3PsF8E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P8sNBYcte/zk1gJm2YzOJRDjejnEUqN/A2ieuNyUweg=; b=Jv0PB10/VFdSITNJGygdzETG5DABmxIqbfQqm3gWg5KvPNDGyAnEXZM7lWaMU+yVjC CAm//+UCer3p0Lr7oAO78q0trotSLM3Bu116f5sA/sUJifaN6lnjSaxo2X/w0m3FLxI6 VfYLDEErfBj1keer5wD5MQxGVi+ivbRb+mMcYjPc67NGbZaBv8eQEtPkHVcmLVZ/xIqK x4LP7mmGNkKbcbUe4CZwUir6Aoz4l0wHYeLHwvya5ngUusNHksGhrqE12966r1nxyMEB qP6J2AiDD/CRPjCyA2IL7QWn2YCz0LdZkQWU+tlFfPDkASIabHp3I6kabxKQv1XsS/oE uYdg== X-Gm-Message-State: AOAM530R9t/HqzgFrSej6t97ZXSI9X9LWzFFxW7XmnbV58MI7B/GTM0O Jzp/50Vyw+SwOVigyf3zLGcXxMcbi3iePA== X-Google-Smtp-Source: ABdhPJxcoJNNfsGUJzJjYFRkkJDhZlX56nYQ9SgUSwYO61sYXO50hokwMysN3KC9KtrKkfBAminKQw== X-Received: by 2002:a17:906:11c4:: with SMTP id o4mr15045780eja.163.1591987184710; Fri, 12 Jun 2020 11:39:44 -0700 (PDT) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com. [209.85.128.41]) by smtp.gmail.com with ESMTPSA id e20sm3051509ejh.22.2020.06.12.11.39.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jun 2020 11:39:43 -0700 (PDT) Received: by mail-wm1-f41.google.com with SMTP id l26so9035289wme.3 for ; Fri, 12 Jun 2020 11:39:43 -0700 (PDT) X-Received: by 2002:a1c:2e0e:: with SMTP id u14mr257126wmu.55.1591987183150; Fri, 12 Jun 2020 11:39:43 -0700 (PDT) MIME-Version: 1.0 References: <20200523084103.31276-1-dongchun.zhu@mediatek.com> <20200523084103.31276-3-dongchun.zhu@mediatek.com> <20200610194455.GK201868@chromium.org> <1591958798.8804.660.camel@mhfsdcap03> In-Reply-To: <1591958798.8804.660.camel@mhfsdcap03> From: Tomasz Figa Date: Fri, 12 Jun 2020 20:39:30 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [V9, 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver To: Dongchun Zhu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200612_113947_236699_3FC52B18 X-CRM114-Status: GOOD ( 19.96 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Andy Shevchenko , srv_heupstream , linux-devicetree , Linus Walleij , =?UTF-8?B?U2hlbmduYW4gV2FuZyAo546L5Zyj55S3KQ==?= , Louis Kuo , Bartosz Golaszewski , Sj Huang , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Sakari Ailus , Matthias Brugger , Cao Bing Bu , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Jun 12, 2020 at 12:49 PM Dongchun Zhu wrote: > > Hi Tomasz, > > On Wed, 2020-06-10 at 19:44 +0000, Tomasz Figa wrote: > > Hi Dongchun, > > > > On Sat, May 23, 2020 at 04:41:03PM +0800, Dongchun Zhu wrote: > > > Add a V4L2 sub-device driver for OV02A10 image sensor. > > > > > > Signed-off-by: Dongchun Zhu > > > --- > > > MAINTAINERS | 1 + > > > drivers/media/i2c/Kconfig | 13 + > > > drivers/media/i2c/Makefile | 1 + > > > drivers/media/i2c/ov02a10.c | 1025 +++++++++++++++++++++++++++++++++++++++++++ > > > 4 files changed, 1040 insertions(+) > > > create mode 100644 drivers/media/i2c/ov02a10.c > > > > > > > Thank you for the patch. Please see my comments inline. > > > > [snip] > > > diff --git a/drivers/media/i2c/ov02a10.c b/drivers/media/i2c/ov02a10.c > > > new file mode 100644 > > > index 0000000..160a0b5 > > > --- /dev/null > > > +++ b/drivers/media/i2c/ov02a10.c > > [snip] > > > +static const char * const ov02a10_test_pattern_menu[] = { > > > + "Disabled", > > > + "Color Bar", > > > > nit: We should normalize this to one of the standard names. What is the > > pattern on this sensor? Is it perhaps "Eight Vertical Colour Bars"? > > > > Yes. It is one kind of 'Eight Vertical Colour Bars'. > This pattern is called as 'MIPI color bar' per the datasheet. > Can we here use 'Vertical Color Bar' or 'MIPI Color Bar'? > We should try to stick to the names as exposed by existing drivers. There was an attempt to unify the naming of some Sony sensors some time ago [1]. Perhaps one of the names there matches the pattern of this sensor? [1] https://patchwork.kernel.org/patch/10711777/ Best regards, Tomasz _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19F59C433E0 for ; Fri, 12 Jun 2020 18:47:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE74B206DC for ; Fri, 12 Jun 2020 18:47:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OCuLCiTK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bRJxS+Q2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE74B206DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yy/YLM7EzOty2l/pnKP//+bMFuvvcvkjsOhaizVAvMM=; b=OCuLCiTKcFPmFD mdZHGUL+VuZNTPY/JcOgQp8sXIGSlqV7rA6vDhXZqNPvwt2lWW2juZ0LfJX5Zv9Y7sW5FKeoB6Ctn tRmQ+Lq/1gESEmGTMMe81G+u9WRALGOJYqlp0jH+0bBEnMXsnuMitxxTu9eaerVVH2sJywthAH6Po YatMg6QtQqS4fCKo7lwZxzV2yrhy08mR7Jlt7VISepcMOo1hONVGEx2mfI6TahYr/w30EvxralH/U 8e4FwuQlloEWkKSq/X5v/Yo/pDsqj0YyKRuljP4CtktRgtakQWUONKZgmr3IMtASE8SXGIKZoHc3k ojZJ34LZxRHd/PH8mvlg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjoiE-0002k6-Bn; Fri, 12 Jun 2020 18:47:34 +0000 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjoiB-0002jU-6q for linux-arm-kernel@lists.infradead.org; Fri, 12 Jun 2020 18:47:32 +0000 Received: by mail-ej1-x641.google.com with SMTP id o15so11055842ejm.12 for ; Fri, 12 Jun 2020 11:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P8sNBYcte/zk1gJm2YzOJRDjejnEUqN/A2ieuNyUweg=; b=bRJxS+Q2KQuM54a8erBJ8qt32TXVRsXhyMB8WWOq3eNmxwrN4tec98hY1I3dgRAadb ts7ymaPP/cxcISqUJMVR1rg0hvz0g6hLj31QBZ2Q4wp8U7XtRblQESknjGvBDfox0Z06 uKeyun3azaUw4eFf03EUYyLAv5q0HMR3PsF8E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P8sNBYcte/zk1gJm2YzOJRDjejnEUqN/A2ieuNyUweg=; b=Z2roHrNAK5ceIKnjRMsHn2bfM98JH3Q1psV/reSM3rf17c3a0rogXJG/hfQsIzHNKR 2TU1WRXPI3MoUfbLacmd3N5q74zqL4CTgDTRN/zAV6PzYs6hkSebF8Z40a7+WGarT/QN Np+zvBiPa6kzeukzrhD+mgT8qDh1lWSpvY4v69sRhmXQDycxCOCbIlfSEl/TSZUlcM/v orW3aZw9e4OQ7oLNJkqrRyH0BQaEcoHWlj/kecb4M8lyO574lzG6wj8t3fjGGtA7twTn ehcuC+XInZN6GFF/dZEOaxVmeK0aK1mGcUbuvOzyXuS/ts44LIon6zWDaf/rKDzZ5BZo MgbQ== X-Gm-Message-State: AOAM530tvYioPkqYsYxT+vEtDVTJwc/aWaul5JHuQ674RzV4fL4zBkHU 9zwsu+T1xNr5BwqMMbgZkBOhfTktcWrWcg== X-Google-Smtp-Source: ABdhPJyxjplpxD4fPRHT5sl4pcDckBif+FfIj3Yrm87VlgQZtl9n27Q0lMzAQ68S8xUd8YZ8ikzG3g== X-Received: by 2002:a17:906:e47:: with SMTP id q7mr14541704eji.279.1591987649285; Fri, 12 Jun 2020 11:47:29 -0700 (PDT) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com. [209.85.221.53]) by smtp.gmail.com with ESMTPSA id t20sm4023270ejx.27.2020.06.12.11.47.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jun 2020 11:47:29 -0700 (PDT) Received: by mail-wr1-f53.google.com with SMTP id x6so10686876wrm.13 for ; Fri, 12 Jun 2020 11:47:28 -0700 (PDT) X-Received: by 2002:a1c:2e0e:: with SMTP id u14mr257126wmu.55.1591987183150; Fri, 12 Jun 2020 11:39:43 -0700 (PDT) MIME-Version: 1.0 References: <20200523084103.31276-1-dongchun.zhu@mediatek.com> <20200523084103.31276-3-dongchun.zhu@mediatek.com> <20200610194455.GK201868@chromium.org> <1591958798.8804.660.camel@mhfsdcap03> In-Reply-To: <1591958798.8804.660.camel@mhfsdcap03> From: Tomasz Figa Date: Fri, 12 Jun 2020 20:39:30 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [V9, 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver To: Dongchun Zhu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200612_114731_266084_4E7E23D4 X-CRM114-Status: GOOD ( 21.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Andy Shevchenko , srv_heupstream , linux-devicetree , Linus Walleij , =?UTF-8?B?U2hlbmduYW4gV2FuZyAo546L5Zyj55S3KQ==?= , Louis Kuo , Bartosz Golaszewski , Sj Huang , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Sakari Ailus , Matthias Brugger , Cao Bing Bu , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 12, 2020 at 12:49 PM Dongchun Zhu wrote: > > Hi Tomasz, > > On Wed, 2020-06-10 at 19:44 +0000, Tomasz Figa wrote: > > Hi Dongchun, > > > > On Sat, May 23, 2020 at 04:41:03PM +0800, Dongchun Zhu wrote: > > > Add a V4L2 sub-device driver for OV02A10 image sensor. > > > > > > Signed-off-by: Dongchun Zhu > > > --- > > > MAINTAINERS | 1 + > > > drivers/media/i2c/Kconfig | 13 + > > > drivers/media/i2c/Makefile | 1 + > > > drivers/media/i2c/ov02a10.c | 1025 +++++++++++++++++++++++++++++++++++++++++++ > > > 4 files changed, 1040 insertions(+) > > > create mode 100644 drivers/media/i2c/ov02a10.c > > > > > > > Thank you for the patch. Please see my comments inline. > > > > [snip] > > > diff --git a/drivers/media/i2c/ov02a10.c b/drivers/media/i2c/ov02a10.c > > > new file mode 100644 > > > index 0000000..160a0b5 > > > --- /dev/null > > > +++ b/drivers/media/i2c/ov02a10.c > > [snip] > > > +static const char * const ov02a10_test_pattern_menu[] = { > > > + "Disabled", > > > + "Color Bar", > > > > nit: We should normalize this to one of the standard names. What is the > > pattern on this sensor? Is it perhaps "Eight Vertical Colour Bars"? > > > > Yes. It is one kind of 'Eight Vertical Colour Bars'. > This pattern is called as 'MIPI color bar' per the datasheet. > Can we here use 'Vertical Color Bar' or 'MIPI Color Bar'? > We should try to stick to the names as exposed by existing drivers. There was an attempt to unify the naming of some Sony sensors some time ago [1]. Perhaps one of the names there matches the pattern of this sensor? [1] https://patchwork.kernel.org/patch/10711777/ Best regards, Tomasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel