Re: [PATCH v6 04/12] intel-ipu3: Implement DMA mapping functions

[Tomasz Figa <tfiga@chromium.org>]

On Tue, Jun 19, 2018 at 12:42 AM Zhi, Yong <yong.zhi@intel.com> wrote:
>
> Hi, Tomasz,
>
> Thanks for the review.
>
> > -----Original Message-----
> > From: Tomasz Figa [mailto:tfiga@chromium.org]
> > Sent: Monday, June 18, 2018 12:09 AM
> > To: Zhi, Yong <yong.zhi@intel.com>
> > Cc: Linux Media Mailing List <linux-media@vger.kernel.org>; Sakari Ailus
> > <sakari.ailus@linux.intel.com>; Mani, Rajmohan
> > <rajmohan.mani@intel.com>; Toivonen, Tuukka
> > <tuukka.toivonen@intel.com>; Hu, Jerry W <jerry.w.hu@intel.com>; Zheng,
> > Jian Xu <jian.xu.zheng@intel.com>
> > Subject: Re: [PATCH v6 04/12] intel-ipu3: Implement DMA mapping
> > functions
> >
> > On Fri, Mar 30, 2018 at 11:15 AM Yong Zhi <yong.zhi@intel.com> wrote:
[snip]
> > > diff --git a/drivers/media/pci/intel/ipu3/ipu3.h
> > > b/drivers/media/pci/intel/ipu3/ipu3.h
> > > new file mode 100644
> > > index 000000000000..2ba6fa58e41c
> > > --- /dev/null
> > > +++ b/drivers/media/pci/intel/ipu3/ipu3.h
> > > @@ -0,0 +1,151 @@
> > > +/* SPDX-License-Identifier: GPL-2.0 */
> > > +/* Copyright (C) 2018 Intel Corporation */
> > > +
> > > +#ifndef __IPU3_H
> > > +#define __IPU3_H
> > > +
> > > +#include <linux/iova.h>
> > > +#include <linux/pci.h>
> > > +
> > > +#include <media/v4l2-device.h>
> > > +#include <media/videobuf2-dma-sg.h>
> > > +
> > > +#include "ipu3-css.h"
> > > +
> > > +#define IMGU_NAME                      "ipu3-imgu"
> > > +
> > > +/*
> > > + * The semantics of the driver is that whenever there is a buffer
> > > +available in
> > > + * master queue, the driver queues a buffer also to all other active
> > nodes.
> > > + * If user space hasn't provided a buffer to all other video nodes
> > > +first,
> > > + * the driver gets an internal dummy buffer and queues it.
> > > + */
> > > +#define IMGU_QUEUE_MASTER              IPU3_CSS_QUEUE_IN
> > > +#define IMGU_QUEUE_FIRST_INPUT         IPU3_CSS_QUEUE_OUT
> > > +#define IMGU_MAX_QUEUE_DEPTH           (2 + 2)
> > > +
> > > +#define IMGU_NODE_IN                   0 /* Input RAW image */
> > > +#define IMGU_NODE_PARAMS               1 /* Input parameters */
> > > +#define IMGU_NODE_OUT                  2 /* Main output for still or video
> > */
> > > +#define IMGU_NODE_VF                   3 /* Preview */
> > > +#define IMGU_NODE_PV                   4 /* Postview for still capture */
> > > +#define IMGU_NODE_STAT_3A              5 /* 3A statistics */
> > > +#define IMGU_NODE_NUM                  6
> >
> > Does this file really belong to this patch?
> >
>
> Included because ipu3-dmamap uses struct defined in this header.

It sounds like we should either move this patch later in the series or
have just the necessary minimum or only forward declarations added in
this patch.

Best regards,
Tomasz