From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755126AbeDPNR0 (ORCPT ); Mon, 16 Apr 2018 09:17:26 -0400 Received: from mail-vk0-f66.google.com ([209.85.213.66]:36618 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753909AbeDPNRZ (ORCPT ); Mon, 16 Apr 2018 09:17:25 -0400 X-Google-Smtp-Source: AIpwx49MYGP2L2yKxveET5Vr0xXwHltrgmPvX4/RIVuSJPSBODoc0IH6FebC1kDkJAnjXdE/U8enSQ== MIME-Version: 1.0 References: <20180405095000.9756-1-enric.balletbo@collabora.com> <20180405095000.9756-29-enric.balletbo@collabora.com> In-Reply-To: From: Tomasz Figa Date: Mon, 16 Apr 2018 13:12:07 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 28/30] drm/rockchip: Disable PSR from reboot notifier To: a.hajda@samsung.com Cc: Enric Balletbo i Serra , Archit Taneja , Inki Dae , Thierry Reding , Sandy Huang , Sean Paul , David Airlie , =?UTF-8?Q?Heiko_St=C3=BCbner?= , dri-devel , Douglas Anderson , Yakir Yang , kernel@collabora.com, Marek Szyprowski , linux-samsung-soc , jy0922.shim@samsung.com, rydberg@bitmath.org, Krzysztof Kozlowski , "open list:ARM/Rockchip SoC..." , kgene@kernel.org, linux-input@vger.kernel.org, =?UTF-8?Q?=C3=98rjan_Eide?= , Caesar Wang , Jeffy , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Mark yao , =?UTF-8?B?546L5b6B5aKe?= , Lin Huang , Jingoo Han , Seung-Woo Kim , Linux Kernel Mailing List , Kyungmin Park , Laurent Pinchart , kuankuan.y@gmail.com, Haixia Shi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrzej, On Mon, Apr 16, 2018 at 6:57 PM Andrzej Hajda wrote: > On 05.04.2018 11:49, Enric Balletbo i Serra wrote: > > From: Tomasz Figa > > > > It looks like the driver subsystem detaches devices from power domains > > at shutdown without consent of the drivers. > It looks bit strange. Could you elaborate more on it. Could you show the > code performing the detach? It not only looks strange, but it is strange. The code was present in 4.4: https://elixir.bootlin.com/linux/v4.4.128/source/drivers/base/platform.c#L553 but was apparently removed in 4.5: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/base/platform.c?h=next-20180416&id=2d30bb0b3889adf09b342722b2ce596c0763bc93 So we might not need this patch anymore. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v6 28/30] drm/rockchip: Disable PSR from reboot notifier Date: Mon, 16 Apr 2018 13:12:07 +0000 Message-ID: References: <20180405095000.9756-1-enric.balletbo@collabora.com> <20180405095000.9756-29-enric.balletbo@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: a.hajda@samsung.com Cc: David Airlie , dri-devel , Douglas Anderson , Thierry Reding , Laurent Pinchart , Yakir Yang , kernel@collabora.com, Marek Szyprowski , linux-samsung-soc , rydberg@bitmath.org, Krzysztof Kozlowski , "open list:ARM/Rockchip SoC..." , kgene@kernel.org, linux-input@vger.kernel.org, =?UTF-8?Q?=C3=98rjan_Eide?= , Caesar Wang , Jeffy , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Mark yao , =?UTF-8?B?546L5b6B5aKe?= List-Id: linux-input@vger.kernel.org SGkgQW5kcnplaiwKCk9uIE1vbiwgQXByIDE2LCAyMDE4IGF0IDY6NTcgUE0gQW5kcnplaiBIYWpk YSA8YS5oYWpkYUBzYW1zdW5nLmNvbT4gd3JvdGU6Cgo+IE9uIDA1LjA0LjIwMTggMTE6NDksIEVu cmljIEJhbGxldGJvIGkgU2VycmEgd3JvdGU6Cj4gPiBGcm9tOiBUb21hc3ogRmlnYSA8dGZpZ2FA Y2hyb21pdW0ub3JnPgo+ID4KPiA+IEl0IGxvb2tzIGxpa2UgdGhlIGRyaXZlciBzdWJzeXN0ZW0g ZGV0YWNoZXMgZGV2aWNlcyBmcm9tIHBvd2VyIGRvbWFpbnMKPiA+IGF0IHNodXRkb3duIHdpdGhv dXQgY29uc2VudCBvZiB0aGUgZHJpdmVycy4KCj4gSXQgbG9va3MgYml0IHN0cmFuZ2UuIENvdWxk IHlvdSBlbGFib3JhdGUgbW9yZSBvbiBpdC4gQ291bGQgeW91IHNob3cgdGhlCj4gY29kZSBwZXJm b3JtaW5nIHRoZSBkZXRhY2g/CgpJdCBub3Qgb25seSBsb29rcyBzdHJhbmdlLCBidXQgaXQgaXMg c3RyYW5nZS4gVGhlIGNvZGUgd2FzIHByZXNlbnQgaW4gNC40OgoKaHR0cHM6Ly9lbGl4aXIuYm9v dGxpbi5jb20vbGludXgvdjQuNC4xMjgvc291cmNlL2RyaXZlcnMvYmFzZS9wbGF0Zm9ybS5jI0w1 NTMKCmJ1dCB3YXMgYXBwYXJlbnRseSByZW1vdmVkIGluIDQuNToKCmh0dHBzOi8vZ2l0Lmtlcm5l bC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L25leHQvbGludXgtbmV4dC5naXQvY29tbWl0 L2RyaXZlcnMvYmFzZS9wbGF0Zm9ybS5jP2g9bmV4dC0yMDE4MDQxNiZpZD0yZDMwYmIwYjM4ODlh ZGYwOWIzNDI3MjJiMmNlNTk2YzA3NjNiYzkzCgpTbyB3ZSBtaWdodCBub3QgbmVlZCB0aGlzIHBh dGNoIGFueW1vcmUuCgpCZXN0IHJlZ2FyZHMsClRvbWFzegpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: tfiga@chromium.org (Tomasz Figa) Date: Mon, 16 Apr 2018 13:12:07 +0000 Subject: [PATCH v6 28/30] drm/rockchip: Disable PSR from reboot notifier In-Reply-To: References: <20180405095000.9756-1-enric.balletbo@collabora.com> <20180405095000.9756-29-enric.balletbo@collabora.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Andrzej, On Mon, Apr 16, 2018 at 6:57 PM Andrzej Hajda wrote: > On 05.04.2018 11:49, Enric Balletbo i Serra wrote: > > From: Tomasz Figa > > > > It looks like the driver subsystem detaches devices from power domains > > at shutdown without consent of the drivers. > It looks bit strange. Could you elaborate more on it. Could you show the > code performing the detach? It not only looks strange, but it is strange. The code was present in 4.4: https://elixir.bootlin.com/linux/v4.4.128/source/drivers/base/platform.c#L553 but was apparently removed in 4.5: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/base/platform.c?h=next-20180416&id=2d30bb0b3889adf09b342722b2ce596c0763bc93 So we might not need this patch anymore. Best regards, Tomasz