All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <tfiga@chromium.org>
To: Nicolas Dufresne <nicolas@ndufresne.ca>
Cc: Hirokazu Honda <hiroh@chromium.org>,
	Alexandre Courbot <acourbot@chromium.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Fritz Koenig <frkoenig@chromium.org>,
	J Kardatzke <jkardatzke@chromium.org>
Subject: Re: How to get last frames in encode sequence returned by v4l2 encoder driver without V4L2_ENC_CMD_STOP
Date: Tue, 15 Dec 2020 18:06:08 +0900	[thread overview]
Message-ID: <CAAFQd5Diajypih_Tiou6US59hqVoPXaeeDe2ut9-FtBfPBqgAg@mail.gmail.com> (raw)
In-Reply-To: <2c149355d8bde35098d03c9e1f72777d5a40eb80.camel@ndufresne.ca>

On Tue, Dec 15, 2020 at 6:12 AM Nicolas Dufresne <nicolas@ndufresne.ca> wrote:
>
> Le vendredi 11 décembre 2020 à 12:18 +0900, Tomasz Figa a écrit :
> > A lot of the hardware encoders implement only the basic codec
> > features, e.g. they would only encode in-order (no B-frames), have at
> > most 2 reference frames, etc. In that case, it's as simple as waiting
> > for dequeuing a CAPTURE buffer with a timestamp matching the OUTPUT
> > buffer being waited on.
>
> To me this is not a justification to allow not implementing that drain process
> with CMD_STOP. Having a single drain path ensure the userspace will work for
> both non-featured and full featured encoder. In the end, recommending to not
> implement CMD_STOP seems like giving vendors a short cut, which I don't think is
> beneficial to the users.
>

Fair enough. I think we've been looking for some definitive opinions
like this. :)

Best regards,
Tomasz

      reply	other threads:[~2020-12-15  9:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13  9:03 How to get last frames in encode sequence returned by v4l2 encoder driver without V4L2_ENC_CMD_STOP Hirokazu Honda
2020-11-24 10:17 ` Alexandre Courbot
2020-11-26 18:13   ` Hirokazu Honda
2020-12-08 16:43     ` Nicolas Dufresne
2020-12-09  9:51       ` Tomasz Figa
2020-12-09 16:59         ` Nicolas Dufresne
2020-12-10  4:20           ` Tomasz Figa
2020-12-10 20:27             ` Nicolas Dufresne
2020-12-11  3:18               ` Tomasz Figa
2020-12-14 21:12                 ` Nicolas Dufresne
2020-12-15  9:06                   ` Tomasz Figa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAFQd5Diajypih_Tiou6US59hqVoPXaeeDe2ut9-FtBfPBqgAg@mail.gmail.com \
    --to=tfiga@chromium.org \
    --cc=acourbot@chromium.org \
    --cc=frkoenig@chromium.org \
    --cc=hiroh@chromium.org \
    --cc=jkardatzke@chromium.org \
    --cc=linux-media@vger.kernel.org \
    --cc=nicolas@ndufresne.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.