From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pranavkumar Sawargaonkar Subject: Re: [PATCH] xen: arm: X-Gene Storm check GIC DIST address for EOI quirk Date: Thu, 16 Apr 2015 11:29:12 +0530 Message-ID: References: <1428310441-5412-1-git-send-email-pranavkumar@linaro.org> <55229C89.9080400@citrix.com> <5523B1A0.9040802@citrix.com> <1429114599.25195.4.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1429114599.25195.4.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Stefano Stabellini , "patches@apm.com" , xen-devel@lists.xen.org, Julien Grall , Stefano Stabellini , Christoffer Dall List-Id: xen-devel@lists.xenproject.org Hi Ian, On 15 April 2015 at 21:46, Ian Campbell wrote: > On Tue, 2015-04-07 at 11:29 +0100, Julien Grall wrote: >> >> This would avoid to have this loop and rely on there is always only one >> >> interrupt controller in the DT. >> > >> > That is true, however we do know that on this SoC there is only one GIC, >> > so it might be acceptable to rely on this knowledge: this is already >> > very platform specific code. >> >> If we keep the loop, I would add a comment on the above the loop >> explaining that we rely on there is always only GIC. >> >> Although, I was wondering if we could simply rely on the node path to >> get the DT node? > > If we know that all $OLD firmwares used the same path (or small set of > paths) then that could work. > > Or the loop could be replaced with dt_find_interrupt_controller, passing > the known compatible value for the systems in question. Yeah that is good option as there is no change in the path between firmware revisions. Thanks, Pranav > > Ian. >