From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0838C4338F for ; Mon, 9 Aug 2021 09:35:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BF87610A1 for ; Mon, 9 Aug 2021 09:35:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4BF87610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:50010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mD1gd-0001Iy-2B for qemu-devel@archiver.kernel.org; Mon, 09 Aug 2021 05:35:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mD1ff-00004u-Ma; Mon, 09 Aug 2021 05:34:11 -0400 Received: from mail-oi1-x22e.google.com ([2607:f8b0:4864:20::22e]:39545) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mD1fe-0008Lg-6j; Mon, 09 Aug 2021 05:34:11 -0400 Received: by mail-oi1-x22e.google.com with SMTP id bj40so3061997oib.6; Mon, 09 Aug 2021 02:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PH934TR5cbwG8FxESajOqpgE0y2P139GmILDbxkCQio=; b=o3YQrSJExcYNmY6fGqNz6IS6Hne6BG7VAHvbcBW3GRFZEjWwoy02m4QuQZ5c1k7Zrl XD32olodquRaia9hf+5+2eQJMRJJtk3kBqMSyiCWSAKO6xre+0ZZqYOsgrzrz2Hi4Xwk gSuGXLRB/8JOGLs3U2UzZpl0/c4AHGnAPEzc8J4HV14cUy0vFy+Z+R/CYzLyB/OnjD4D j2McNoSN1pniAQu9K1B90YRq0sx3YaHQiSB9rdwa3Rd0zgmFNIx+ZgYL1SgNxnd8BOs3 zOReITCrzpBJqbx/CAmYbypbETsYndnoOpLgmNKC9XeJPS9HUn6Rj17YwCbA4tNpqjgt cM6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PH934TR5cbwG8FxESajOqpgE0y2P139GmILDbxkCQio=; b=TDkcWdxIiJ7SimMk+70NktPcJe+udx9cs0/iUpDVJWQjvZBC59e0vBRye2sAPI0WO/ OqwFU1P6NRcSM0Prf8R6SXfpkErZSlBBrFns7EZGZ/uzaogVG8brtrl1a6zV5Brh/zvx R6v/xoRz7CEG3X33KTR4nNX7iBi18H69kFOL57UCIFZQEzclNgOvq+t/MlQQDgv12Srm +luwi6SWQ7mO9/pRtEoip4lvotiP0LYFIyjh24JTLahpG0fIYBKLWNWMnqXVkYUQCNuL D/kOfG7HPI+vX2CaSCSaQwidvNm+l8pA6dkq7CFc7UKFjWM0P3KGQzjlb2N2UIDXYl9U n2zQ== X-Gm-Message-State: AOAM532nzq85hQ2If1JBH8jQs/gte6iOw1g0pW96J3pd6v8WqyQZCZ5p DHqRIdCY7o2H5eNm+MX2JwISRkdiFyS/NrFYay8= X-Google-Smtp-Source: ABdhPJwm+NI855erzPNmfVMF1cMuvRb8B4IgwJ9WpRhAtCBX9uJYzdP1lqP8O9z80wf5proQ9g3RNqLBe/0K2dKOtpA= X-Received: by 2002:a05:6808:68d:: with SMTP id k13mr14822491oig.83.1628501648002; Mon, 09 Aug 2021 02:34:08 -0700 (PDT) MIME-Version: 1.0 References: <1628059910-12060-1-git-send-email-cyruscyliu@gmail.com> <20210806144209.nbx4vlm6ofkza5pl@mozz.bu.edu> In-Reply-To: From: Qiang Liu Date: Mon, 9 Aug 2021 11:33:56 +0200 Message-ID: Subject: Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read To: Peter Maydell Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::22e; envelope-from=cyruscyliu@gmail.com; helo=mail-oi1-x22e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Alistair Francis , "open list:All patches CC here" , Alexander Bulekov , Bandan Das , "open list:Xilinx ZynqMP and..." , Stefan Hajnoczi , "Edgar E. Iglesias" , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Thank you for all the insightful comments about the separated patches. This would be my first time to format a serial of patches. Does it look like below? [PATCH v3 00/2] title [PATCH v3 01/2] fix [PATCH v3 02/2] test Best, Qiang On Mon, Aug 9, 2021 at 11:24 AM Peter Maydell wrote: > > On Fri, 6 Aug 2021 at 15:43, Alexander Bulekov wrote: > > As a side note(not strictly related to this fix) should we continue > > joining reproducer patches with the fixes? In order to test the > > reproducer, you need to cleave the fix off the patch. At the same time > > we don't want to mess up bisection, so does it make sense to have the > > reproducer patch be separate but come last in the series? > > My preference is for the test case as a separate patch, last > in the series. For this kind of minor easy-to-review fix it > matters less, but sometimes the right fix for a problem might > be larger or more complicated, and then having the test case > in the same patch makes that patch awkwardly large. > > Also the person able to review the code change and the person > able to review the test case might not be the same... > > thanks > -- PMM