All of lore.kernel.org
 help / color / mirror / Atom feed
From: Govindraj <govindraj.ti@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3
Date: Thu, 22 Dec 2011 16:19:23 +0530	[thread overview]
Message-ID: <CAAL8m4wfEMcOj0KwU5zFZP6RA22yeyeRVQ97DK3ezThBNLCF3Q@mail.gmail.com> (raw)
In-Reply-To: <4EF2FF9B.90901@compulab.co.il>

On Thu, Dec 22, 2011 at 3:29 PM, Igor Grinberg <grinberg@compulab.co.il> wrote:
> On 12/22/11 11:26, Govindraj wrote:
>> Hi Igor,
>>

[...]

>>
>> probably the right method to do is as we did for panda,
>>
>> Add to armv7/omap3/clock.c (soc specific code) to enable usb-host clocks.
>>
>> as done in below patch for omap4 socs.
>>
>> http://patchwork.ozlabs.org/patch/131365/
>
> Hmmm... I don't like that patch - this is the right method...
> but only for panda!
> For panda it makes sense to enable the USB related clocks by default
> because it has many of its boot important peripherals wired to USB.
> That is not the case with majority of OMAP3 (and I bet with many
> other OMAP4) boards.
> Therefore, I think the USB clocks need to be turned on
> only if the board requests them to be turned on and not as a part
> of the default clock initialization by the PRCM subsystem
> (unless it is configurable in the board config file).
>

okay, I thought nothing wrong in keeping them enabled by default.
since all un-used clocks will be gated once kernel is loaded.
Am I missing some thing here?

so as discussed earlier we can add ehci_omap3_clock_init
into ehci-omap.c that can be used from all omap3 socs.

--
Thanks,
Govindraj.R

  reply	other threads:[~2011-12-22 10:49 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12 23:15 [U-Boot] [PATCH V4 0/2] Support for HTKW mcx board Ilya Yanok
2011-12-12 23:15 ` [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3 Ilya Yanok
2011-12-19 23:17   ` Ilya Yanok
2011-12-22  6:55   ` Govindraj
2011-12-22  8:14     ` Igor Grinberg
2011-12-22  9:26       ` Govindraj
2011-12-22  9:59         ` Igor Grinberg
2011-12-22 10:49           ` Govindraj [this message]
2011-12-22 11:18             ` Igor Grinberg
2011-12-22 11:42               ` Govindraj
2011-12-22 13:24     ` Ilya Yanok
2012-01-15 20:40       ` Remy Bohmer
2012-01-15 22:04         ` Tom Rini
2012-01-16  7:58           ` Govindraj
2012-01-16  9:57             ` Stefano Babic
2012-01-17  6:14               ` Govindraj
2012-01-25 10:32                 ` Stefano Babic
2012-01-25 20:49                   ` Tom Rini
2012-01-27  9:07                     ` Govindraj
2012-01-27  9:12                       ` Stefano Babic
2011-12-12 23:15 ` [U-Boot] [PATCH V4 2/2] mcx: support for HTKW mcx board Ilya Yanok
2011-12-13 18:52   ` Tom Rini
2011-12-13 18:57     ` Ilya Yanok
2011-12-13 19:13     ` Ilya Yanok
2011-12-13 19:30       ` Tom Rini
2011-12-13 19:44         ` Ilya Yanok
2011-12-13 21:47           ` Tom Rini
2011-12-14  0:06             ` Ilya Yanok
2011-12-14  2:48               ` Tom Rini
2011-12-14 16:09                 ` Ilya Yanok
2011-12-13 23:54     ` [U-Boot] [PATCH V5 " Ilya Yanok
2011-12-14 16:05       ` [U-Boot] [PATCH V6 " Ilya Yanok
2011-12-19 22:55         ` Ilya Yanok
2011-12-19 22:56           ` Tom Rini
2011-12-19 23:07             ` Ilya Yanok
2011-12-19 23:12             ` Anatolij Gustschin
2011-12-19 23:16               ` Ilya Yanok
2012-02-05 14:57         ` [U-Boot] [PATCH V7] " Stefano Babic
2012-02-06 12:42           ` Igor Grinberg
2012-02-08  9:30         ` [U-Boot] [PATCH V8] " Stefano Babic
2012-02-08 10:07           ` Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAL8m4wfEMcOj0KwU5zFZP6RA22yeyeRVQ97DK3ezThBNLCF3Q@mail.gmail.com \
    --to=govindraj.ti@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.