From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btiNg-0001lu-G8 for qemu-devel@nongnu.org; Mon, 10 Oct 2016 17:45:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btiNe-0002Ig-FW for qemu-devel@nongnu.org; Mon, 10 Oct 2016 17:45:07 -0400 Received: from mail-yw0-x233.google.com ([2607:f8b0:4002:c05::233]:34962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btiNe-0002I7-As for qemu-devel@nongnu.org; Mon, 10 Oct 2016 17:45:06 -0400 Received: by mail-yw0-x233.google.com with SMTP id t193so1585861ywc.2 for ; Mon, 10 Oct 2016 14:45:05 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1475316333-9776-1-git-send-email-atar4qemu@gmail.com> <1475316333-9776-4-git-send-email-atar4qemu@gmail.com> From: Artyom Tarasenko Date: Mon, 10 Oct 2016 23:45:05 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 03/29] target-sparc: add UA2005 TTE bit #defines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Mark Cave-Ayland , qemu-devel@nongnu.org, Artyom Tarasenko 10 =D0=BE=D0=BA=D1=82. 2016 =D0=B3. 23:22 =D0=BF=D0=BE=D0=BB=D1=8C=D0=B7=D0= =BE=D0=B2=D0=B0=D1=82=D0=B5=D0=BB=D1=8C "Richard Henderson" =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB: > > On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: >> >> #define TTE_VALID_BIT (1ULL << 63) >> #define TTE_NFO_BIT (1ULL << 60) >> +#define TTE_NFO_BIT_UA2005 (1ULL << 62) >> #define TTE_USED_BIT (1ULL << 41) >> +#define TTE_USED_BIT_UA2005 (1ULL << 47) >> #define TTE_LOCKED_BIT (1ULL << 6) >> +#define TTE_LOCKED_BIT_UA2005 (1ULL << 61) >> #define TTE_SIDEEFFECT_BIT (1ULL << 3) >> +#define TTE_SIDEEFFECT_BIT_UA2005 (1ULL << 11) >> #define TTE_PRIV_BIT (1ULL << 2) >> +#define TTE_PRIV_BIT_UA2005 (1ULL << 8) >> #define TTE_W_OK_BIT (1ULL << 1) >> +#define TTE_W_OK_BIT_UA2005 (1ULL << 6) >> #define TTE_GLOBAL_BIT (1ULL << 0) > > > Hmm. Would it make more sense to reorg these as > > TTE_US1_* > TTE_UA2005_* > > with some duplication for the bits that are shared? > As is, it's pretty hard to tell which actually change... All of them :-) I'm not sure about renaming: the US1 format is still used in T1 on the read access. On the other hand, it's not used in T2. And then again we don't have the T2 emulation yet. Artyom