From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9538AC43334 for ; Thu, 30 Jun 2022 03:30:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231261AbiF3Da4 (ORCPT ); Wed, 29 Jun 2022 23:30:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbiF3Daz (ORCPT ); Wed, 29 Jun 2022 23:30:55 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C003935DF0 for ; Wed, 29 Jun 2022 20:30:53 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id c6-20020a17090abf0600b001eee794a478so1515870pjs.1 for ; Wed, 29 Jun 2022 20:30:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1lF8MkXs5883DfUfDR1Xvu2FzEHm7pW23hqkIaejFGg=; b=ciGZORhFC6hDX6Cof/QgyGl5rYrdpGQpedbBrYaR2civl5FUazww7nwG97e8lyhrnm eea8qjk/U6WBeHse0nWPrjLFtDahL1JWvxq6YeyJc4U9aol5fEFr4SD5IPH2jMpdbGrR VsUGcL2A31eKZN6wvLL7sXhScZ7fAsU1toRQ28eclovbxT0hFjfS6Pay/MreHJMDER2A VDRE5kqZChcLXQCVjn6GwO/ga7ILzkQWJ8CvO2i1cLRaK2gkwWpN1abr7Kj3dXmb5G6Y RUkQAzBe7906rcdC4H27THc+9xalerWHZZeYQPPKk5yqGaZeWHFZKGphsXbrGWfeHscw JVpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1lF8MkXs5883DfUfDR1Xvu2FzEHm7pW23hqkIaejFGg=; b=hAITmhKp4LPB1dcYnxYlwz9fUNTx7dv4xKuhByIP/LpbPFoqzQ+NIqDo3zNgSeJ89O PK1lyUeRS1nH+b5xs7LdludkxRmy2y9p3G3R1Q6jCUyqD51dDBugKHA+GmgFsJeOfhYP YyEaH6Km4LS8ZKI+u5MF0In4qW7TGX+tcYOCigIcrBJH6q4b3JdEtK0WIfZReslSCiza wgxTfMfD4n5qyLlRngplTxbrBdbezbIgAy+bPgpjmqjRQS2lNCn+GhuSrls1Vyp2qZUJ Er+Ds/lQUJ+n7Wu2JwHGXlC0iKO0eG2/nniDwKVYRwnryv+RfUJvoeLfVzpKcq7OJpEf TwyA== X-Gm-Message-State: AJIora+SpX0qLIKgXOTmS0mfKVmc/uNThH5jAPpRWGNVqwY3ikzWUNXo eVe50ZfeRJo2ua8f4MXQwKStrwYntwHvnfzxXdM= X-Google-Smtp-Source: AGRyM1seNPXqpfpDZm6hHzu7lrzg9GPoWVZvm3NBfXDyWT4pq9+Gnoym51q2cYl24AM4JmGsKRRyJYlqmgGSX0zv7Fs= X-Received: by 2002:a17:902:ac90:b0:16a:1c0d:b586 with SMTP id h16-20020a170902ac9000b0016a1c0db586mr13565558plr.155.1656559853313; Wed, 29 Jun 2022 20:30:53 -0700 (PDT) MIME-Version: 1.0 References: <20220627020203.173293-1-xiubli@redhat.com> <04405a13-5d9e-232a-58fe-ef22783f4881@redhat.com> In-Reply-To: <04405a13-5d9e-232a-58fe-ef22783f4881@redhat.com> From: "Yan, Zheng" Date: Thu, 30 Jun 2022 11:30:41 +0800 Message-ID: Subject: Re: [PATCH v2 0/2] ceph: switch to 4KB block size if quota size is not aligned to 4MB To: Xiubo Li Cc: Jeff Layton , Ilya Dryomov , Venky Shankar , Patrick Donnelly , Luis Henriques , ceph-devel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org On Thu, Jun 30, 2022 at 11:05 AM Xiubo Li wrote: > > > On 6/30/22 10:39 AM, Yan, Zheng wrote: > > NACK, this change will significantly increase mds load. Inaccuracy is > > inherent in current quota design. > > Yeah, I was also thinking could we just allow the quota size to be > aligned to 4KB if it < 4MB, or must be aligned to 4MB ? > > Any idea ? make sense > > - Xiubo > > > > On Mon, Jun 27, 2022 at 10:06 AM wrote: > >> From: Xiubo Li > >> > >> V2: > >> - Switched to IS_ALIGNED() macro > >> - Added CEPH_4K_BLOCK_SIZE macro > >> - Rename CEPH_BLOCK to CEPH_BLOCK_SIZE > >> > >> Xiubo Li (3): > >> ceph: make f_bsize always equal to f_frsize > >> ceph: switch to use CEPH_4K_BLOCK_SHIFT macro > >> ceph: switch to 4KB block size if quota size is not aligned to 4MB > >> > >> fs/ceph/quota.c | 32 ++++++++++++++++++++------------ > >> fs/ceph/super.c | 28 ++++++++++++++-------------- > >> fs/ceph/super.h | 5 +++-- > >> 3 files changed, 37 insertions(+), 28 deletions(-) > >> > >> -- > >> 2.36.0.rc1 > >> >