From: Gary Bisson <gary.bisson@boundarydevices.com>
To: Yuqing Zhu <carol.zhu@nxp.com>
Cc: meta-freescale Mailing List <meta-freescale@yoctoproject.org>
Subject: Re: [PATCH] imx-vpu-hantro: Fix h1 encoder build issue
Date: Wed, 10 Oct 2018 12:48:42 +0200 [thread overview]
Message-ID: <CAAMH-ytC1PZOCv83pW6P5gCu1ZH8BmY9EUmJ5PY_n6Bx_bGykQ@mail.gmail.com> (raw)
In-Reply-To: <1539051335-9515-1-git-send-email-carol.zhu@nxp.com>
Hi Carol,
On Tue, Oct 9, 2018 at 4:16 AM Carol Zhu <carol.zhu@nxp.com> wrote:
>
> Modify the environment setting of h1 encoder to
> correct include header directory, make LINUX_VERSION_CODE
> come from kernel build folder instead of toolchain headers.
>
> Signed-off-by: Yuqing Zhu <carol.zhu@nxp.com>
> ---
> .../0002-Fix-version.h-inclusion-to-be-from-kernel-build-fold.patch | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-bsp/imx-vpu-hantro/imx-vpu-hantro/0002-Fix-version.h-inclusion-to-be-from-kernel-build-fold.patch b/recipes-bsp/imx-vpu-hantro/imx-vpu-hantro/0002-Fix-version.h-inclusion-to-be-from-kernel-build-fold.patch
> index e9bf925..9d54223 100644
> --- a/recipes-bsp/imx-vpu-hantro/imx-vpu-hantro/0002-Fix-version.h-inclusion-to-be-from-kernel-build-fold.patch
> +++ b/recipes-bsp/imx-vpu-hantro/imx-vpu-hantro/0002-Fix-version.h-inclusion-to-be-from-kernel-build-fold.patch
> @@ -34,7 +34,7 @@ index 56b4332..0be43ce 100755
> ENV += -I$(LINUX_KERNEL_ROOT)/drivers/staging/android/uapi
>
> +# LINUX_VERSION_CODE from kernel build folder instead of toolchain headers
> -+INCLUDE_HEADERS += -I$(LINUX_KERNEL_BUILD)/include/generated/uapi
> ++ENV += -I$(LINUX_KERNEL_BUILD)/include/generated/uapi
> +
> LIBENCNAME = libcodec_enc
> LIBSENC = -L./ -lhantro_h1 -lpthread
> --
> 1.9.1
I now see what was the issue, I copied the same fix on both Makefile
although one is using INCLUDE_HEADERS and the other ENV.
Thanks for the fix!
Reviewed-by: Gary Bisson <gary.bisson@boundarydevices.com>
Regards,
Gary
prev parent reply other threads:[~2018-10-10 10:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 2:16 [PATCH] imx-vpu-hantro: Fix h1 encoder build issue Carol Zhu
2018-10-10 10:48 ` Gary Bisson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAMH-ytC1PZOCv83pW6P5gCu1ZH8BmY9EUmJ5PY_n6Bx_bGykQ@mail.gmail.com \
--to=gary.bisson@boundarydevices.com \
--cc=carol.zhu@nxp.com \
--cc=meta-freescale@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.