From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DC8DC433ED for ; Sun, 25 Apr 2021 09:56:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 175B5611BF for ; Sun, 25 Apr 2021 09:56:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229913AbhDYJ50 (ORCPT ); Sun, 25 Apr 2021 05:57:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229707AbhDYJ50 (ORCPT ); Sun, 25 Apr 2021 05:57:26 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CA8FC061756 for ; Sun, 25 Apr 2021 02:56:47 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id a4so52788586wrr.2 for ; Sun, 25 Apr 2021 02:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flodin-me.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LpEneUQUuKYLL+bMl+mBYvXtYXwOrE7cfnqn3TgcuTA=; b=gNvEtBwalKMNDxGaOQDpOVetAsU6hNibw9wdJFHzdn+UP6X1WX/2//CJj3YjAaQNLq 7tEq4FYWNmKsWYXdlIsB8FzwXBl5cUZTx3tyml35Yo9q9yiDoT3bkXjlBN8+60/b4KZj S0dGamXQmbQeuruH3xaPDSs9koySl+r1Mo8W1Lq79p3yKgD5fpDfarmjJBiIFCs9ZC+D EWSWS0K+YQGhT6jk+BDCdsYWzyfrfVGNK2fxmorhVPpU5GIqEzoQX9UebmOcYlpFoqoj cshkTKTbYl9gDILSpWAi/CDsVwfJ+y/inwEO8ab5YCe3EO8cyjQeR9IoNp1WMXPCth46 i30g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LpEneUQUuKYLL+bMl+mBYvXtYXwOrE7cfnqn3TgcuTA=; b=arnFYHk0dpvUbAIiYs6ocAA7RJys08iD+4R/Slbx4y20lENCUX3zEhQ7l2D1Wu7ZdG b1FgCH5AFAq+OWO3AOmenflBDQYd4/fTl6q5SukgBkdwi+CrVuFdi/qYRPCRIyFOH06N HJ3hq7sC+ci1WXnkfwODEnrsULJT9twCAsdSoMj/ayBSa++DSBqYQrrOZIx8wrck6OLa TDHZR5Gbc1P9YpTWT2NYKay9unwlI7itsH3gd0UZnCO930hu2/hAPG7ffcqScK5rfjhm ZLeS5fiiR8yv/S9NDkm+Yh6ody/jjQ3o19dzw/dULu3whC/oL+m8sgX/VF+cRC8BdoYf Q+jw== X-Gm-Message-State: AOAM533UmveEze9pzsIvBjNZPox2Lyqzt1Hm1sKz3av32cbhWprHLH9M 1N+Xv1YY9XPQ8ZWcJvs/wZDrypzmR8qDPKsSXtBcDA== X-Google-Smtp-Source: ABdhPJz04fLCEZLYCV5+ZcH+V8F7prRVP5w5jR900dtPXUm+drMpzfL1xdjkdaH+HqH8r0LChfYCczlPLm/uMIYJTqg= X-Received: by 2002:a5d:524e:: with SMTP id k14mr15722421wrc.282.1619344605885; Sun, 25 Apr 2021 02:56:45 -0700 (PDT) MIME-Version: 1.0 References: <20210425084950.171529-1-erik@flodin.me> <20210425090751.2jqj4yqx5ztyqhvg@pengutronix.de> In-Reply-To: <20210425090751.2jqj4yqx5ztyqhvg@pengutronix.de> From: Erik Flodin Date: Sun, 25 Apr 2021 11:56:34 +0200 Message-ID: Subject: Re: [PATCH] can: fix proc/can/net/rcvlist_* header alignment on 64-bit system To: Marc Kleine-Budde Cc: Oliver Hartkopp , "David S. Miller" , Jakub Kicinski , linux-can@vger.kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org Hi, On Sun, 25 Apr 2021 at 11:07, Marc Kleine-Budde wrote: > the subject is not 100% correct, actually it is /proc/net/can/rcvlist_* Good catch. That was sloppy of me... > nitpick: > For printed strings it's better to have them in a single line, so that > grepping for them is easier. I wasn't sure if I should keep the existing layout or change it since the include %s probably makes it hard(er) to grep anyway. But I've changed it in the fixed patch. Thanks for your comments! // Erik