From: Scott Tracy <scott.a.tracy@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/rtlwifi: Fixing formatting warnings from checkpatch.pl.
Date: Fri, 5 Oct 2018 19:21:55 -0600 [thread overview]
Message-ID: <CAANxuDfv3CSssyaASbbTqXEtde-GkpJojTMVj=octOnTvZvDOw@mail.gmail.com> (raw)
In-Reply-To: <c53084c6be538d127db8b88dec4babc7eb7c6a9f.camel@perches.com>
On Fri, Oct 5, 2018 at 6:37 PM Joe Perches <joe@perches.com> wrote:
>
> On Fri, 2018-10-05 at 16:58 -0600, Scott Tracy wrote:
> > Fixing formatting warnings in rtlwifi found by checkpatch.pl
> > Changes include breaking up functions calls into multi line calls.
> > No functional/logical changes.
>
> I believe the code is better before most of these changes.
>
> There are various tradeoffs do source code formatting.
>
> Here you are changing some alignment to open parentheses
> and converting to < 80 columns.
>
>
Joe,
Thanks for the criticism. Fair comments all. I was just working
through the KernelNewbies.org tutorial looking for low value changes
to get my feet wet and assumed that a "check" was better than a
"warning". A also didn't feel confident enough to refactor the code to
get under the 80 character limit. Maybe I will spend a little more
time refactoring something and then submitting that. Thanks again,
Scott Tracy
prev parent reply other threads:[~2018-10-06 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 22:58 [PATCH] staging/rtlwifi: Fixing formatting warnings from checkpatch.pl Scott Tracy
2018-10-06 0:37 ` Joe Perches
2018-10-06 1:21 ` Scott Tracy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAANxuDfv3CSssyaASbbTqXEtde-GkpJojTMVj=octOnTvZvDOw@mail.gmail.com' \
--to=scott.a.tracy@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.