From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B106C433DB for ; Fri, 12 Feb 2021 07:03:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DB8164E6C for ; Fri, 12 Feb 2021 07:03:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229832AbhBLHDh (ORCPT ); Fri, 12 Feb 2021 02:03:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbhBLHD0 (ORCPT ); Fri, 12 Feb 2021 02:03:26 -0500 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36647C061574; Thu, 11 Feb 2021 23:02:46 -0800 (PST) Received: by mail-pf1-x42b.google.com with SMTP id z6so5283844pfq.0; Thu, 11 Feb 2021 23:02:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cqb8crGhVkKzzGd941c2UaiHlVzZ3rTlX5jrMS/aJgo=; b=Mmvux/2EdFH6qYmNFzk90U9/P+n0RXArvrKEqnDJ59bHVS+fshV1bCImY21WtGr+2s KUo0mVfbd/FtnpjPA9f+5bd5L1A0G6m3/Yr3jho6alhvDt5wcnnW2rwWsqGXZmXF9RdU g9HnVD24xZbGYpBtk4xx8jDO34zS+dOSay5ME2ImLqvKPhYkXzgt274rTiafPBH9npC6 uFoQ/GLclU/dBUfzZtXnPD3y/5JTqXs9MYBZo9EXlFlzeKpnRpbvlLgG0Q1G+3ffhMyR qUjbi2n9IKbNVG6ai5dWCBYf0yii9T63uY42EP7l2uy5FT4cSeQhxciyzHRRR3eo29VO wTJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cqb8crGhVkKzzGd941c2UaiHlVzZ3rTlX5jrMS/aJgo=; b=t8HtQIGIuM62DucuUbg/k8No/kN++/mMPpk4tob87gN2oT3aXssYyOmKospuyWjmr+ M0SQ1TOV+E1vJjn2K5KWItiixqVSs3XQEPbAoadNBmm6l6igz6fJjI/WCC8U6CjjNrpf I3hnX3TdgQfsdHAOe/CaiaIJ0V2MUtFY1yhLM4uAli3vMdhi08DKb/C0I5PPwcuwP+aV YOVb1PILzoossrlB3rDk7KREe+XUlPrQKC/GX3P5mT8ZmkMl2vsBggIyy4As9LGF6qnW 6aGiEG9IO39rZt5nEJNuCJwm0xhF/HXu/i8aDLq0jE6F3FrYkbvZCR9lYqx4Oh66iARw cfYw== X-Gm-Message-State: AOAM531+JvPrwIxXu/9zrGVT+8hQaI+xgKgO5BY+2+53Y3rtHgGYfhde 0/G782oKGKkaTQfZ3BHxL++mLFwYsdFJp1d8Tas= X-Google-Smtp-Source: ABdhPJw0vhaXQf/Vz7m7Mz+KLK/CwAl85SZ7BaTFRUDDQ3jUrlBEe8DZi2ms7wjBYCv1O9cD3gDQQ9v3EAeaaDR6pDo= X-Received: by 2002:a63:2e01:: with SMTP id u1mr1881382pgu.408.1613113365774; Thu, 11 Feb 2021 23:02:45 -0800 (PST) MIME-Version: 1.0 References: <20201204102901.109709-1-marekx.majtyka@intel.com> <20201209125223.49096d50@carbon> <1e5e044c8382a68a8a547a1892b48fb21d53dbb9.camel@kernel.org> <6f8c23d4ac60525830399754b4891c12943b63ac.camel@kernel.org> <87h7mvsr0e.fsf@toke.dk> <87bld2smi9.fsf@toke.dk> <20210202113456.30cfe21e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210203090232.4a259958@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <874kikry66.fsf@toke.dk> <20210210103135.38921f85@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <87czx7r0w8.fsf@toke.dk> <20210211172603.17d6a8f6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: From: Marek Majtyka Date: Fri, 12 Feb 2021 08:02:34 +0100 Message-ID: Subject: Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set To: Alexei Starovoitov Cc: Jakub Kicinski , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Saeed Mahameed , David Ahern , Maciej Fijalkowski , John Fastabend , Jesper Dangaard Brouer , Daniel Borkmann , Maciej Fijalkowski , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Andrii Nakryiko , Jonathan Lemon , Alexei Starovoitov , Network Development , "David S. Miller" , Jesper Dangaard Brouer , bpf , intel-wired-lan , "Karlsson, Magnus" , Jeff Kirsher Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, Feb 12, 2021 at 3:05 AM Alexei Starovoitov wrote: > > On Thu, Feb 11, 2021 at 5:26 PM Jakub Kicinski wrote: > > > > Perhaps I had seen one too many vendor incompatibility to trust that > > adding a driver API without a validation suite will result in something > > usable in production settings. > > I agree with Jakub. I don't see how extra ethtool reporting will help. > Anyone who wants to know whether eth0 supports XDP_REDIRECT can already do so: > ethtool -S eth0 | grep xdp_redirect Doing things right can never be treated as an addition. It is the other way around. Option -S is for statistics and additionally it can show something (AFAIR there wasn't such counter xdp_redirect, it must be something new, thanks for the info). But nevertheless it cannot cover all needs IMO. Some questions worth to consider: Is this extra reporting function of statistics clearly documented in ethtool? Is this going to be clearly documented? Would it be easier for users/admins to find it? What about zero copy? Can it be available via statistics, too? What about drivers XDP transmit locking flag (latest request from Jesper)? > > I think converging on the same stat names across the drivers will make > the whole thing much more user friendly than new apis. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Majtyka Date: Fri, 12 Feb 2021 08:02:34 +0100 Subject: [Intel-wired-lan] [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set In-Reply-To: References: <20201204102901.109709-1-marekx.majtyka@intel.com> <20201209125223.49096d50@carbon> <1e5e044c8382a68a8a547a1892b48fb21d53dbb9.camel@kernel.org> <6f8c23d4ac60525830399754b4891c12943b63ac.camel@kernel.org> <87h7mvsr0e.fsf@toke.dk> <87bld2smi9.fsf@toke.dk> <20210202113456.30cfe21e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210203090232.4a259958@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <874kikry66.fsf@toke.dk> <20210210103135.38921f85@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <87czx7r0w8.fsf@toke.dk> <20210211172603.17d6a8f6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Fri, Feb 12, 2021 at 3:05 AM Alexei Starovoitov wrote: > > On Thu, Feb 11, 2021 at 5:26 PM Jakub Kicinski wrote: > > > > Perhaps I had seen one too many vendor incompatibility to trust that > > adding a driver API without a validation suite will result in something > > usable in production settings. > > I agree with Jakub. I don't see how extra ethtool reporting will help. > Anyone who wants to know whether eth0 supports XDP_REDIRECT can already do so: > ethtool -S eth0 | grep xdp_redirect Doing things right can never be treated as an addition. It is the other way around. Option -S is for statistics and additionally it can show something (AFAIR there wasn't such counter xdp_redirect, it must be something new, thanks for the info). But nevertheless it cannot cover all needs IMO. Some questions worth to consider: Is this extra reporting function of statistics clearly documented in ethtool? Is this going to be clearly documented? Would it be easier for users/admins to find it? What about zero copy? Can it be available via statistics, too? What about drivers XDP transmit locking flag (latest request from Jesper)? > > I think converging on the same stat names across the drivers will make > the whole thing much more user friendly than new apis.