From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 866D9C433F5 for ; Thu, 30 Dec 2021 16:31:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241297AbhL3Qbt (ORCPT ); Thu, 30 Dec 2021 11:31:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239850AbhL3Qbs (ORCPT ); Thu, 30 Dec 2021 11:31:48 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1FA8C061574 for ; Thu, 30 Dec 2021 08:31:48 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7502CB81C77 for ; Thu, 30 Dec 2021 16:31:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A20DC36AF0 for ; Thu, 30 Dec 2021 16:31:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1640881906; bh=DoMqZeSp31c4BdQxbZ15ZYyN+jInAOYa+pzWvuj1V+Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WAxEl4NOgOsftPaDpXfRWoi1nj9/3fBgHhYhGl4tT7fwXxVvRzy6i6pyh+KoCXk0q 8RZ7JiL0yOC2GV7fDTUlnobaRHJNyofs7qQrBSputf0GNixgO/AaaYPWBjJVLuX09g UY6WwzrRDOkUyfrqtsQDdbV4pMqS7s5C56us+39ouMSTW/lGGrTDskGcyRNQ3UHYB+ GzoO+xEf1ZGOZ9l70xvInPjANXpy5a0HDHDbURl+5luZuHGzm+wJmjUq/qdadbs3jB fYYvy6Ti9nRD/RK0j5WLKPou7gV351lmqiFPF1RO9IMihDfLLgbQ3+jVzA28Y0Ye6J +aok3dSqdoFRg== Received: by mail-ed1-f48.google.com with SMTP id j21so99927154edt.9 for ; Thu, 30 Dec 2021 08:31:46 -0800 (PST) X-Gm-Message-State: AOAM531zgxwmHX53nunDIeOJRnkCCA6r2uOSupoDWsIYvUGdNzd8AX5p vaWhH8KSTqgCKtkgUXQzhqZEluufeUWcyD+ipQ== X-Google-Smtp-Source: ABdhPJwwoCM4BACwhBGiZnGRAg9C++hI21NbvZwOdn/dltz/26/69d6R/OprjtD1A4ewX0f1NC+U3pEDXI3uVMzy1AQ= X-Received: by 2002:a17:907:629a:: with SMTP id nd26mr26535652ejc.680.1640881904439; Thu, 30 Dec 2021 08:31:44 -0800 (PST) MIME-Version: 1.0 References: <20211224082103.7658-1-linmq006@gmail.com> In-Reply-To: <20211224082103.7658-1-linmq006@gmail.com> From: Chun-Kuang Hu Date: Fri, 31 Dec 2021 00:31:33 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] phy: mediatek: Fix missing check in mtk_mipi_tx_probe To: Miaoqian Lin Cc: Chun-Kuang Hu , Philipp Zabel , Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Matthias Brugger , DRI Development , "moderated list:ARM/Mediatek SoC support" , Linux ARM , linux-phy@lists.infradead.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Miaoqian: Miaoqian Lin =E6=96=BC 2021=E5=B9=B412=E6=9C=8824=E6= =97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=884:21=E5=AF=AB=E9=81=93=EF=BC=9A > > The of_device_get_match_data() function may return NULL. > Add check to prevent potential null dereference. > > Signed-off-by: Miaoqian Lin > --- > drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c b/drivers/phy/mediat= ek/phy-mtk-mipi-dsi.c > index 28ad9403c441..67b005d5b9e3 100644 > --- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > @@ -146,6 +146,8 @@ static int mtk_mipi_tx_probe(struct platform_device *= pdev) > return -ENOMEM; > > mipi_tx->driver_data =3D of_device_get_match_data(dev); > + if (!mipi_tx->driver_data) I'm confused. mtk_mipi_tx_probe() is called because this device node's compatible match one in mtk_mipi_tx_match[]. So I think the return value of of_device_get_match_data(dev) would not be NULL. If this is true, this checking is redundant. Regards, Chun-Kuang. > + return -ENODEV; > > mipi_tx->regs =3D devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(mipi_tx->regs)) > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84070C433F5 for ; Thu, 30 Dec 2021 16:32:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zWhySwrnzpx0k+vnzlkM7J3Ch6+VYfkMWAgGC1UcvlA=; b=wZFc/PFpuuxGFg oD4eE9r3mfEEsEhUXEX3MgZHOLVCnj8/EPMU8kejdaiWgpf1vgTdcKdd1vcTHC+ydOug4YBzUV00d oMLu5ynLaPH/jv8dglDEH+CAb97PRE7HlySfYQMdn5IwU+2sqAAE/YpsppKcyjNT93UK4FTDUIC7E ML1p5qAcLy/dUpg4xpVoqtg/TekLWRsZCddCIRejDsZWYJOZQAtIew4dAfHlURn+C3W7BQJ+mSmtM FHJqoV6yBC7hh1Epa/er88Cu/M6Ke3SeO7uI0XBSBcrl83aAE1qBVdEA5nnGbDRxXKtEn0Pj18hRa dYj5jJlNgsRQXqN7IauA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2yLQ-004kyT-Jg; Thu, 30 Dec 2021 16:32:00 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2yLF-004kwb-6c; Thu, 30 Dec 2021 16:31:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 51433B81C4B; Thu, 30 Dec 2021 16:31:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2301DC36AE9; Thu, 30 Dec 2021 16:31:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1640881906; bh=DoMqZeSp31c4BdQxbZ15ZYyN+jInAOYa+pzWvuj1V+Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WAxEl4NOgOsftPaDpXfRWoi1nj9/3fBgHhYhGl4tT7fwXxVvRzy6i6pyh+KoCXk0q 8RZ7JiL0yOC2GV7fDTUlnobaRHJNyofs7qQrBSputf0GNixgO/AaaYPWBjJVLuX09g UY6WwzrRDOkUyfrqtsQDdbV4pMqS7s5C56us+39ouMSTW/lGGrTDskGcyRNQ3UHYB+ GzoO+xEf1ZGOZ9l70xvInPjANXpy5a0HDHDbURl+5luZuHGzm+wJmjUq/qdadbs3jB fYYvy6Ti9nRD/RK0j5WLKPou7gV351lmqiFPF1RO9IMihDfLLgbQ3+jVzA28Y0Ye6J +aok3dSqdoFRg== Received: by mail-ed1-f47.google.com with SMTP id l5so65365067edj.13; Thu, 30 Dec 2021 08:31:46 -0800 (PST) X-Gm-Message-State: AOAM532aGxk2vY8VUtuKPIxV0uq57a2HPUJTaUWmbLQH2Trcg920GOWp RjZ1f5y8VZLVfpD8r0Uq+iqZyR2wwjxUzryn8w== X-Google-Smtp-Source: ABdhPJwwoCM4BACwhBGiZnGRAg9C++hI21NbvZwOdn/dltz/26/69d6R/OprjtD1A4ewX0f1NC+U3pEDXI3uVMzy1AQ= X-Received: by 2002:a17:907:629a:: with SMTP id nd26mr26535652ejc.680.1640881904439; Thu, 30 Dec 2021 08:31:44 -0800 (PST) MIME-Version: 1.0 References: <20211224082103.7658-1-linmq006@gmail.com> In-Reply-To: <20211224082103.7658-1-linmq006@gmail.com> From: Chun-Kuang Hu Date: Fri, 31 Dec 2021 00:31:33 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] phy: mediatek: Fix missing check in mtk_mipi_tx_probe To: Miaoqian Lin Cc: Chun-Kuang Hu , Philipp Zabel , Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Matthias Brugger , DRI Development , "moderated list:ARM/Mediatek SoC support" , Linux ARM , linux-phy@lists.infradead.org, linux-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211230_083149_423229_A64696FB X-CRM114-Status: GOOD ( 16.35 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org SGksIE1pYW9xaWFuOgoKTWlhb3FpYW4gTGluIDxsaW5tcTAwNkBnbWFpbC5jb20+IOaWvCAyMDIx 5bm0MTLmnIgyNOaXpSDpgLHkupQg5LiL5Y2INDoyMeWvq+mBk++8mgo+Cj4gVGhlIG9mX2Rldmlj ZV9nZXRfbWF0Y2hfZGF0YSgpIGZ1bmN0aW9uIG1heSByZXR1cm4gTlVMTC4KPiBBZGQgY2hlY2sg dG8gcHJldmVudCBwb3RlbnRpYWwgbnVsbCBkZXJlZmVyZW5jZS4KPgo+IFNpZ25lZC1vZmYtYnk6 IE1pYW9xaWFuIExpbiA8bGlubXEwMDZAZ21haWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3BoeS9t ZWRpYXRlay9waHktbXRrLW1pcGktZHNpLmMgfCAyICsrCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGlu c2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9tZWRpYXRlay9waHktbXRr LW1pcGktZHNpLmMgYi9kcml2ZXJzL3BoeS9tZWRpYXRlay9waHktbXRrLW1pcGktZHNpLmMKPiBp bmRleCAyOGFkOTQwM2M0NDEuLjY3YjAwNWQ1YjllMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3Bo eS9tZWRpYXRlay9waHktbXRrLW1pcGktZHNpLmMKPiArKysgYi9kcml2ZXJzL3BoeS9tZWRpYXRl ay9waHktbXRrLW1pcGktZHNpLmMKPiBAQCAtMTQ2LDYgKzE0Niw4IEBAIHN0YXRpYyBpbnQgbXRr X21pcGlfdHhfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgICAgICAgICAg ICAgICAgcmV0dXJuIC1FTk9NRU07Cj4KPiAgICAgICAgIG1pcGlfdHgtPmRyaXZlcl9kYXRhID0g b2ZfZGV2aWNlX2dldF9tYXRjaF9kYXRhKGRldik7Cj4gKyAgICAgICBpZiAoIW1pcGlfdHgtPmRy aXZlcl9kYXRhKQoKSSdtIGNvbmZ1c2VkLiBtdGtfbWlwaV90eF9wcm9iZSgpIGlzIGNhbGxlZCBi ZWNhdXNlIHRoaXMgZGV2aWNlIG5vZGUncwpjb21wYXRpYmxlIG1hdGNoIG9uZSBpbiBtdGtfbWlw aV90eF9tYXRjaFtdLiBTbyBJIHRoaW5rIHRoZSByZXR1cm4KdmFsdWUgb2Ygb2ZfZGV2aWNlX2dl dF9tYXRjaF9kYXRhKGRldikgd291bGQgbm90IGJlIE5VTEwuIElmIHRoaXMgaXMKdHJ1ZSwgdGhp cyBjaGVja2luZyBpcyByZWR1bmRhbnQuCgpSZWdhcmRzLApDaHVuLUt1YW5nLgoKPiArICAgICAg ICAgICAgICAgcmV0dXJuIC1FTk9ERVY7Cj4KPiAgICAgICAgIG1pcGlfdHgtPnJlZ3MgPSBkZXZt X3BsYXRmb3JtX2lvcmVtYXBfcmVzb3VyY2UocGRldiwgMCk7Cj4gICAgICAgICBpZiAoSVNfRVJS KG1pcGlfdHgtPnJlZ3MpKQo+IC0tCj4gMi4xNy4xCj4KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LW1lZGlhdGVrIG1haWxpbmcgbGlzdApMaW51 eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtbWVkaWF0ZWsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63391C433EF for ; Thu, 30 Dec 2021 16:31:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7670210E141; Thu, 30 Dec 2021 16:31:48 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 51A1E10E141 for ; Thu, 30 Dec 2021 16:31:47 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B38DD61642 for ; Thu, 30 Dec 2021 16:31:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AD40C36AEB for ; Thu, 30 Dec 2021 16:31:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1640881906; bh=DoMqZeSp31c4BdQxbZ15ZYyN+jInAOYa+pzWvuj1V+Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WAxEl4NOgOsftPaDpXfRWoi1nj9/3fBgHhYhGl4tT7fwXxVvRzy6i6pyh+KoCXk0q 8RZ7JiL0yOC2GV7fDTUlnobaRHJNyofs7qQrBSputf0GNixgO/AaaYPWBjJVLuX09g UY6WwzrRDOkUyfrqtsQDdbV4pMqS7s5C56us+39ouMSTW/lGGrTDskGcyRNQ3UHYB+ GzoO+xEf1ZGOZ9l70xvInPjANXpy5a0HDHDbURl+5luZuHGzm+wJmjUq/qdadbs3jB fYYvy6Ti9nRD/RK0j5WLKPou7gV351lmqiFPF1RO9IMihDfLLgbQ3+jVzA28Y0Ye6J +aok3dSqdoFRg== Received: by mail-ed1-f43.google.com with SMTP id j6so99887160edw.12 for ; Thu, 30 Dec 2021 08:31:46 -0800 (PST) X-Gm-Message-State: AOAM531T9De/O/dMRNjQzH4HLOIutcW86YI6ZvSEl7hNM8bpNGr3fvfg 47QrQkGEgYpyCPRLd3HrFo/iS6AdENAFsU2K5Q== X-Google-Smtp-Source: ABdhPJwwoCM4BACwhBGiZnGRAg9C++hI21NbvZwOdn/dltz/26/69d6R/OprjtD1A4ewX0f1NC+U3pEDXI3uVMzy1AQ= X-Received: by 2002:a17:907:629a:: with SMTP id nd26mr26535652ejc.680.1640881904439; Thu, 30 Dec 2021 08:31:44 -0800 (PST) MIME-Version: 1.0 References: <20211224082103.7658-1-linmq006@gmail.com> In-Reply-To: <20211224082103.7658-1-linmq006@gmail.com> From: Chun-Kuang Hu Date: Fri, 31 Dec 2021 00:31:33 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] phy: mediatek: Fix missing check in mtk_mipi_tx_probe To: Miaoqian Lin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , linux-phy@lists.infradead.org, linux-kernel , DRI Development , Kishon Vijay Abraham I , Matthias Brugger , Vinod Koul , "moderated list:ARM/Mediatek SoC support" , Chunfeng Yun , Linux ARM Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Miaoqian: Miaoqian Lin =E6=96=BC 2021=E5=B9=B412=E6=9C=8824=E6= =97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=884:21=E5=AF=AB=E9=81=93=EF=BC=9A > > The of_device_get_match_data() function may return NULL. > Add check to prevent potential null dereference. > > Signed-off-by: Miaoqian Lin > --- > drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c b/drivers/phy/mediat= ek/phy-mtk-mipi-dsi.c > index 28ad9403c441..67b005d5b9e3 100644 > --- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > @@ -146,6 +146,8 @@ static int mtk_mipi_tx_probe(struct platform_device *= pdev) > return -ENOMEM; > > mipi_tx->driver_data =3D of_device_get_match_data(dev); > + if (!mipi_tx->driver_data) I'm confused. mtk_mipi_tx_probe() is called because this device node's compatible match one in mtk_mipi_tx_match[]. So I think the return value of of_device_get_match_data(dev) would not be NULL. If this is true, this checking is redundant. Regards, Chun-Kuang. > + return -ENODEV; > > mipi_tx->regs =3D devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(mipi_tx->regs)) > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BF46C433F5 for ; Thu, 30 Dec 2021 16:32:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hfq3UTqlb56LD20NQrDkz84xVVceMWjiaOt7fqOcuvY=; b=APpdYwp8lAur1q X5TyfQhbFM8YobPD+pmRWruHq9wlWqlUfvY3aBz5tl3Y+fs5+1sxtECfP+z3CdlGECj7iZmQFqClD YEbI4qAkNoHsmpkQS3mUZv016Yt4/RYSEZW2iQwYP/JO4bHgihJbi89UsxWZ5clwd6Ne0fkBejRUg d6gCNYETrO7oHccCy3brNuuCtwS0W9UFVCBiocDrPCnRy2XSeefba4T7o9o5c9fnKTkjbCZGRcumI eGnF9f1lnoweO2p2lluYJHFOfjBIQcH/VtAF/CDltNYqtjhIsRJENZrSyq1+HD6/OhHiQCDXWHLsO H80s3YqGffbqt4NLHsMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2yLR-004kyY-DP; Thu, 30 Dec 2021 16:32:01 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2yLF-004kwb-6c; Thu, 30 Dec 2021 16:31:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 51433B81C4B; Thu, 30 Dec 2021 16:31:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2301DC36AE9; Thu, 30 Dec 2021 16:31:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1640881906; bh=DoMqZeSp31c4BdQxbZ15ZYyN+jInAOYa+pzWvuj1V+Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WAxEl4NOgOsftPaDpXfRWoi1nj9/3fBgHhYhGl4tT7fwXxVvRzy6i6pyh+KoCXk0q 8RZ7JiL0yOC2GV7fDTUlnobaRHJNyofs7qQrBSputf0GNixgO/AaaYPWBjJVLuX09g UY6WwzrRDOkUyfrqtsQDdbV4pMqS7s5C56us+39ouMSTW/lGGrTDskGcyRNQ3UHYB+ GzoO+xEf1ZGOZ9l70xvInPjANXpy5a0HDHDbURl+5luZuHGzm+wJmjUq/qdadbs3jB fYYvy6Ti9nRD/RK0j5WLKPou7gV351lmqiFPF1RO9IMihDfLLgbQ3+jVzA28Y0Ye6J +aok3dSqdoFRg== Received: by mail-ed1-f47.google.com with SMTP id l5so65365067edj.13; Thu, 30 Dec 2021 08:31:46 -0800 (PST) X-Gm-Message-State: AOAM532aGxk2vY8VUtuKPIxV0uq57a2HPUJTaUWmbLQH2Trcg920GOWp RjZ1f5y8VZLVfpD8r0Uq+iqZyR2wwjxUzryn8w== X-Google-Smtp-Source: ABdhPJwwoCM4BACwhBGiZnGRAg9C++hI21NbvZwOdn/dltz/26/69d6R/OprjtD1A4ewX0f1NC+U3pEDXI3uVMzy1AQ= X-Received: by 2002:a17:907:629a:: with SMTP id nd26mr26535652ejc.680.1640881904439; Thu, 30 Dec 2021 08:31:44 -0800 (PST) MIME-Version: 1.0 References: <20211224082103.7658-1-linmq006@gmail.com> In-Reply-To: <20211224082103.7658-1-linmq006@gmail.com> From: Chun-Kuang Hu Date: Fri, 31 Dec 2021 00:31:33 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] phy: mediatek: Fix missing check in mtk_mipi_tx_probe To: Miaoqian Lin Cc: Chun-Kuang Hu , Philipp Zabel , Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Matthias Brugger , DRI Development , "moderated list:ARM/Mediatek SoC support" , Linux ARM , linux-phy@lists.infradead.org, linux-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211230_083149_423229_A64696FB X-CRM114-Status: GOOD ( 16.35 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org SGksIE1pYW9xaWFuOgoKTWlhb3FpYW4gTGluIDxsaW5tcTAwNkBnbWFpbC5jb20+IOaWvCAyMDIx 5bm0MTLmnIgyNOaXpSDpgLHkupQg5LiL5Y2INDoyMeWvq+mBk++8mgo+Cj4gVGhlIG9mX2Rldmlj ZV9nZXRfbWF0Y2hfZGF0YSgpIGZ1bmN0aW9uIG1heSByZXR1cm4gTlVMTC4KPiBBZGQgY2hlY2sg dG8gcHJldmVudCBwb3RlbnRpYWwgbnVsbCBkZXJlZmVyZW5jZS4KPgo+IFNpZ25lZC1vZmYtYnk6 IE1pYW9xaWFuIExpbiA8bGlubXEwMDZAZ21haWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3BoeS9t ZWRpYXRlay9waHktbXRrLW1pcGktZHNpLmMgfCAyICsrCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGlu c2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9tZWRpYXRlay9waHktbXRr LW1pcGktZHNpLmMgYi9kcml2ZXJzL3BoeS9tZWRpYXRlay9waHktbXRrLW1pcGktZHNpLmMKPiBp bmRleCAyOGFkOTQwM2M0NDEuLjY3YjAwNWQ1YjllMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3Bo eS9tZWRpYXRlay9waHktbXRrLW1pcGktZHNpLmMKPiArKysgYi9kcml2ZXJzL3BoeS9tZWRpYXRl ay9waHktbXRrLW1pcGktZHNpLmMKPiBAQCAtMTQ2LDYgKzE0Niw4IEBAIHN0YXRpYyBpbnQgbXRr X21pcGlfdHhfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgICAgICAgICAg ICAgICAgcmV0dXJuIC1FTk9NRU07Cj4KPiAgICAgICAgIG1pcGlfdHgtPmRyaXZlcl9kYXRhID0g b2ZfZGV2aWNlX2dldF9tYXRjaF9kYXRhKGRldik7Cj4gKyAgICAgICBpZiAoIW1pcGlfdHgtPmRy aXZlcl9kYXRhKQoKSSdtIGNvbmZ1c2VkLiBtdGtfbWlwaV90eF9wcm9iZSgpIGlzIGNhbGxlZCBi ZWNhdXNlIHRoaXMgZGV2aWNlIG5vZGUncwpjb21wYXRpYmxlIG1hdGNoIG9uZSBpbiBtdGtfbWlw aV90eF9tYXRjaFtdLiBTbyBJIHRoaW5rIHRoZSByZXR1cm4KdmFsdWUgb2Ygb2ZfZGV2aWNlX2dl dF9tYXRjaF9kYXRhKGRldikgd291bGQgbm90IGJlIE5VTEwuIElmIHRoaXMgaXMKdHJ1ZSwgdGhp cyBjaGVja2luZyBpcyByZWR1bmRhbnQuCgpSZWdhcmRzLApDaHVuLUt1YW5nLgoKPiArICAgICAg ICAgICAgICAgcmV0dXJuIC1FTk9ERVY7Cj4KPiAgICAgICAgIG1pcGlfdHgtPnJlZ3MgPSBkZXZt X3BsYXRmb3JtX2lvcmVtYXBfcmVzb3VyY2UocGRldiwgMCk7Cj4gICAgICAgICBpZiAoSVNfRVJS KG1pcGlfdHgtPnJlZ3MpKQo+IC0tCj4gMi4xNy4xCj4KCi0tIApsaW51eC1waHkgbWFpbGluZyBs aXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25893C433EF for ; Thu, 30 Dec 2021 16:33:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jyjO+CLG0O2OfZOTg3Y8wS7PoX6iS2/JsdZ0pqL7+Oo=; b=T7FN1bpUyw6/l+ i8lrrynmMOdNYu+tEIrLlRb9n6jWYUawUtNf4iahkdt1KDKd+T1C979slSl8DpxYYvzhxYgN50Iji Hr9sQU2tD/zjtw/sD8n4zfyJpbY4yYo+bC+40mY34slJq7lInvyY1dDy2qpYTC3/6gBryYKJNi44/ dq7TE8teq/WvRsd3oFl/WA4MKnm48yhAmOtUtuWc/VJDp5T2BwzQ6ZUAm0Z9CZbELeeWYfQZH8eFp xBLMoFuoprummATc3Btx0O2parmhJN/bOFtnNnoAlOT/fA88w5id8ive0n8M4rbDTKpLp6MSf84gP XBzwCX3Snr9++hNlBgIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2yLI-004kxK-C3; Thu, 30 Dec 2021 16:31:52 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2yLF-004kwb-6c; Thu, 30 Dec 2021 16:31:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 51433B81C4B; Thu, 30 Dec 2021 16:31:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2301DC36AE9; Thu, 30 Dec 2021 16:31:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1640881906; bh=DoMqZeSp31c4BdQxbZ15ZYyN+jInAOYa+pzWvuj1V+Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WAxEl4NOgOsftPaDpXfRWoi1nj9/3fBgHhYhGl4tT7fwXxVvRzy6i6pyh+KoCXk0q 8RZ7JiL0yOC2GV7fDTUlnobaRHJNyofs7qQrBSputf0GNixgO/AaaYPWBjJVLuX09g UY6WwzrRDOkUyfrqtsQDdbV4pMqS7s5C56us+39ouMSTW/lGGrTDskGcyRNQ3UHYB+ GzoO+xEf1ZGOZ9l70xvInPjANXpy5a0HDHDbURl+5luZuHGzm+wJmjUq/qdadbs3jB fYYvy6Ti9nRD/RK0j5WLKPou7gV351lmqiFPF1RO9IMihDfLLgbQ3+jVzA28Y0Ye6J +aok3dSqdoFRg== Received: by mail-ed1-f47.google.com with SMTP id l5so65365067edj.13; Thu, 30 Dec 2021 08:31:46 -0800 (PST) X-Gm-Message-State: AOAM532aGxk2vY8VUtuKPIxV0uq57a2HPUJTaUWmbLQH2Trcg920GOWp RjZ1f5y8VZLVfpD8r0Uq+iqZyR2wwjxUzryn8w== X-Google-Smtp-Source: ABdhPJwwoCM4BACwhBGiZnGRAg9C++hI21NbvZwOdn/dltz/26/69d6R/OprjtD1A4ewX0f1NC+U3pEDXI3uVMzy1AQ= X-Received: by 2002:a17:907:629a:: with SMTP id nd26mr26535652ejc.680.1640881904439; Thu, 30 Dec 2021 08:31:44 -0800 (PST) MIME-Version: 1.0 References: <20211224082103.7658-1-linmq006@gmail.com> In-Reply-To: <20211224082103.7658-1-linmq006@gmail.com> From: Chun-Kuang Hu Date: Fri, 31 Dec 2021 00:31:33 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] phy: mediatek: Fix missing check in mtk_mipi_tx_probe To: Miaoqian Lin Cc: Chun-Kuang Hu , Philipp Zabel , Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Matthias Brugger , DRI Development , "moderated list:ARM/Mediatek SoC support" , Linux ARM , linux-phy@lists.infradead.org, linux-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211230_083149_423229_A64696FB X-CRM114-Status: GOOD ( 16.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksIE1pYW9xaWFuOgoKTWlhb3FpYW4gTGluIDxsaW5tcTAwNkBnbWFpbC5jb20+IOaWvCAyMDIx 5bm0MTLmnIgyNOaXpSDpgLHkupQg5LiL5Y2INDoyMeWvq+mBk++8mgo+Cj4gVGhlIG9mX2Rldmlj ZV9nZXRfbWF0Y2hfZGF0YSgpIGZ1bmN0aW9uIG1heSByZXR1cm4gTlVMTC4KPiBBZGQgY2hlY2sg dG8gcHJldmVudCBwb3RlbnRpYWwgbnVsbCBkZXJlZmVyZW5jZS4KPgo+IFNpZ25lZC1vZmYtYnk6 IE1pYW9xaWFuIExpbiA8bGlubXEwMDZAZ21haWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3BoeS9t ZWRpYXRlay9waHktbXRrLW1pcGktZHNpLmMgfCAyICsrCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGlu c2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9tZWRpYXRlay9waHktbXRr LW1pcGktZHNpLmMgYi9kcml2ZXJzL3BoeS9tZWRpYXRlay9waHktbXRrLW1pcGktZHNpLmMKPiBp bmRleCAyOGFkOTQwM2M0NDEuLjY3YjAwNWQ1YjllMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3Bo eS9tZWRpYXRlay9waHktbXRrLW1pcGktZHNpLmMKPiArKysgYi9kcml2ZXJzL3BoeS9tZWRpYXRl ay9waHktbXRrLW1pcGktZHNpLmMKPiBAQCAtMTQ2LDYgKzE0Niw4IEBAIHN0YXRpYyBpbnQgbXRr X21pcGlfdHhfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgICAgICAgICAg ICAgICAgcmV0dXJuIC1FTk9NRU07Cj4KPiAgICAgICAgIG1pcGlfdHgtPmRyaXZlcl9kYXRhID0g b2ZfZGV2aWNlX2dldF9tYXRjaF9kYXRhKGRldik7Cj4gKyAgICAgICBpZiAoIW1pcGlfdHgtPmRy aXZlcl9kYXRhKQoKSSdtIGNvbmZ1c2VkLiBtdGtfbWlwaV90eF9wcm9iZSgpIGlzIGNhbGxlZCBi ZWNhdXNlIHRoaXMgZGV2aWNlIG5vZGUncwpjb21wYXRpYmxlIG1hdGNoIG9uZSBpbiBtdGtfbWlw aV90eF9tYXRjaFtdLiBTbyBJIHRoaW5rIHRoZSByZXR1cm4KdmFsdWUgb2Ygb2ZfZGV2aWNlX2dl dF9tYXRjaF9kYXRhKGRldikgd291bGQgbm90IGJlIE5VTEwuIElmIHRoaXMgaXMKdHJ1ZSwgdGhp cyBjaGVja2luZyBpcyByZWR1bmRhbnQuCgpSZWdhcmRzLApDaHVuLUt1YW5nLgoKPiArICAgICAg ICAgICAgICAgcmV0dXJuIC1FTk9ERVY7Cj4KPiAgICAgICAgIG1pcGlfdHgtPnJlZ3MgPSBkZXZt X3BsYXRmb3JtX2lvcmVtYXBfcmVzb3VyY2UocGRldiwgMCk7Cj4gICAgICAgICBpZiAoSVNfRVJS KG1pcGlfdHgtPnJlZ3MpKQo+IC0tCj4gMi4xNy4xCj4KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK